From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6568 invoked by alias); 18 Nov 2013 17:08:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6536 invoked by uid 89); 18 Nov 2013 17:08:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-vb0-f45.google.com Received: from Unknown (HELO mail-vb0-f45.google.com) (209.85.212.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 18 Nov 2013 17:08:08 +0000 Received: by mail-vb0-f45.google.com with SMTP id x13so2478167vbb.18 for ; Mon, 18 Nov 2013 09:07:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Kt6J4Yzhj9wpWed1wYJfWEQNKKD2JgBBcnJ8LpOWnpI=; b=cXNz0brxmrc7i8KoECiCIyHVxtMD8r7KrUOz8bmRV07Aa/WL2hLnRnbP4D/0WI+VpY 5KBlfXs3h+WcL0eWqHVbiGhSBPMI9AezBqpKd2Wioxv/ViTT3h4PqI21GLbx5lTtifSA fRb+AARKoCjDW2nj+xbYK/ABaVQ0dyyPKLjtQoUk0OlJA057ipHW1BA2wPDK00gDn358 AVZ0s6wV25MoF2oik2yquLe6ep5fWVDclDDLKXH+WMkkVLXS8SYSqTk9ATMA3DvJP+S9 yh7gpu2rt8k4duxDB580zYguaVZzKARyUT+z8dNToekjy011JiCbb/qd5ZXktZXSXgWO m+0Q== X-Gm-Message-State: ALoCoQkLr8KGbEV3CTHiEUKcAarBpES/cz6zXq+8KJZWaUegHFj49eOEZJcBUR7oymle8aXv0nmhOU9S7ka/S+91bz28yJbZBDYNfjOdkgxU+nqMgwZ8iLz9JKSv4cgDYcfq72vsgqHfewacqjBPffEP8S0U3dZmc4Ew4nrmQDDOPZgvUdkUTvSG3z00ZPCgG7OFiq5lj2knSot3T6E9LdimG5DjTVbkrA== MIME-Version: 1.0 X-Received: by 10.58.210.66 with SMTP id ms2mr16709377vec.10.1384794479027; Mon, 18 Nov 2013 09:07:59 -0800 (PST) Received: by 10.52.163.52 with HTTP; Mon, 18 Nov 2013 09:07:58 -0800 (PST) In-Reply-To: <5289CE0B.30709@codesourcery.com> References: <1383458049-20893-1-git-send-email-yao@codesourcery.com> <5289CE0B.30709@codesourcery.com> Date: Mon, 18 Nov 2013 17:12:00 -0000 Message-ID: Subject: Re: [PATCH 10/10] Use target_read_code in disassemble. From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00476.txt.bz2 On Mon, Nov 18, 2013 at 12:21 AM, Yao Qi wrote: > [Patch 10/10 is not sent out by git send-email. Send it now.] > > This patch teaches "disassembly" use code cache mechanism to read > target code. > > gdb: > > 2013-11-18 Yao Qi > > * disasm.c (dis_asm_read_memory): Call target_read_code > instead of target_read_memory. > --- > gdb/disasm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/disasm.c b/gdb/disasm.c > index e643c2d..522e25f 100644 > --- a/gdb/disasm.c > +++ b/gdb/disasm.c > @@ -47,7 +47,7 @@ static int > dis_asm_read_memory (bfd_vma memaddr, gdb_byte *myaddr, unsigned int len, > struct disassemble_info *info) > { > - return target_read_memory (memaddr, myaddr, len); > + return target_read_code (memaddr, myaddr, len); > } > > /* Like memory_error with slightly different parameters. */ Looks good to me. I realize there's a few nits remaining, but thanks for persevering!