From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6955 invoked by alias); 21 May 2012 00:12:41 -0000 Received: (qmail 6943 invoked by uid 22791); 21 May 2012 00:12:39 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f47.google.com (HELO mail-vb0-f47.google.com) (209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 00:12:27 +0000 Received: by vbbfr13 with SMTP id fr13so3925195vbb.20 for ; Sun, 20 May 2012 17:12:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=9Pcquc62JbiUJcg8j7urX/+o3HKizlEZksherQeCCP4=; b=g7VrUdGrTTuCcX1OsnFCUrbhAvN/L8xvQ08dg/RjH0XSqUlTFuBnB9qdNHcLBJPjwH 7ot8PWHj2nNr0yv7RPGfmAHoPcw9MkPQi1AJH1rmaIkew81uqPkXz/o3RQizjkH030jp JVYVdEum/XYISsl+2N0Iqzg4KR6dOlkP3/agrbEuF9H2gw/NM8UTVdX1HrpDR+1+q/VM fcc20gQv23Wxqzia+cBlrfpnqjsbLnCrxfmsWvDqLG1/Jn4TqUR3OCpdZlBUkrHHo5US 2KUzBnG1YiH1d8wWJJalOq93aHh64wBElHCbhXT3WBpJ6JcL1QzJckjs+V5mspNIMWvw UaVg== Received: by 10.52.20.35 with SMTP id k3mr8972371vde.44.1337559146232; Sun, 20 May 2012 17:12:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.20.35 with SMTP id k3mr8972361vde.44.1337559145962; Sun, 20 May 2012 17:12:25 -0700 (PDT) Received: by 10.52.172.166 with HTTP; Sun, 20 May 2012 17:12:25 -0700 (PDT) In-Reply-To: <4FB8E4BD.6000501@toojays.net> References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFB451.8030503@toojays.net> <4FA4912E.9050709@toojays.net> <20120512183722.GA20606@host2.jankratochvil.net> <4FB10DD8.7040501@toojays.net> <20120518144642.GA19690@host2.jankratochvil.net> <4FB8E4BD.6000501@toojays.net> Date: Mon, 21 May 2012 00:12:00 -0000 Message-ID: Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. From: Doug Evans To: John Steele Scott Cc: gdb-patches@sources.redhat.com, Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlAu7kypabbhwehvhIlPAJMoG88qcf6iqVmr/g3VTn9ZARjNTDdKWwlAVutroM5jbMAzYkF+KDzv4yfxaIysl3EIy7MXHWga5ZOXzhN1geqN57MR21jL2QTfOipEXHioxDijg/R/AmFXEGuMTfquhMKo8BRjQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00756.txt.bz2 On Sun, May 20, 2012 at 5:34 AM, John Steele Scott wr= ote: > On the question of caching the producer info in the dwarf2_cu; I propose = to extract out the second half of producer_is_gxx_lt_4_6 into a new check_p= roducer function which will set cu->producer_is_gxx_lt_4_6 and cu->producer= _is_icc as appropriate (and then set cu->checked_producer). producer_is_gxx= _lt_4_6 and producer_is_icc will call check_producer if cu->checked_produce= r is not set. Sound okay? I think something along those line is needed. Thanks.