From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12233 invoked by alias); 13 Dec 2014 18:18:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12222 invoked by uid 89); 13 Dec 2014 18:18:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 13 Dec 2014 18:18:21 +0000 Received: by mail-vc0-f175.google.com with SMTP id hy10so4503773vcb.34 for ; Sat, 13 Dec 2014 10:18:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tYFIgEhbUYEp50SAx4Iy26SzQzKoC02opWHzG8vCee0=; b=VMfgEzNjsB9KPDz23IIdqtVWuAcryxpKXve1v05c5rhSzfz9c66HHRDDYvexdVKiRL Gv5bCCvGaFEErNGSKOqQVJSOHTJy3VjIYLVJOmduP2pV6o7CfaQ97ZqM1lvhllv26j/W c+8YaFmc5o8tb944YhudpzzdlMMvFXzNvdQC5/vBmzGFlBmo8XqXbsBFAdXDMikrAT+G O3gq7jWAzAKhiW0ncalPQUIvWHwKPkTGQFog6ab7ZgopX7LbgG7KFZdw1FDrrmfnWY61 uIwJ0lGfaVB3kCXcnQI2E7LkV0OWpcpbw+v1wqL5Y8SS8Cm9C7qmEaAFTm6vAOqkRycc R36g== X-Gm-Message-State: ALoCoQkPz96kmb7sJk5PhZOIV/lbJJzSzYbwgxqXn+WkmKq1cmM5rmt5BgSXovgABq2DIICaPyJi MIME-Version: 1.0 X-Received: by 10.220.201.196 with SMTP id fb4mr13413364vcb.3.1418494699217; Sat, 13 Dec 2014 10:18:19 -0800 (PST) Received: by 10.52.114.101 with HTTP; Sat, 13 Dec 2014 10:18:19 -0800 (PST) In-Reply-To: <20141213142351.GG5457@adacore.com> References: <20141125195444.GA3400@host2.jankratochvil.net> <20141213142351.GG5457@adacore.com> Date: Sat, 13 Dec 2014 18:18:00 -0000 Message-ID: Subject: Re: [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642) From: Doug Evans To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00326.txt.bz2 On Sat, Dec 13, 2014 at 6:23 AM, Joel Brobecker wrote: >> - switch (TYPE_CODE (type)) >> + if (TYPE_CODE (type) == TYPE_CODE_TYPEDEF) >> { >> - case TYPE_CODE_TYPEDEF: >> resolved_type = copy_type (type); >> TYPE_TARGET_TYPE (resolved_type) >> = resolve_dynamic_type_internal (TYPE_TARGET_TYPE (type), addr, >> top_level); >> - break; >> + } >> + else > > Trailing space here... > >> + { >> + /* Typedefs do not need to be preserved here but we need >> + to resolve any possible stub types. */ >> + type = real_type; > > It took me a moment, despite your added comment, to understand that > it was not so much about TYPE_CODE_TYPEDEF but about stubs! I keep > forgetting that check_typedef does more than unwrapping typedef > layers. Yeah. PR 17450 describes this a bit better IMO. https://sourceware.org/bugzilla/show_bug.cgi?id=17450