From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7518 invoked by alias); 14 May 2014 21:05:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7500 invoked by uid 89); 14 May 2014 21:05:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f178.google.com Received: from mail-vc0-f178.google.com (HELO mail-vc0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 14 May 2014 21:05:12 +0000 Received: by mail-vc0-f178.google.com with SMTP id hq16so3237272vcb.37 for ; Wed, 14 May 2014 14:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/kQwmwvDx3uC08iwIhViCR4JuAGWabrn+nt5EnM2Dy0=; b=DUl7LdYaXLF4+vqO/MhioicolhIUGkbDt2rx99fq9OLK6VE5aS3xKWO8Z8OBSySKOq 5ow7Z01Xua3db2y7OzHh/2pfA6n6Wk1P2lsomvEVeHS2DILUoojBCF/aOo3/isX7UG2/ ybrBa8ha0YhpJWpczsKNiJ6zZidzhULahQZR/WbUFX9DT8/Lx6VzHPnPEAMUD24VP/T3 HIldX9h3b+hMa2T825SjujzftLsKcJt4PyMll6/oZ58AJqn7xYw++GWMfA37VZcXxK6l tFNrPpwG/JdxGmA4eAKTp7Kb04+TFQXUVPmOb1B8Y95V9VEnxZHFfpOnLIVcSf2RZuEI ymGQ== X-Gm-Message-State: ALoCoQnLDr+RXFqZwC77+szqOgPlHYhTAunNYSZMTkHDT7GD3f0lXKr9aimNaknqbPvPRP1+VEjn MIME-Version: 1.0 X-Received: by 10.221.26.10 with SMTP id rk10mr4805859vcb.0.1400101509515; Wed, 14 May 2014 14:05:09 -0700 (PDT) Received: by 10.52.68.67 with HTTP; Wed, 14 May 2014 14:05:09 -0700 (PDT) In-Reply-To: <20140514110742.GA25550@blade.nx> References: <20140514110742.GA25550@blade.nx> Date: Wed, 14 May 2014 21:05:00 -0000 Message-ID: Subject: Re: [PATCH] Prompt user to report bugs From: Doug Evans To: Gary Benson Cc: gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00216.txt.bz2 On Wed, May 14, 2014 at 4:07 AM, Gary Benson wrote: > Hi all, > > This patch prints a couple of extra lines in internal_vproblem > to prompt the user to report the bug that's just happened. > > Ok to commit? > > Thanks, > Gary > > -- > 2014-05-14 Gary Benson > > * utils.c (internal_vproblem): Prompt the user to file a report. > > diff --git a/gdb/utils.c b/gdb/utils.c > index a8a7cb3..905ce6d 100644 > --- a/gdb/utils.c > +++ b/gdb/utils.c > @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem, > else > internal_error (__FILE__, __LINE__, _("bad switch")); > > + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr); > + if (REPORT_BUGS_TO[0]) > + { > + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr); > + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO); > + } > + fputs_unfiltered ("\n\n", gdb_stderr); > + > if (problem->should_dump_core == internal_problem_ask) > { > if (!can_dump_core (reason)) > top.c doesn't wrap "%s." in _(). I don't know if it matters, it's just odd to see "%s." wrapped.