From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30513 invoked by alias); 30 Jun 2013 17:37:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30503 invoked by uid 89); 30 Jun 2013 17:37:57 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-qc0-f174.google.com (HELO mail-qc0-f174.google.com) (209.85.216.174) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 30 Jun 2013 17:37:56 +0000 Received: by mail-qc0-f174.google.com with SMTP id m15so2397811qcq.19 for ; Sun, 30 Jun 2013 10:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=o1swPZ6sEPq7rMxjWFTWofruNfYRV8V4u9cXhUDaFSs=; b=nAbU4KtvnUkbPTdbhZYc5adc3k52U2xajjx6eHrmNYMNfSome+7spOKisVaqbLUGmi YVCQPu/isCtYKafugIqAX81/jY2Wjenbl2s+qRoN8FEXzPvkFaQyTDhrXrPZeiTamEuC hc9KJkL0i7zX9OJSeiajCgJMFhbbtMhwT1NiFzm7ARrIwF4JbZ+LG26NFY48HAM1TVo1 2w9o/z8GTSf7eHTNokVuaPiICLiXeb38o+oniMPeFQVdA3eBvprbpkjYCmesU83CdOgY lZAirNrOis5/qPupqN1aGPx5jV+vdJyotpSasKFC5PD0Bi8P6AE0vqtmQ6wTkaokIj0a Gw0w== MIME-Version: 1.0 X-Received: by 10.49.30.104 with SMTP id r8mr12997336qeh.27.1372613874082; Sun, 30 Jun 2013 10:37:54 -0700 (PDT) Received: by 10.229.118.199 with HTTP; Sun, 30 Jun 2013 10:37:53 -0700 (PDT) In-Reply-To: <83ip0vd4sf.fsf@gnu.org> References: <20943.41509.270378.842286@ruffy.mtv.corp.google.com> <83ip0vd4sf.fsf@gnu.org> Date: Sun, 30 Jun 2013 18:11:00 -0000 Message-ID: Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off From: Doug Evans To: Eli Zaretskii Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQk1T0uBPFHzzmBOm5O7CvzHt5qbTW1Pd426+A9nuUqhe+dZIal+tCUiW2XLXFtK0ZzfvwY2rN1TwmCNS6r4CLe+bB2fq15dv1++fxOuL9QrJqHfsIvsBC+Wapcyt8jhl18WBQFf7jo8zAax654vcx+T8kfNx1nvb4TkUm4yMDEPLPTWQeBLV14x4/eFO6O0wQR/WAbOha+0NIrTYXUhR5T4Flc6Eg== X-SW-Source: 2013-06/txt/msg00942.txt.bz2 On Sun, Jun 30, 2013 at 7:58 AM, Eli Zaretskii wrote: >> From: Doug Evans >> Date: Sat, 29 Jun 2013 20:12:37 -0700 >> >> > Sometimes it's nice to print stack frame arguments in raw form. >> > [And not just as one-offs, but as the default.] >> > >> > I thought of extending "set print frame-arguments" into something like >> > none, raw-scalars, raw-all, scalars, all. >> > But I like this better: raw-vs-pretty is orthogonal to scalars-vs-all. >> > E.g., If we later extend "print frame-arguments" it'll be easier if raw-ness >> > is a separate parameter. > > Thanks. > >> diff -u -p -r1.605 NEWS >> --- NEWS 26 Jun 2013 08:17:26 -0000 1.605 >> +++ NEWS 30 Jun 2013 03:02:56 -0000 >> @@ -34,6 +34,11 @@ maint set|show per-command symtab >> >> * New options >> >> +set print frame-arguments-raw >> +show print frame-arguments-raw >> + Set/show whether to print frame arguments in raw mode, >> + not pretty-printed. >> + > > This part is OK, although I'd suggest to say something more explicit, > like "... disregarding any defined pretty-printers." > >> --- doc/gdb.texinfo 26 Jun 2013 08:17:26 -0000 1.1099 >> +++ doc/gdb.texinfo 29 Jun 2013 22:11:03 -0000 >> @@ -9030,6 +9030,17 @@ thus speeding up the display of each Ada >> @item show print frame-arguments >> Show how the value of arguments should be displayed when printing a frame. >> >> +@item set print frame-arguments-raw on >> +Print frame arguments in raw, non pretty-printed, form. >> + >> +@item set print frame-arguments-raw off >> +Print frame arguments in pretty-printed form, if there is a pretty-printer >> +for the value (@pxref{Pretty Printing}). >> +Otherwise print the value in raw form. >> + >> +@item show print frame-arguments-raw >> +Show whether to print frame arguments in raw form. > > This is fine, but please state the default value of the option. > > OK with those changes. Thanks. Will do. Still need approval for the code part.