From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19933 invoked by alias); 10 Sep 2012 17:41:24 -0000 Received: (qmail 19918 invoked by uid 22791); 10 Sep 2012 17:41:22 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Sep 2012 17:41:08 +0000 Received: by vbkv13 with SMTP id v13so2798552vbk.0 for ; Mon, 10 Sep 2012 10:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=v6CTm3yOPHlwJhTUm9ugFw7FYhe08cQLYfjfaFuf0VI=; b=l6LIMGSFIKPwPNNRbpe5wq7CnaXWBy2Iykw5WC3rH0lMC8oC78XpPDaBuJISjer/Bz pv8MtX6rGW3uSGpYBbsW/1a8OKZwWNcj/GJ6u4V7Sq9Tkn0IBvObXlfeTo8igT4vvqXl 0Ap6yEZv2z8pSj1cYsCO6vvyplIJMLmywrFjV09HWFYXnvTmoXj1P00EdMMZLV+9fYis z70QAAumHZ4RFb8v42bbecE88U0pyKzY7HDWdjwfOGuhbxk/bkgZ2puqJAdXoUDkNCCY n/yX+nB/GJ86hnEjPeTTZz8SCTk3zcK8gPTg0bRHgbmBElfqIJTVVHgHsnpsFGf+GLj0 p2qw== Received: by 10.58.114.194 with SMTP id ji2mr1996505veb.22.1347298867817; Mon, 10 Sep 2012 10:41:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.114.194 with SMTP id ji2mr1996492veb.22.1347298867676; Mon, 10 Sep 2012 10:41:07 -0700 (PDT) Received: by 10.52.24.239 with HTTP; Mon, 10 Sep 2012 10:41:07 -0700 (PDT) In-Reply-To: <871ui9eqhp.fsf@fleche.redhat.com> References: <503DF8D2.8070807@arm.com> <871ui9eqhp.fsf@fleche.redhat.com> Date: Mon, 10 Sep 2012 17:41:00 -0000 Message-ID: Subject: Re: [commit] Update help.exp From: Doug Evans To: Tom Tromey Cc: Yufeng Zhang , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQmzNRyElnfHkzduMktYTfcgjqp299rky/qdhaAoL8bLWsx/ybBwS+OFXoMx1vAlFREuHEMqQ/ZQ5RTlSb3JDg33j62qrdHY4E0wosFmcynMid9/Y4v1RygOqO8nRXbMQ3ZMCHjefO4jP6sqemdRXKwu17eMrSuMKIMaEQ+GJPyHdeNeFQ9D/RKbZcjbZTS4UgR4yRsG0X7bHbb5kXsFOnLwqNcGTw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00128.txt.bz2 On Mon, Sep 10, 2012 at 10:29 AM, Tom Tromey wrote: >>>>>> ">" =3D=3D Yufeng Zhang writes: > >>> help.exp still fails with --without-python. "Convenience functions >>> are defined via the Python API" is printed only when HAVE_PYTHON is >>> defined (see >>> http://sourceware.org/ml/gdb-patches/2012-08/msg00342.html). > > I ran into this too. > > Here's my proposed fix. > Tested on x86-64 F16, both with and without Python enabled. > > Tom > > b/gdb/testsuite/ChangeLog: > 2012-09-10 Tom Tromey > > * gdb.base/help.exp: Conditionally allow Python output. > > diff --git a/gdb/testsuite/gdb.base/help.exp b/gdb/testsuite/gdb.base/hel= p.exp > index 7fffd00..3270565 100644 > --- a/gdb/testsuite/gdb.base/help.exp > +++ b/gdb/testsuite/gdb.base/help.exp > @@ -517,7 +517,7 @@ gdb_test "help show complaints" "Show max number of c= omplaints about incorrect s > # test help show confirm > gdb_test "help show confirm" "Show whether to confirm potentially danger= ous operations\." "help show confirm" > # test help show convenience > -gdb_test "help show convenience" "Debugger convenience \\(\"\\\$foo\"\\)= variables and functions\.\[\r\n\]+Convenience variables are created when y= ou assign them values;\[\r\n\]+thus, \"set \\\$foo=3D1\" gives \"\\\$foo\" = the value 1\. Values may be any type\.\[\r\n\]+A few convenience variables= are given values automatically:\[\r\n\]+\"\\\$_\"holds the last address ex= amined with \"x\" or \"info lines\",\[\r\n\]+\"\\\$__\" holds the contents = of the last address examined with \"x\"\.\[\r\n\]+Convenience functions are= defined via the Python API\." "help show convenience" > +gdb_test "help show convenience" "Debugger convenience \\(\"\\\$foo\"\\)= variables and functions\.\[\r\n\]+Convenience variables are created when y= ou assign them values;\[\r\n\]+thus, \"set \\\$foo=3D1\" gives \"\\\$foo\" = the value 1\. Values may be any type\.\[\r\n\]+A few convenience variables= are given values automatically:\[\r\n\]+\"\\\$_\"holds the last address ex= amined with \"x\" or \"info lines\",\[\r\n\]+\"\\\$__\" holds the contents = of the last address examined with \"x\"\.\[\r\n\]+(Convenience functions ar= e defined via the Python API\.)?" "help show convenience" > # test help show directories > gdb_test "help show directories" "Show the search path for finding sourc= e files\.\[\r\n\]+\\\$cwd in the path means the current working directory\.= \[\r\n\]+\\\$cdir in the path means the compilation directory of the source= file\..*" "help show directories" > # test help show editing Sorry, I was going to get to this last week. :-( Can I suggest instead that we gut help.exp, and leave only a small set of tests for basic functionality, instead of testing the multitude of commands it currently tests? [If someone want to argue to keep it as is, you also IMO need to argue that every missing command and every new command also needs an entry in help.exp (or equivalent elsewhere). The maintenance burden is IMO just too great. Ergo my suggestion of just having minimal tests for the basic functionality, but not testing so many commands.]