From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118764 invoked by alias); 22 Sep 2015 19:54:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118702 invoked by uid 89); 22 Sep 2015 19:54:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f175.google.com Received: from mail-ig0-f175.google.com (HELO mail-ig0-f175.google.com) (209.85.213.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Sep 2015 19:54:14 +0000 Received: by igcpb10 with SMTP id pb10so106605661igc.1 for ; Tue, 22 Sep 2015 12:54:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=KGCMr9qf8/cU5x3tIH2t00zcoAzmSRA8DqlzdXwb/V4=; b=EkQzYaQs/ARlo651gvuJaMqtl8HTlAp9re6uKCm8gJEYpZImZG15wJml136KOC3J+B cKBUERj9x7TjEHJa2RegE0cQmcczsRJ5Ldvs4Gik4IsOc1vp4gntX+pyfeoLHYrlQ7Be r/Kb/lx0fws2Z7CMSQYTwb3L7I+sNB/FNucfG7vlLIptam/axi7+QaKHY0XcbMtLjzs7 AGzv5dDJKomHryVDlV5ndexM5pjN1+rjJKdOgj+8pIWNSApYjIZRPhrMM18hQM2RFdVJ v9IyArxOuq9+RxBguGyD/tw86m2YY9ScatZrcndf+p+yoh4a7B2xlKL12NjoS1LafFsz GbwQ== X-Gm-Message-State: ALoCoQnX4CeYk1jbS7wfkudowvOGTJ2RE7aODP85AkolnxNqo9iCvarBmosiLQJBMfuk3nvz5H4c X-Received: by 10.50.79.196 with SMTP id l4mr18327637igx.48.1442951651642; Tue, 22 Sep 2015 12:54:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.19.130 with HTTP; Tue, 22 Sep 2015 12:53:31 -0700 (PDT) In-Reply-To: References: <86wpvi9zst.fsf@gmail.com> From: Doug Evans Date: Tue, 22 Sep 2015 19:54:00 -0000 Message-ID: Subject: Re: [PATCH, FT32] Proper support for address <-> pointer conversions To: James Bowman Cc: Yao Qi , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00539.txt.bz2 On Tue, Sep 22, 2015 at 11:37 AM, James Bowman wrote: > Thanks for the review. Corrected Changelog/patch is below. > > However I was not sure about splitting -- these changes all > seem to go together. That is, applying just some of the patch > results in a non-functioning gdb. > > 2015-09-22 James Bowman > > * ft32-tdep.c: Implement the pointer to address method so > that FT32's address spaces (RAM and flash) work correctly when > dereferencing pointers in gdb. Also make PC a flash pointer. > * ft32-tdep.h: Add a type for an address space 1 pointer, for > the PC. Yeah, there'll always be some grey area as to when one should split up a patch. This patch is small enough and is completely target specific. The ChangeLog is still incorrect though. E.g. compare with just about every existing changelog entry. gdb's pretty good at following its own conventions, and that in turn makes it easy to continue to follow them. Just go with the flow and mimic (without being creative) what's already there. There's also: https://sourceware.org/gdb/wiki/ContributionChecklist