Re: [PATCH] Speed up "gdb -tui" output

Eli Zaretskii
2015-01-19T17:55:48Z

> From: Doug Evans <dje@google.com>
> Date: Wed, 7 Jan 2015 13:59:06 -0800
>
> Doug Evans writes:
> > Seems like the main source of the problem would be gdb_stdout,
> > so let's try to fix that first and go from there.
>
> Here's a prototype.

Sorry for a long delay. I tried this (and Pedro's) patch today. They
both do the job, so one of them should IMO be committed, master and
branch.

> @@ -239,6 +243,12 @@ tui_file_flush (struct ui_file *file)
> case astring:
> break;
> case afile:
> + /* There is also gdb_stdlog, gdb_stdtarg, gdb_stdtargerr, but
> + tui_setup_io maps those to gdb_stderr. OTOH, do we need to make
> + this conditional? */
> + if (file == gdb_stdout
> + || file == gdb_stderr)
> + tui_refresh_cmd_win ();

I indeed think that the condition should be removed. I see no need
for it: there's no reason to make any stream displayed on TUI more
than line-buffered.

Thanks.