From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97492 invoked by alias); 29 Jun 2015 21:43:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97477 invoked by uid 89); 29 Jun 2015 21:43:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f173.google.com Received: from mail-ob0-f173.google.com (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Jun 2015 21:43:30 +0000 Received: by obpn3 with SMTP id n3so113691505obp.0 for ; Mon, 29 Jun 2015 14:43:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=k858yJGTzlUgBO4sHAt8tKJQjQquBVy6DwiJPeZdWDA=; b=dAh0Be2qolsIVWiH5IN+fm+qBMg+UCmSgfe9g4i2DhFiULEf2kgE7Mw/+JX8CHOD31 v5ZkmNophKpLafWdmBf1COPydVMcNLu/J6PVWQ0FqgbzCJoXxdZvEBLxjGPZPmR6vcVY 69n74qAVS2Y/QzLtBBhswoAkTD7XHQgEXMAU5O7kJ55s9LPHu5WF6gx39ZQbTlNd7YWg sGCbgv5dbW37/Hkuu6kIPM0fp2tJUO3YuMe3vwoCLAoxAJybnTz8ZtzPOrgcGMjjN3Zz 6YFxgitJAxiUPaXdheHdBFlp70mrsFbQKnjcbjZTwazBq4LTxg/gEaDZxXpDc4PDrBwM wQrw== X-Gm-Message-State: ALoCoQlaL1eWHgwsTomwh4gMLN91C0c4nDUkthJPDe0ospIRWEnyqMqWkTu3zZ57+bS6EU+dfofA X-Received: by 10.202.177.68 with SMTP id a65mr15611396oif.64.1435614208761; Mon, 29 Jun 2015 14:43:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.89.99 with HTTP; Mon, 29 Jun 2015 14:42:48 -0700 (PDT) In-Reply-To: References: <1435464030-22372-1-git-send-email-martin.galvan@tallertechnologies.com> From: Doug Evans Date: Mon, 29 Jun 2015 21:43:00 -0000 Message-ID: Subject: Re: [PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help To: Martin Galvan Cc: Andreas Schwab , gdb-patches , Yao Qi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00614.txt.bz2 It is ok to commit as is. On Mon, Jun 29, 2015 at 4:16 PM, Martin Galvan wrote: > Is it ok to commit as it is, or should I change the comment to reflect > what Andreas said? > > On Mon, Jun 29, 2015 at 11:03 AM, Doug Evans wrote: >> On Sun, Jun 28, 2015 at 4:07 AM, Andreas Schwab = wrote: >>> Martin Galvan writes: >>> >>>> +# Notice that the '[' and ']' characters don't need to be escaped for= strings >>>> +# wrapped in {} braces. >>> >>> This isn't true in general, it's because this is a tcl list. The >>> backslashes are removed when the list is passed through join in >>> help_test_raw (which removes one level of quoting, but doesn't do >>> command or variable expansion). But that also means that the backslash >>> before '.' is ineffective and should be replaced by a double backslash. >>> Alternatively, each element could be enclosed with braces which disables >>> any quoting inside it. >>> >>>> proc test_class_help { command_class expected_initial_lines args } { >>>> set l_stock_body { >>>> - "List of commands\:.*\[\r\n\]+" >>>> - "Type \"help\" followed by command name for full documentatio= n\.\[\r\n\]+" >>>> - "Type \"apropos word\" to search for commands related to \"wo= rd\"\.[\r\n\]+" >>>> + "List of commands\:.*[\r\n]+" >>> >>> The backslash before ':' is useless. >> >> Thanks for the clarity. >> We don't have to fix all issues in this patch, so the patch is fine with= me. > > > > -- > > > Martin Galvan > > Software Engineer > > Taller Technologies Argentina > > > San Lorenzo 47, 3rd Floor, Office 5 > > C=C3=B3rdoba, Argentina > > Phone: 54 351 4217888 / +54 351 4218211