From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14123 invoked by alias); 5 Apr 2012 15:55:03 -0000 Received: (qmail 14074 invoked by uid 22791); 5 Apr 2012 15:55:01 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 15:54:43 +0000 Received: by obbta14 with SMTP id ta14so2408971obb.0 for ; Thu, 05 Apr 2012 08:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=Z0me9d3XDub9wpEmo4GWorMGW56YLR/oAuusGiQ7tiA=; b=mLIn+abZ/jU+lYZSSAjC0UEXqP+IU9E8FUYvwHHdKKK2M2wZ4ufUy/XgfhWLFfVI5x M0xphJUd/zxibxfKTZ/Mxz2N8prFG5Iv2f67erqLtV9HlvcDDQS2YHXHvLHHDWQmr0jk Y3WecJBVbo/uYYRIk/SnMefW6YvyjvuMdacye8L2tVEvgtM7aA31woFiUqcVqr74pnS9 gnwY6E5ZPtp7eVGRFATWo5cC0By1N8HGfIZfaXTBd0ZD1XnZQ3VDENQd6az7VZ18sJv4 s51X+TZ/Qb9EdIHg/P2gZIV0Fw+vHQ/rTuS0h7txR5Rxoyc8/saIzzU5qiQmLvBi7lvj nbxg== Received: by 10.182.11.100 with SMTP id p4mr4637746obb.63.1333641282578; Thu, 05 Apr 2012 08:54:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.11.100 with SMTP id p4mr4636955obb.63.1333641273153; Thu, 05 Apr 2012 08:54:33 -0700 (PDT) Received: by 10.182.66.14 with HTTP; Thu, 5 Apr 2012 08:54:33 -0700 (PDT) In-Reply-To: <87hawygq65.fsf@fleche.redhat.com> References: <4F70F8F7.503@redhat.com> <87zkb0wj1x.fsf@fleche.redhat.com> <4F74B583.6090008@redhat.com> <87obrertls.fsf@fleche.redhat.com> <4F75D859.1010907@redhat.com> <87r4waqc38.fsf@fleche.redhat.com> <20120330170913.GT2701@adacore.com> <87fwcqq8gl.fsf@fleche.redhat.com> <4F75F5F5.8070105@redhat.com> <4F7B8610.9070302@redhat.com> <87hawygq65.fsf@fleche.redhat.com> Date: Thu, 05 Apr 2012 15:55:00 -0000 Message-ID: Subject: Re: [RFA 1/2] Linespec rewrite (update 2) From: Doug Evans To: Tom Tromey Cc: Keith Seitz , "gdb-patches@sourceware.org ml" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlOuMJ7ymecE0M6s2uHkroELRUPeWCV4iSa28lgkPxy3Wv82WpKLbCaA70NqHMShqVJVbXZ0dpc1wm+T6pQe0z1EjPTUWfj4Ne9RSGIn6DjtHVjxm9Ckc8rpBm1lMIvTRsH4MoRJWIKQod5rdRzZYGxmyiCzw== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00066.txt.bz2 On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey wrote: >>>>>> "Keith" =3D=3D Keith Seitz writes: > > Keith> Given Doug's comments earlier today, I'm reposting anything that > Keith> hasn't already been approved or which changed. The easiest way to = see > Keith> what's happened is, of course, by inspecting the commit history of= the > Keith> branch. > > Keith> I'll follow-up separately with the other patch that was updated. > > I have no further comments. =A0I think it looks great. > > I think at this point you just need Doug's ok. All I had were nits, so 'tis ok with me.