From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6328 invoked by alias); 11 Nov 2013 18:59:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6319 invoked by uid 89); 11 Nov 2013 18:59:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-ve0-f172.google.com Received: from Unknown (HELO mail-ve0-f172.google.com) (209.85.128.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 11 Nov 2013 18:59:02 +0000 Received: by mail-ve0-f172.google.com with SMTP id oz11so2422966veb.17 for ; Mon, 11 Nov 2013 10:58:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9bBu3DreYUO8pfDkmiAtmnev950TW/0fUQzHQSmA4UY=; b=Q3acbMrPt2nRHw/X4FRpmBPT7FqZfysPh0UyTcWsR/6dBgWqhKTxaz9n7xQzO6nrVN md2Mv9FaHiN/5sT5YYcU4ZSlpkYvYZBoauwWy7QJJzEwHsStxZXMsvvoOy8HUmQqZus5 Oi8GeNOWw+KGg8cn+qbVU61mZHcqKM3dL+W3a/c1ZiG7UdGucoy6IXy6AyHaNJRLDgCh x+3RT+utXiGGt0XWtONUTv0SH+vUdP/gXy7Tp84OB9rBTAVP1X34yBN4lh6mJjC1vukG lk58zOf11r+o6uYYYIAkemu5O23EleW8JCFWOgDxFIvEGdfqwx2d0xIEpTv74E6hcwJV 0gRQ== X-Gm-Message-State: ALoCoQl+FBCu0og2Nh3XfeTmGMq+IXYXzCVU7FSmBuqPXQz54ayEBthcvGE5+2uzGPOeNg+NonUGK7P4B2uqlZnEvA6Vo+3RRU+USe+DqXgGigy8QbakRK+Zd/PMUUgSQMzCIrce9d1Ou8tuMzHAthf13TbH4SDMjBK81odCurjwaXQZC38pNdT1zo+VKzjJLMlMtA7mM3F7O8l0tqXmidW4THKnFcXvHw== MIME-Version: 1.0 X-Received: by 10.220.16.73 with SMTP id n9mr2884263vca.24.1384196333915; Mon, 11 Nov 2013 10:58:53 -0800 (PST) Received: by 10.52.237.232 with HTTP; Mon, 11 Nov 2013 10:58:53 -0800 (PST) In-Reply-To: References: <1383519137-26388-1-git-send-email-naesten@gmail.com> Date: Mon, 11 Nov 2013 19:46:00 -0000 Message-ID: Subject: Re: [PATCH v3] Resurrect gdb-add-index as a contrib script From: Doug Evans To: Samuel Bronson Cc: gdb-patches , Tom Tromey , Jan Kratochvil Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00298.txt.bz2 On Sun, Nov 3, 2013 at 1:57 PM, Samuel Bronson wrote: > This includes some changes made in Fedora's gdb packaging[1], and > Doug's robustness patch[2] from before it was dropped (with some > slight corrections). > > [1]: http://pkgs.fedoraproject.org/cgit/gdb.git/log/gdb-gdb-add-index-script.patch?id=fe74423b0812bae6d7bb027584e401a2ac37d24d > [2]: https://sourceware.org/ml/gdb-patches/2010-09/msg00130.html > > I'm including a log of relevant previous activity. > > (I would just include committishes, but I'm not quite confident that > history won't be rewritten again, invalidating the hashes, plus there > are no relevant tags so the first two parts of git-describe(1) output > wouldn't be any help either.) > > [...] > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 79abe3d..def36a3 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,11 @@ > +2013-11-08 Tom Tromey > + Jan Kratochvil > + Doug Evans > + Samuel Bronson > + > + Bring back gdb-add-index as a contrib script. > + * contrib/gdb-add-index.sh: New file. > + > 2013-11-08 Doug Evans I think this deserves a NEWS entry. > * dwarf2read.c (dwarf2_read_debug): Change to unsigned int. > diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh > new file mode 100755 > index 0000000..437e8c4 > --- /dev/null > +++ b/gdb/contrib/gdb-add-index.sh > @@ -0,0 +1,61 @@ > +#! /bin/sh > + > +# Add a .gdb_index section to a file. > + > +# Copyright (C) 2010, 2012-2013 Free Software Foundation, Inc. > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This program assumes gdb and objcopy are in $PATH. In my local copy I added the ability to specify which gdb to use, useful when using a test gdb. I never needed to specify objcopy, but for consistency's sake ... GDB=${GDB:=gdb} OBJCOPY=${OBJCOPY:=objcopy} or some such? > + > +myname="${0##*/}" > + > +if test $# != 1; then > + echo "usage: $myname FILE" 1>&2 > + exit 1 > +fi > + > +file="$1" > + > +if test ! -r "$file"; then > + echo "$myname: unable to access: $file" 1>&2 > + exit 1 > +fi > + > +dir="${file%/*}" > +test "$dir" = "$file" && dir="." > +index="${file}.gdb-index" > + > +# Ensure intermediate index file is removed when we exit. > +trap "rm -f $index" 0 > + > +gdb --batch-silent -nx -iex 'set auto-load no' \ > + -ex "file $file" -ex "save gdb-index $dir" || { > + # Just in case. > + status=$? > + echo "$myname: gdb error generating index" 1>&2 > + exit $status > +} > + > +# In some situations gdb can exit without creating an index. This is > +# not an error. > +# E.g., if $file is stripped. This behaviour is akin to stripping an > +# already stripped binary, it's a no-op. status=0 > + > +if test -f "$index"; then > + objcopy --add-section .gdb_index="$index" \ > + --set-section-flags .gdb_index=readonly "$file" "$file" > + status=$? Another thing I added is a message here that no index was generated, rather than a "silent failure". [Not always a "failure", but helpful to know regardless.] else echo "No index generated. This is not necessarily a bug." echo "[E.g., Was $file built in debug mode?]" I don't have a strong opinion on adding this, but I have found it useful. > +fi > + > +exit $status