From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108119 invoked by alias); 29 Jun 2015 14:04:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108109 invoked by uid 89); 29 Jun 2015 14:04:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f50.google.com Received: from mail-oi0-f50.google.com (HELO mail-oi0-f50.google.com) (209.85.218.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Jun 2015 14:04:23 +0000 Received: by oiax193 with SMTP id x193so118543445oia.2 for ; Mon, 29 Jun 2015 07:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=UAsscNrB6DzYqNcJrsbsOISoPWQ30ADvpz67auOp1cs=; b=S1SZMQCkKKGvJDBVgLgQkHAHBIVXtkM27VbUDFWLplh65kYB0LvHOq4mszXO2bfjWF f+qlFW/QRXiWK2s72mCdULQsFWJ0lI8qaUY19+odb0Ku030IVeVycY08rB/Z0T5LzNt6 X3ps7UDGfXZcsTWVf+T8goLdmvX0VGuEdCZWrirEozpDOhDMG2V+yysa7ghfw60xDHWS GmpGRyiDorD+lIkxt5W1PpsVndi+uDgUzEsZ9ThEPQxU3hLiRdXQ2Qs1yXC8mkIqYTiS O/l1DPHCv755AgSLC+XPSNujdYzHeHM/SP6NVHVWxieau6vigdgsvPi45cUEG1G5w2fc rt1g== X-Gm-Message-State: ALoCoQl7XYEzyWEKOi0CgbhfPxtPsHiLl4cYASzJFGps4sO+3p/+9ML3dpnI/LejNH0zahZxojiM X-Received: by 10.202.198.138 with SMTP id w132mr13569915oif.72.1435586661309; Mon, 29 Jun 2015 07:04:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.89.99 with HTTP; Mon, 29 Jun 2015 07:03:41 -0700 (PDT) In-Reply-To: References: <1435464030-22372-1-git-send-email-martin.galvan@tallertechnologies.com> From: Doug Evans Date: Mon, 29 Jun 2015 14:04:00 -0000 Message-ID: Subject: Re: [PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help To: Andreas Schwab Cc: Martin Galvan , gdb-patches , Yao Qi Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00604.txt.bz2 On Sun, Jun 28, 2015 at 4:07 AM, Andreas Schwab wrote: > Martin Galvan writes: > >> +# Notice that the '[' and ']' characters don't need to be escaped for strings >> +# wrapped in {} braces. > > This isn't true in general, it's because this is a tcl list. The > backslashes are removed when the list is passed through join in > help_test_raw (which removes one level of quoting, but doesn't do > command or variable expansion). But that also means that the backslash > before '.' is ineffective and should be replaced by a double backslash. > Alternatively, each element could be enclosed with braces which disables > any quoting inside it. > >> proc test_class_help { command_class expected_initial_lines args } { >> set l_stock_body { >> - "List of commands\:.*\[\r\n\]+" >> - "Type \"help\" followed by command name for full documentation\.\[\r\n\]+" >> - "Type \"apropos word\" to search for commands related to \"word\"\.[\r\n\]+" >> + "List of commands\:.*[\r\n]+" > > The backslash before ':' is useless. Thanks for the clarity. We don't have to fix all issues in this patch, so the patch is fine with me.