From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11699 invoked by alias); 15 Nov 2011 17:00:32 -0000 Received: (qmail 11681 invoked by uid 22791); 15 Nov 2011 17:00:28 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,TW_XD X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 16:59:47 +0000 Received: by ggnq1 with SMTP id q1so4794772ggn.0 for ; Tue, 15 Nov 2011 08:59:47 -0800 (PST) Received: by 10.224.17.148 with SMTP id s20mr18356900qaa.55.1321376386585; Tue, 15 Nov 2011 08:59:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.17.148 with SMTP id s20mr18356889qaa.55.1321376386464; Tue, 15 Nov 2011 08:59:46 -0800 (PST) Received: by 10.224.6.76 with HTTP; Tue, 15 Nov 2011 08:59:46 -0800 (PST) In-Reply-To: <83sjlufofh.fsf@gnu.org> References: <20111108093759.279E3246194@ruffy.mtv.corp.google.com> <83sjlufofh.fsf@gnu.org> Date: Tue, 15 Nov 2011 17:00:00 -0000 Message-ID: Subject: Re: [doc RFA] "New" command "!" From: Doug Evans To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec51b15e9213b7f04b1c8ea91 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00389.txt.bz2 --bcaec51b15e9213b7f04b1c8ea91 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1522 On Fri, Nov 11, 2011 at 11:29 AM, Eli Zaretskii wrote: >> Date: Fri, 11 Nov 2011 09:18:55 -0800 >> From: Doug Evans >> >> --- NEWS =A0 =A0 =A02 Nov 2011 23:44:19 -0000 =A0 =A0 =A0 1.464 >> +++ NEWS =A0 =A0 =A011 Nov 2011 15:46:51 -0000 >> @@ -104,6 +104,12 @@ >> =A0 =A0at the time the function got called. =A0Entry values are availabl= e only since >> =A0 =A0gcc version 4.7. >> >> +* New commands >> + >> +!SHELL COMMAND >> + =A0"!" is now an alias of the "shell" command. >> + =A0Note that no space is needed between "!" and SHELL COMMAND. > > This is okay. > >> =A0@item shell @var{command string} >> +@itemx ! @var{command string} > > There should be no space between `!' and the rest, right? > > Also, I'd suggest to tell here explicitly what you told in NEWS: > > =A0Note that no space is needed between @code{!} and @var{command string}. > > Btw, it is customary not to have spaces in @var. =A0Use hyphens or > underscores instead. =A0(Yes, I know it was that way before you added > the alias.) > > Thanks. > Here is what I committed. 2011-11-14 Doug Evans Make "!" an alias for "shell". * NEWS: Add mention. * cli/cli-cmds.c (init_cli_cmds): Remove xdb_commands condition on adding "!" command, always add it. * cli/cli-decode.c (find_command_name_length): Recognize "!" as a command of length one. doc/ * gdb.texinfo (Shell Commands): Document "!". testsuite/ * gdb.base/shell.exp: New file. --bcaec51b15e9213b7f04b1c8ea91 Content-Type: text/plain; charset=US-ASCII; name="gdb-111114-bang-3.patch.txt" Content-Disposition: attachment; filename="gdb-111114-bang-3.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gv15dc3n0 Content-length: 6865 MjAxMS0xMS0xNCAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCU1h a2UgIiEiIGFuIGFsaWFzIGZvciAic2hlbGwiLgoJKiBORVdTOiBBZGQgbWVu dGlvbi4KCSogY2xpL2NsaS1jbWRzLmMgKGluaXRfY2xpX2NtZHMpOiBSZW1v dmUgeGRiX2NvbW1hbmRzIGNvbmRpdGlvbiBvbgoJYWRkaW5nICIhIiBjb21t YW5kLCBhbHdheXMgYWRkIGl0LgoJKiBjbGkvY2xpLWRlY29kZS5jIChmaW5k X2NvbW1hbmRfbmFtZV9sZW5ndGgpOiBSZWNvZ25pemUgIiEiIGFzIGEKCWNv bW1hbmQgb2YgbGVuZ3RoIG9uZS4KCglkb2MvCgkqIGdkYi50ZXhpbmZvIChT aGVsbCBDb21tYW5kcyk6IERvY3VtZW50ICIhIi4KCgl0ZXN0c3VpdGUvCgkq IGdkYi5iYXNlL3NoZWxsLmV4cDogTmV3IGZpbGUuCgpJbmRleDogTkVXUwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMv Z2RiL05FV1MsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDY2CmRpZmYgLXUg LXAgLXIxLjQ2NiBORVdTCi0tLSBORVdTCTE0IE5vdiAyMDExIDIwOjA3OjIw IC0wMDAwCTEuNDY2CisrKyBORVdTCTE1IE5vdiAyMDExIDA0OjU4OjMzIC0w MDAwCkBAIC0xMDMsNiArMTAzLDEyIEBACiAgIGF0IHRoZSB0aW1lIHRoZSBm dW5jdGlvbiBnb3QgY2FsbGVkLiAgRW50cnkgdmFsdWVzIGFyZSBhdmFpbGFi bGUgb25seSBzaW5jZQogICBnY2MgdmVyc2lvbiA0LjcuCiAKKyogTmV3IGNv bW1hbmRzCisKKyFTSEVMTCBDT01NQU5ECisgICIhIiBpcyBub3cgYW4gYWxp YXMgb2YgdGhlICJzaGVsbCIgY29tbWFuZC4KKyAgTm90ZSB0aGF0IG5vIHNw YWNlIGlzIG5lZWRlZCBiZXR3ZWVuICIhIiBhbmQgU0hFTEwgQ09NTUFORC4K KwogKiBDaGFuZ2VkIGNvbW1hbmRzCiAKIHdhdGNoIEVYUFJFU1NJT04gbWFz ayBNQVNLX1ZBTFVFCkluZGV4OiBjbGkvY2xpLWNtZHMuYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2NsaS9j bGktY21kcy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExOApkaWZmIC11 IC1wIC1yMS4xMTggY2xpLWNtZHMuYwotLS0gY2xpL2NsaS1jbWRzLmMJMSBO b3YgMjAxMSAxNDo1MToyMiAtMDAwMAkxLjExOAorKysgY2xpL2NsaS1jbWRz LmMJMTUgTm92IDIwMTEgMDQ6NTg6MzMgLTAwMDAKQEAgLTE4MjUsMTQgKzE4 MjUsNyBAQCBUd28gYXJndW1lbnRzIChzZXBhcmF0ZWQgYnkgYSBjb21tYSkg YXJlCiAgIGlmICh4ZGJfY29tbWFuZHMpCiAgICAgYWRkX2NvbV9hbGlhcyAo InZhIiwgImRpc2Fzc2VtYmxlIiwgY2xhc3NfeGRiLCAwKTsKIAotICAvKiBO T1RFOiBjYWduZXkvMjAwMC0wMy0yMDogQmVpbmcgYWJsZSB0byBlbnRlciBg YChnZGIpICFscycnIHdvdWxkCi0gICAgIGJlIGEgcmVhbGx5IHVzZWZ1bCBm ZWF0dXJlLiAgVW5mb3J0dW5hdGVseSwgdGhlIGJlbG93IHdvbnQgZG8KLSAg ICAgdGhpcy4gIEluc3RlYWQgaXQgYWRkcyBzdXBwb3J0IGZvciB0aGUgZm9y bSBgYChnZGIpICEgbHMnJwotICAgICAoaS5lLiB0aGUgc3BhY2UgaXMgcmVx dWlyZWQpLiAgSWYgdGhlIGBgIScnIGNvbW1hbmQgYmVsb3cgaXMKLSAgICAg YWRkZWQgdGhlIGNvbXBsYWlucyBhYm91dCBubyBgYCEnJyBjb21tYW5kIHdv dWxkIGJlIHJlcGxhY2VkIGJ5Ci0gICAgIGNvbXBsYWlucyBhYm91dCBob3cg dGhlIGBgIScnIGNvbW1hbmQgaXMgYnJva2VuIDotKSAgKi8KLSAgaWYgKHhk Yl9jb21tYW5kcykKLSAgICBhZGRfY29tX2FsaWFzICgiISIsICJzaGVsbCIs IGNsYXNzX3N1cHBvcnQsIDApOworICBhZGRfY29tX2FsaWFzICgiISIsICJz aGVsbCIsIGNsYXNzX3N1cHBvcnQsIDApOwogCiAgIGMgPSBhZGRfY29tICgi bWFrZSIsIGNsYXNzX3N1cHBvcnQsIG1ha2VfY29tbWFuZCwgXygiXAogUnVu IHRoZSBgYG1ha2UnJyBwcm9ncmFtIHVzaW5nIHRoZSByZXN0IG9mIHRoZSBs aW5lIGFzIGFyZ3VtZW50cy4iKSk7CkluZGV4OiBjbGkvY2xpLWRlY29kZS5j Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3Ny Yy9nZGIvY2xpL2NsaS1kZWNvZGUuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS45OApkaWZmIC11IC1wIC1yMS45OCBjbGktZGVjb2RlLmMKLS0tIGNsaS9j bGktZGVjb2RlLmMJOSBPY3QgMjAxMSAyMjoyMTo0MiAtMDAwMAkxLjk4Cisr KyBjbGkvY2xpLWRlY29kZS5jCTE1IE5vdiAyMDExIDA0OjU4OjMzIC0wMDAw CkBAIC0xMTI3LDExICsxMTI3LDE2IEBAIGZpbmRfY29tbWFuZF9uYW1lX2xl bmd0aCAoY29uc3QgY2hhciAqdGUKICAgICAgTm90ZSB0aGF0IHRoaXMgaXMg bGFyZ2VyIHRoYW4gdGhlIGNoYXJhY3RlciBzZXQgYWxsb3dlZCB3aGVuCiAg ICAgIGNyZWF0aW5nIHVzZXItZGVmaW5lZCBjb21tYW5kcy4gICovCiAKKyAg LyogUmVjb2duaXplICchJyBhcyBhIHNpbmdsZSBjaGFyYWN0ZXIgY29tbWFu ZCBzbyB0aGF0LCBlLmcuLCAiIWxzIgorICAgICB3b3JrcyBhcyBleHBlY3Rl ZC4gICovCisgIGlmICgqcCA9PSAnIScpCisgICAgcmV0dXJuIDE7CisKICAg d2hpbGUgKGlzYWxudW0gKCpwKSB8fCAqcCA9PSAnLScgfHwgKnAgPT0gJ18n CiAJIC8qIENoYXJhY3RlcnMgdXNlZCBieSBUVUkgc3BlY2lmaWMgY29tbWFu ZHMuICAqLwogCSB8fCAqcCA9PSAnKycgfHwgKnAgPT0gJzwnIHx8ICpwID09 ICc+JyB8fCAqcCA9PSAnJCcKIAkgLyogQ2hhcmFjdGVycyB1c2VkIGZvciBY REIgY29tcGF0aWJpbGl0eS4gICovCi0JIHx8ICh4ZGJfY29tbWFuZHMgJiYg KCpwID09ICchJyB8fCAqcCA9PSAnLycgfHwgKnAgPT0gJz8nKSkpCisJIHx8 ICh4ZGJfY29tbWFuZHMgJiYgKCpwID09ICcvJyB8fCAqcCA9PSAnPycpKSkK ICAgICBwKys7CiAKICAgcmV0dXJuIHAgLSB0ZXh0OwpJbmRleDogZG9jL2dk Yi50ZXhpbmZvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvc3JjL3NyYy9nZGIvZG9jL2dkYi50ZXhpbmZvLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjg5NQpkaWZmIC11IC1wIC1yMS44OTUgZ2RiLnRleGluZm8K LS0tIGRvYy9nZGIudGV4aW5mbwkxNCBOb3YgMjAxMSAyMDowNzoyMyAtMDAw MAkxLjg5NQorKysgZG9jL2dkYi50ZXhpbmZvCTE1IE5vdiAyMDExIDA0OjU4 OjMzIC0wMDAwCkBAIC0xMzQ3LDkgKzEzNDcsMTIgQEAganVzdCB1c2UgdGhl IEBjb2Rle3NoZWxsfSBjb21tYW5kLgogCiBAdGFibGUgQGNvZGUKIEBraW5k ZXggc2hlbGwKK0BraW5kZXggIQogQGNpbmRleCBzaGVsbCBlc2NhcGUKLUBp dGVtIHNoZWxsIEB2YXJ7Y29tbWFuZCBzdHJpbmd9Ci1JbnZva2UgYSBzdGFu ZGFyZCBzaGVsbCB0byBleGVjdXRlIEB2YXJ7Y29tbWFuZCBzdHJpbmd9Lgor QGl0ZW0gc2hlbGwgQHZhcntjb21tYW5kLXN0cmluZ30KK0BpdGVteCAhQHZh cntjb21tYW5kLXN0cmluZ30KK0ludm9rZSBhIHN0YW5kYXJkIHNoZWxsIHRv IGV4ZWN1dGUgQHZhcntjb21tYW5kLXN0cmluZ30uCitOb3RlIHRoYXQgbm8g c3BhY2UgaXMgbmVlZGVkIGJldHdlZW4gQGNvZGV7IX0gYW5kIEB2YXJ7Y29t bWFuZC1zdHJpbmd9LgogSWYgaXQgZXhpc3RzLCB0aGUgZW52aXJvbm1lbnQg dmFyaWFibGUgQGNvZGV7U0hFTEx9IGRldGVybWluZXMgd2hpY2gKIHNoZWxs IHRvIHJ1bi4gIE90aGVyd2lzZSBAdmFsdWV7R0RCTn0gdXNlcyB0aGUgZGVm YXVsdCBzaGVsbAogKEBmaWxley9iaW4vc2h9IG9uIFVuaXggc3lzdGVtcywg QGZpbGV7Q09NTUFORC5DT019IG9uIE1TLURPUywgZXRjLikuCkluZGV4OiB0 ZXN0c3VpdGUvZ2RiLmJhc2Uvc2hlbGwuZXhwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IHRlc3RzdWl0ZS9nZGIuYmFzZS9zaGVsbC5leHAK ZGlmZiAtTiB0ZXN0c3VpdGUvZ2RiLmJhc2Uvc2hlbGwuZXhwCi0tLSAvZGV2 L251bGwJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAorKysgdGVzdHN1aXRl L2dkYi5iYXNlL3NoZWxsLmV4cAkxNSBOb3YgMjAxMSAwNDo1ODozNCAtMDAw MApAQCAtMCwwICsxLDI0IEBACisjIENvcHlyaWdodCAyMDExIEZyZWUgU29m dHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3Ig bW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhl IExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZl cnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0 aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9V VCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJy YW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQ QVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisjCisjIFlvdSBzaG91 bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYg bm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisj IFRlc3QgdGhhdCB0aGUgc2hlbGwgYW5kICEgY29tbWFuZHMgd29yay4KKwor Z2RiX2V4aXQKK2dkYl9zdGFydAorCitnZGJfdGVzdCAic2hlbGwgZWNobyBm b28iICJmb28iCisKK2dkYl90ZXN0ICIhIGVjaG8gZm9vIiAiZm9vIgorZ2Ri X3Rlc3QgIiFlY2hvIGZvbyIgImZvbyIK --bcaec51b15e9213b7f04b1c8ea91--