From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107495-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9120 invoked by alias); 21 Nov 2013 21:47:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9109 invoked by uid 89); 21 Nov 2013 21:47:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-vc0-f175.google.com
Received: from Unknown (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 21 Nov 2013 21:47:48 +0000
Received: by mail-vc0-f175.google.com with SMTP id ld13so267165vcb.34        for <gdb-patches@sourceware.org>; Thu, 21 Nov 2013 13:47:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=wDtljaOEI/n4j8Yqip/AjsoiRePYPWUUB8MhWRQo6ow=;        b=he3+tpBuWb6H6fd8qyubxMdxZcT3asqX76M+hmztBuyHgt0SprYrFyEUMocQGNLlX4         j0NGn9YQBtdOA7kD5x4uDf8RAM/mwHeDIZHVP68yA9LiEeNMaS2iLuEwJcECuiSQB83O         ompYDbXO9GuwI6LISSf2uYptrcPz8PhH+z9b684/eCR+kmgMfKdcKrAvimPrXkKg0bDk         n4TDmynadGYB6QnH85xdpNSXWKAjufhVTh5L+LrqmX6BlP1iBO8BF7aY0hV5XRW8y9UG         teBGuXOZfTcrA7UtyJ2VF0/FtIyoQPotMbGX/JvOhw06s0DbZuDb83VfLdI8AReFAg09         2sOA==
X-Gm-Message-State: ALoCoQmAgzg5SFYoF6MlWFZ91D3fZawj7yL4lWU+x0e2g+vFEBd3AsXzd0SdV0apSot4cGVNPCP2uMTtK8zQToKJNY4xY75z0i4C8FYkW8PnJBpew5rM8cF0edg0I7uRSMdLawoNMedRaOXZPFhNmQ3IRhhtr/LjcaGB0jbyD3xs9wxc7zij0f4km27KEP09NNJKpXBSHK7VnhzsBKVvPSukq3MREyU1pw==
MIME-Version: 1.0
X-Received: by 10.52.32.66 with SMTP id g2mr6757633vdi.14.1385070460379; Thu, 21 Nov 2013 13:47:40 -0800 (PST)
Received: by 10.52.163.52 with HTTP; Thu, 21 Nov 2013 13:47:40 -0800 (PST)
In-Reply-To: <87k3g1foiq.fsf@fleche.redhat.com>
References: <1384996594-20865-1-git-send-email-yao@codesourcery.com>	<1384996594-20865-3-git-send-email-yao@codesourcery.com>	<528D781A.7070909@codesourcery.com>	<871u29h7oa.fsf@fleche.redhat.com>	<CADPb22QeSOxno1LNhJat=AMwA5Lp-3DvsPkpFtSAMD-W9pbymA@mail.gmail.com>	<87k3g1foiq.fsf@fleche.redhat.com>
Date: Fri, 22 Nov 2013 00:38:00 -0000
Message-ID: <CADPb22SeOK7ut9tviDQUA_X5+U_EpknfRWiHbz=WiNF80RP6yA@mail.gmail.com>
Subject: Re: [PATCH 2/3] set/show code-cache
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg00662.txt.bz2

On Thu, Nov 21, 2013 at 1:11 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Tom> It seems unusual to have "ON" in upper case.
>
> Doug> cut-n-paste from the stack-cache case.
>
> Doug> I forget what the rules are here.
> Doug> Do we require fixing the stack-cache case first?
>
> I don't know if we have a rule.
>
> I generally try not to require people to fix existing problems.
> My view is that patch submitters aren't responsible for the context; and
> that if it matters that much to me, I can fix it myself.  (On occasion I
> may ask nicely though...)
>
> But, I think it's ok to require that new bad cases not go in, as a
> general rule.

"works for me"