From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20743 invoked by alias); 22 Jan 2014 04:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20730 invoked by uid 89); 22 Jan 2014 04:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f179.google.com Received: from mail-ie0-f179.google.com (HELO mail-ie0-f179.google.com) (209.85.223.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 22 Jan 2014 04:41:47 +0000 Received: by mail-ie0-f179.google.com with SMTP id ar20so6139476iec.24 for ; Tue, 21 Jan 2014 20:41:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=AS70ea2rIZwRfHSbReB/HVpnorpytFnfwj0ldnEHe4w=; b=BVPnFFnBDoQwKHBMTTYAh5qASc1FOIGw5ECivtZxKdybxWoiZgxiMclbfAHu6SI3b7 v+9f4udxRu4Vx63lbGN/l7QE/lQpAYo2khSZ6pH+XDjPfOyazFp4quViAFHj4SvvgiNc //t2OG6Eyi/Gga+0AWdwZMiPLylLYStazSCgF0tmZpndxdUdQxahw6IPvq4AArH9yc5e X/ImicUFdZnfK3/ecTxe74z8gjslTIe1ln22ORoFiZlSALIweb80PysDH8NJeWcz3I+I VBd9RqE6dgKZ9bEfecCR22uDgOQZ6B8y9y2j9sHYm9tFrjmI1mlUBZteA8+attSYTkjV RZ9A== X-Gm-Message-State: ALoCoQlQG23iK9wnqEJifFm9AY7JqpwTWxwI9eH5WUOyyAyoMRniSmvCStF4PKWTfgA3k0jlKwDF6w+LhisXYIU9CxEZq3LVU8pQSVhLDUKOazgJCJ8S4do5sRCunOpKAvJXYRJs2KrtDSsgPlMRJhoQrCl9AV8ZXf1MHfMpxSn/vCSxEZRA215wr3jmdm7t4VyRHt6M41AsIvPNvWSIvtnM87ZYUtEOQQ== MIME-Version: 1.0 X-Received: by 10.50.60.4 with SMTP id d4mr21698596igr.14.1390365705822; Tue, 21 Jan 2014 20:41:45 -0800 (PST) Received: by 10.64.58.77 with HTTP; Tue, 21 Jan 2014 20:41:45 -0800 (PST) In-Reply-To: <1390300575-6998-1-git-send-email-brobecker@adacore.com> References: <20140118015244.GA22787@sourceware.org> <1390300575-6998-1-git-send-email-brobecker@adacore.com> Date: Wed, 22 Jan 2014 04:41:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME From: Doug Evans To: Joel Brobecker Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00834.txt.bz2 On Tue, Jan 21, 2014 at 2:36 AM, Joel Brobecker wrote: > Hello, > > While looking at this macro, I noticed that it wasn't always necessarily > defined. That prompted me to search the current sources to make sure > that all uses were adequately protected, which they were. But to help > prevent future uses to be made unprotected, this patch expands the > current macro documentation a bit. > > gdb/ChangeLog: > > * common/common-utils.h (FUNCTION_NAME): Expand the macro's > documentation a bit. > > I would commit on its own, but since I am going to put the next in > for the same macro up for review, it's just as easy to make that one > wait as well, in case there are comments. Yeah, I stumbled a bit on this myself. It's not clear to me whether not defining it or defining it as NULL (and update all current users to deal with that) is better but I went with keeping things as they are.