From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5326 invoked by alias); 17 Jul 2014 11:55:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5309 invoked by uid 89); 17 Jul 2014 11:55:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f177.google.com Received: from mail-vc0-f177.google.com (HELO mail-vc0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 17 Jul 2014 11:55:14 +0000 Received: by mail-vc0-f177.google.com with SMTP id hy4so4200631vcb.8 for ; Thu, 17 Jul 2014 04:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=mv9nbz7+lAmYrfNhOVirUu9oqIY+UXD2xZKCPplrrXI=; b=BgXPzqBHe41FelVcF+0xQwN3w3IdWXAaOj+9puRNWSIlSRO6+51RU8Y9E14XwW5uAB rrw4SAE7SWkpheYxD/JmLok7puHcv33jMNhXkX8twVoTV8j3CgyAhjsD4y64RKjcNgNB +c/sgg2JL8FtXwP4v+dGXnnWiuzbwqMW4mBLkejE8I/n9yhbFSgUXUCoZg/RbdozlIri npa/3ucotBh5RDn4a8X+RNV2AVgEmynXDB84jH8B99OaYcxWUG8U/4F6bAjUsS3odsSd dl15IiSei/uoT7uSX4ineSNOq/1rbrb3VaESIVd3dDnKremUfDC//KCCNZmDeROKIe37 7C4A== X-Gm-Message-State: ALoCoQk+mpYtbmyeVaO3Tak3IGMxwzGhirqjDBb1OP/5YMOen4bHmA5T3UCFDXamMtA+8J2ANIuC MIME-Version: 1.0 X-Received: by 10.221.56.132 with SMTP id wc4mr17238983vcb.38.1405598112705; Thu, 17 Jul 2014 04:55:12 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 17 Jul 2014 04:55:12 -0700 (PDT) In-Reply-To: <53C4F655.2040708@redhat.com> References: <20140630171333.GA2225@host2.jankratochvil.net> <21437.45024.997531.453750@ruffy.mtv.corp.google.com> <53BEC275.8000004@redhat.com> <21440.24455.769287.540494@ruffy.mtv.corp.google.com> <53C4F655.2040708@redhat.com> Date: Thu, 17 Jul 2014 12:02:00 -0000 Message-ID: Subject: Re: [PATCH] Re: Regression for GDB global --statistics From: Doug Evans To: Pedro Alves Cc: Jan Kratochvil , Eli Zaretskii , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00458.txt.bz2 On Tue, Jul 15, 2014 at 10:37 AM, Pedro Alves wrote: > On 07/11/2014 11:04 PM, Doug Evans wrote: >> Pedro Alves writes: > >> > It's not obvious to me how this can be NULL, given we initialize >> > it so early. If there's a good reason, could you please add >> > a comment here mentioning it? > > ... > >> - ALL_SYMTABS (o, s) >> + /* When collecting statistics during startup, this is called before >> + pretty much anything in gdb has been initialized, and thus >> + current_program_space may be NULL. */ >> + if (current_program_space != NULL) > > Great, thanks! > > -- > Pedro Alves Apologies for the repeat (note to self: try to remember to not send email to list from phone). Committed to trunk and 7.8. Jan: Please commit your testcase (no point in resending both messages, bleah).