From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [RFC] Record objfile->original_name as an absolute path
Date: Thu, 26 Sep 2013 01:54:00 -0000 [thread overview]
Message-ID: <CADPb22Sbtq_xyAv4rgTNkwugzd1JBWhMM4ozJ55We3AT2bqfag@mail.gmail.com> (raw)
In-Reply-To: <yjt2zjr09xqr.fsf@ruffy.mtv.corp.google.com>
On Wed, Sep 25, 2013 at 6:29 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> The comment for objfile->original_name says the path is stored as an
> absolute path, but that's not the case, and that got me thinking:
> What if the user cd's before the debug info is accessed?
>
> This patch is only RFC, and not RFA, because I'm not sure how to do
> something better in the test. I can certainly clean up what's there,
> if people think it's not *too* cheezy.
>
> [...]
>
> 2013-09-25 Doug Evans <dje@google.com>
>
> * objfiles.c (allocate_objfile): Save original_name as an absolute
> path.
> * objfiles.c (struct objfile): Expand comment on original_name.
> * utils.c (gdb_abspath): New function.
> * utils.h (gdb_abspath): Declare.
>
> testsuite/
> * gdb.dwarf/dwp-symlink.c: Fake out gdb to not load debug info
> at start.
> * gdb.dwarf/dwp-symlink.exp: Test trying to load dwp when the binary
> has been specified with a relative path and we have chdir'd before
> accessing the debug info.
One thought for doing the test differently is to have an option to the
"file" command that is the opposite of -readnow, that tells gdb to not
read any debug info (even to set the initial language).
next prev parent reply other threads:[~2013-09-26 1:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 1:29 Doug Evans
2013-09-26 1:54 ` Doug Evans [this message]
2013-09-26 8:28 ` Jan Kratochvil
2013-09-26 8:47 ` Jan Kratochvil
2013-09-27 19:37 ` Tom Tromey
2013-10-08 18:23 ` [patch] OBJF_NOT_FILENAME [Re: [RFC] Record objfile->original_name as an absolute path] Jan Kratochvil
2013-10-08 20:18 ` Tom Tromey
2013-10-09 13:23 ` [commit] " Jan Kratochvil
2013-10-09 14:46 ` [patchv2] Record objfile->original_name as an absolute path Jan Kratochvil
2013-10-09 16:37 ` Doug Evans
2013-10-10 4:58 ` Joel Brobecker
2013-10-10 16:31 ` Doug Evans
2013-10-10 16:37 ` Jan Kratochvil
2013-10-10 18:07 ` Tom Tromey
2013-10-10 18:55 ` Doug Evans
2013-12-02 21:26 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Sbtq_xyAv4rgTNkwugzd1JBWhMM4ozJ55We3AT2bqfag@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox