From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31338 invoked by alias); 31 Jul 2014 20:33:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31327 invoked by uid 89); 31 Jul 2014 20:33:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 31 Jul 2014 20:33:12 +0000 Received: by mail-vc0-f175.google.com with SMTP id ik5so5128807vcb.6 for ; Thu, 31 Jul 2014 13:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4ofXE/E+u8U2ITAg9BfeURJ7chfE+Iltl2VDX7UJk8s=; b=NaFnWIXCI95AMZl3ypkXz7zkdbOoUx630gMRYCTlv7v8zlYIXPVuuLC4QDYKtfz79M kpRa4XPrnQLkI9tlPc0sIJHodflGIu7+HIeY8hGmNXmSknL5CpiqKl0G1wfpueS1jGm2 w7A4btUpgwsuXXx7g4zuytw8Utj5XcQqPxuP/52OGGs9Aoc4rJB/hM+rbuQ7RUDfMqzU 0Y6Oax8I65+5u4hQVoruI71DUvkQjhGv3bSBx8KHKjwWhH5czCuQt07o+4CafPEV80MB YScrzI39/0mYc7iaDk4wQHKwxuJquJXEEe5bgfkPT+Rxi12xeN2As2p/4phh77T6zQnm NyKA== X-Gm-Message-State: ALoCoQlYdTj3kSAp5pkl6S7Jtx1szUCe/VKkRG/vSHq0Vd9iOSxW7qTO2DUynX9VgUXedNPts1sJ MIME-Version: 1.0 X-Received: by 10.52.135.133 with SMTP id ps5mr812219vdb.33.1406838789251; Thu, 31 Jul 2014 13:33:09 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 31 Jul 2014 13:33:09 -0700 (PDT) In-Reply-To: <20140731200529.GG14672@adacore.com> References: <20140731193050.GA7927@host2.jankratochvil.net> <20140731200529.GG14672@adacore.com> Date: Thu, 31 Jul 2014 20:42:00 -0000 Message-ID: Subject: Re: [PATCH] Delete struct inferior_suspend_state From: Doug Evans To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00835.txt.bz2 On Thu, Jul 31, 2014 at 1:05 PM, Joel Brobecker wrote: >> If we're going to keep comments we might as well keep the #if 0'd code >> (which is fine by me). >> There's no real difference between the two, and the #if 0'd out code >> is more descriptive, though I would add a commit (tweak a comment?) so >> that the next person will more easily know that the #if 0's are ok. >> IWBN to have examples where #if 0 is at least not a bad thing. > > In my experience, #if 0'ed code has been bit-rotting. Better, IMO, > to just be as descriptive as possible in the code, even if that > involves naming functions, etc. That way, we can maintain the > description a little better. Comments don't necessarily fare much better. Consider the 23 year old TODO. 1/2 :-) ref: https://sourceware.org/ml/gdb-patches/2014-07/msg00832.html