From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114548-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10594 invoked by alias); 24 Jul 2014 20:54:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10579 invoked by uid 89); 24 Jul 2014 20:54:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vc0-f176.google.com
Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Jul 2014 20:54:39 +0000
Received: by mail-vc0-f176.google.com with SMTP id id10so5942131vcb.7        for <gdb-patches@sourceware.org>; Thu, 24 Jul 2014 13:54:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=W2mDCmyZ7T5yNAMv4Ag8FKC1zhvgkAAHfY9WNHi5ing=;        b=NKExagUXsiyOnbcQSHcDD0OVr6RJd6w4e6daf3vZigCHJoozkbvxxfqqH1ha8xlvIa         qb2WQUUH+PA3s/bNMV+VBdOq6izXWbOTSEEJbXLAX+hSGQZQv854lDQHeg6bJq4JQ0DA         PLj1SswhCxXxy4A1GnzTjt1Ne0XBg5iSsLLsYztnW/+1iejF16LOPhqntCMW008VNgcZ         pz6SnqVUbULk4EqZRerl8sWbExVmaamescJ5IKsRR2mLftp3dhviJsSpBVYck1J7kelW         2C+/GICzvhjekeHECaebmig5YRfwfw0/N296nXP+7upCyZ5iy5NyprS2XLeqlVFwBH94         NBYQ==
X-Gm-Message-State: ALoCoQnzWqDhgkZcW8G59BC+9Q2mcKW96V/H/T4ujrqxZmyHyIUBMxbhBr8vFly4lBPWl0VVSs99
MIME-Version: 1.0
X-Received: by 10.52.117.209 with SMTP id kg17mr13855936vdb.28.1406235277604; Thu, 24 Jul 2014 13:54:37 -0700 (PDT)
Received: by 10.52.28.233 with HTTP; Thu, 24 Jul 2014 13:54:37 -0700 (PDT)
In-Reply-To: <21457.17973.551020.113918@ruffy.mtv.corp.google.com>
References: <1406206287-6817-1-git-send-email-gbenson@redhat.com>	<1406206287-6817-2-git-send-email-gbenson@redhat.com>	<21457.17973.551020.113918@ruffy.mtv.corp.google.com>
Date: Thu, 24 Jul 2014 22:39:00 -0000
Message-ID: <CADPb22SZ785ATLaP91QpZig9sPW07BtKvVqvQP+-gNrVfic8vw@mail.gmail.com>
Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h
From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Pedro Alves <palves@redhat.com>, 	Tom Tromey <tromey@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00653.txt.bz2

On Thu, Jul 24, 2014 at 10:45 AM, Doug Evans <dje@google.com> wrote:
> Gary Benson writes:
>  > This introduces common/errors.h.  This holds some error- and
>  > warning-related declarations that can be used by the code in common.
>  > Clients of the "common" code must provide definitions for these
>  > functions.
> [...]
>  > @@ -2144,6 +2144,10 @@ rsp-low.o: ${srcdir}/common/rsp-low.c
>  >      $(COMPILE) $(srcdir)/common/rsp-low.c
>  >      $(POSTCOMPILE)
>  >
>  > +errors.o: ${srcdir}/common/errors.c
>
> Nit: $(srcdir)

Holy cow, I see gdb/Makefile.in is rather inconsistent here.
Ok, no point in cleaning this up here.
One can even argue to leave it as ${srcdir}.  Fine by me.