From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 824 invoked by alias); 11 Oct 2012 16:58:30 -0000 Received: (qmail 813 invoked by uid 22791); 11 Oct 2012 16:58:28 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 16:58:23 +0000 Received: by mail-oa0-f41.google.com with SMTP id k14so2339001oag.0 for ; Thu, 11 Oct 2012 09:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=RaUTYV3MpvlUt83ZPsVDEbbBNNFltw03bWWYk7fDYf0=; b=fNnxF49RU4XhSx2EM8p8Xd/KhScDR0EVyvC31iicRyqmEh2Rvs/Z49R73XBtovj13I e+ZKnhj6w4A0Rs3tshvz2SfROZMmxKjwi+MEFYNcpNRcKtZFI8JUKoL9fT4ifua0u55H CFXKG4SF9Wqr5iV/pErVebKSljVBQEPWd1AF3BZXzPIpzXesof69kUmIE71x7zIVRTcY 6AyHmHHgpN+9XPN1HQwRnuLNEonhwA9vGLfPhWIh40+sbOrEIKbqYwDI9lKXHix5SP2x Ov/azpBvXk82jFZ0lhARb+Us0flAo1a5RxKfcS/emORBEnYn29TJKi8YBq5Xl9LMaoSo XslA== MIME-Version: 1.0 Received: by 10.60.27.166 with SMTP id u6mr1218015oeg.86.1349974702325; Thu, 11 Oct 2012 09:58:22 -0700 (PDT) Received: by 10.76.96.209 with HTTP; Thu, 11 Oct 2012 09:58:22 -0700 (PDT) In-Reply-To: <5069E52B.60203@redhat.com> References: <5069E52B.60203@redhat.com> Date: Thu, 11 Oct 2012 16:58:00 -0000 Message-ID: Subject: Re: [RFA] partial fix for 14643 From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQkqkOXzt4Ab6zmZWgAibt5z/07Wth7DklZGqGH20yY2StgNuE/zzygNxUkOaICXjYhiSJHucSkr+nhdH2mKJcUZxLiCZyl/YF4RQJpikNV+SV2t1KNBisnAkE0Dp3fVPLcNx+B6HC38gX4gyDapr7JnDPc2fzPht4ESHJJD9UyBrkBFeMw10VSuhSz34EeB04bmVuyoPx492N3knmyhel55Go4qjQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00179.txt.bz2 On Mon, Oct 1, 2012 at 11:47 AM, Keith Seitz wrote: > On 10/01/2012 11:08 AM, dje@google.com wrote: >> >> It does not fix "b foo:: thread ::bar()". >> My fix for that is a bit hackish, and that case isn't as important. > > > Yeah, it's not a big deal IMO, either, but I've been mistaken before. > Naively, I would think keyword_ok could be (un)set whenever a scope operator > is seen. I haven't investigated this at all of course. > >> Ok to check in? > > > You're a global maintainer! :-P FWIW, I think this change is fine. Inelegant > perhaps, but quite honestly, there are too many other, bigger > issues/problems to solve to worry about this. > > Keith Thanks. Committed to trunk and 7.5 branch.