From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88614-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25184 invoked by alias); 7 Mar 2012 18:58:32 -0000
Received: (qmail 25176 invoked by uid 22791); 7 Mar 2012 18:58:31 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Mar 2012 18:58:18 +0000
Received: by vcbfk14 with SMTP id fk14so6636934vcb.0        for <gdb-patches@sourceware.org>; Wed, 07 Mar 2012 10:58:18 -0800 (PST)
Received: by 10.52.240.161 with SMTP id wb1mr5099852vdc.20.1331146698209;        Wed, 07 Mar 2012 10:58:18 -0800 (PST)
MIME-Version: 1.0
Received: by 10.52.240.161 with SMTP id wb1mr5099826vdc.20.1331146698005; Wed, 07 Mar 2012 10:58:18 -0800 (PST)
Received: by 10.220.201.140 with HTTP; Wed, 7 Mar 2012 10:58:17 -0800 (PST)
In-Reply-To: <20120307171249.GB22619@host2.jankratochvil.net>
References: <20120305223429.GM2867@adacore.com>	<20120307170940.GA22619@host2.jankratochvil.net>	<20120307171249.GB22619@host2.jankratochvil.net>
Date: Wed, 07 Mar 2012 18:58:00 -0000
Message-ID: <CADPb22SQt9G4skq9LWxKTrivW-d6JRXzWTNupWjFrkWAboJV8A@mail.gmail.com>
Subject: Re: [patch 2/2] typedef-checking for CU relative vs. absolute offsets [Re: RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback]
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-System-Of-Record: true
X-Gm-Message-State: ALoCoQmAFw0BwqPoFsgZdjt/0D7sRBYLBH3VzZYzQzer/kt1Dc4wdIQDl0n4+q8ipCMeO9/cLO2NJSZfsk+yuyY8gBNMW4xNsPz/xPYhtL2cvzQE2vDSvX8tDNMFGlT/VnuBDuQEcBLVwGxROGBSGQrBoTlVl8C88g==
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00236.txt.bz2

On Wed, Mar 7, 2012 at 9:12 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Wed, 07 Mar 2012 18:09:40 +0100, Jan Kratochvil wrote:
>> There are more issues of this kind.
>
> This is not maintainable IMO in its current form.
>
> typedef struct { unsigned int co; } cu_offset;
> typedef struct { unsigned int so; } sect_offset;
>
> OK with the patch?

The problem stems from "offset" being ambiguous.
I'd rather just pick a better (clearer) name and be consistent.