From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21624 invoked by alias); 21 May 2013 23:14:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21613 invoked by uid 89); 21 May 2013 23:14:27 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-vb0-f44.google.com (HELO mail-vb0-f44.google.com) (209.85.212.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 23:14:25 +0000 Received: by mail-vb0-f44.google.com with SMTP id e13so876568vbg.3 for ; Tue, 21 May 2013 16:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=a210wLY3gxp1wupktTKIqzNtLwILLSk6PH6Hd8acyA8=; b=D+6AaSCotrsyda2JFzt7cigwNZ/KGIiCDQ8jJYzQ67b2RjdokD2mipdpHtJt1/2e+Z TV36pPwuMhXZkEeQbaLPA2Wpei12UASoX9EhjA+mh7hLP2TNbRPeoKz+P0hP6mCFn/9j sYUe88cV1fWhY/vAurwe8kTrORriOW8LadhlHN1Du+SuIenUBxaLeNQEW9gia5+T9Dnx Ro3qtuLWgb5V2FJL+Ht/cS9lnhN51dSoXRFuD3cmFxasZpTFrubITRk4H2uAd7glTysN DXp/ZIIzArpAaRag9JvIomk/hISbvkk1nNJJwXVwSOBbp5F8lbFIDnfMiyE43emuw+xj BZBg== MIME-Version: 1.0 X-Received: by 10.58.88.4 with SMTP id bc4mr1795671veb.48.1369178063979; Tue, 21 May 2013 16:14:23 -0700 (PDT) Received: by 10.220.100.68 with HTTP; Tue, 21 May 2013 16:14:23 -0700 (PDT) In-Reply-To: References: Date: Tue, 21 May 2013 23:14:00 -0000 Message-ID: Subject: Re: [patch] Fix crash in svr4_clear_so From: Doug Evans To: Paul Pluzhnikov Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQloSSVsWwiYH4fB8+CVwMbLzJ1aYvO0Ph9AdUWYpa+bJRuWj2WvxcqFYZLL/fxe3PS1h4Uoj9rDHSUmiPN2R6Kwzghtx/TbzwaNzE2c4xHsEDzPi0MZ5swepRymVx0GbQfl0s42BKvd7bGacOoTKYIg4AglNUwGdciDE1HgBmWMzFBEXs3h5osxDE+GgAUFSkDQf9sNGyEQwrWtw9VZO0PcndhWMQ== X-SW-Source: 2013-05/txt/msg00794.txt.bz2 On Tue, May 21, 2013 at 3:23 PM, Paul Pluzhnikov wrote: > Greetings, > > Using current trunk, I've got a GDB core dump when I tried to analyze > mis-matched binary and core: > > gdb a.out core > GNU gdb (GDB) 7.6.50.20130521-cvs > ... > warning: core file may not match specified executable file. > [New LWP 29265] > ... > [New LWP 27085] > [New LWP 27052] > warning: Error reading shared library list entry at 0x3b48104f8b480000 > Segmentation fault > > The actual crash is happening here: > > Program received signal SIGSEGV, Segmentation fault. > 0x0000000000481376 in svr4_clear_so (so=0xc833490) at ../../src/gdb/solib-svr4.c:974 > 974 so->lm_info->l_addr_p = 0; > > #0 0x0000000000481376 in svr4_clear_so (so=0xc833490) at ../../src/gdb/solib-svr4.c:974 > #1 0x0000000000708bc4 in clear_so (so=0xc833490) at ../../src/gdb/solib.c:537 > #2 0x0000000000708bef in free_so (so=0xc833490) at ../../src/gdb/solib.c:556 > #3 0x00000000006ee328 in do_free_so (arg=0xc833490) at ../../src/gdb/utils.c:492 > #4 0x0000000000573474 in do_my_cleanups (pmy_chain=0xc5c1f0 , old_chain=0x35232410) at ../../src/gdb/cleanups.c:155 > #5 0x00000000005734e1 in do_cleanups (old_chain=0x35232410) at ../../src/gdb/cleanups.c:177 > #6 0x00000000004817e0 in svr4_read_so_list (lm=4271682180386127872, link_ptr_ptr=0x7fff7fc37c58, ignore_first=1) at ../../src/gdb/solib-svr4.c:1195 > #7 0x0000000000481b01 in svr4_current_sos () at ../../src/gdb/solib-svr4.c:1311 > #8 0x0000000000708eea in update_solib_list (from_tty=0, target=0xc724c0 ) at ../../src/gdb/solib.c:674 > ... > > Attached patch fixes the GDB crash. > > Ok for trunk? > > Thanks, > -- > > 2013-05-21 Paul Pluzhnikov > > * solib-svr4.c (svr4_free_so): Protect against NULL dereference. Hi. Ok by me.