From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97311-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32604 invoked by alias); 22 Dec 2012 19:33:15 -0000
Received: (qmail 32596 invoked by uid 22791); 22 Dec 2012 19:33:14 -0000
X-SWARE-Spam-Status: No, hits=-5.6 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Dec 2012 19:33:09 +0000
Received: by mail-oa0-f47.google.com with SMTP id h1so5726665oag.20        for <gdb-patches@sourceware.org>; Sat, 22 Dec 2012 11:33:08 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :cc:content-type:x-gm-message-state;        bh=6tl8Menp4r8XxqK8bL5RDo+U+1cbN/x6PamopjVTKIo=;        b=XYJtmrWwoyLU+yO2rsHDp1A8Cs8imvW80/bhEo+WVAhpmrISJHOAAjqGysCIr/CtW4         OnH8lY0c84z7S3SRBgw5+HhplHfnTGIp6U4w0T+8xgf/UdKCr0qYP+dfclLBM9M3JfJs         5KVUHDxmZN4KcmJCZC0SV3aaYZdeBILa1eMtCA7ENra3N35ssI5vEhSmeq6J3ne/ScDO         ukhZ4l/D+nhF/1Vrhdj8iyZX3Z+lAyBPDUkZKXvq/IjaPLBEpQW6cf5plngQRF16Zfyi         AYxhU8y1gRPyXx3EVmzA3uOs1XHUADyzFE01DFs1A3k3hxDST6dYZoda5A00kCnq4b4l         CMXQ==
MIME-Version: 1.0
Received: by 10.182.240.45 with SMTP id vx13mr14631093obc.21.1356204788458; Sat, 22 Dec 2012 11:33:08 -0800 (PST)
Received: by 10.76.169.202 with HTTP; Sat, 22 Dec 2012 11:33:08 -0800 (PST)
In-Reply-To: <20121221175058.GH5370@adacore.com>
References: <50D331A6.5070102@ubuntu.com>	<50D3321C.5030902@ubuntu.com>	<20121220155906.GB5370@adacore.com>	<50D3391A.4000506@ubuntu.com>	<20121221075721.GE5370@adacore.com>	<CADPb22S7Hmm=MhyFFZZiH18S_CJr-Xps_V1Ts_m6kPjGOCa9Bw@mail.gmail.com>	<20121221175058.GH5370@adacore.com>
Date: Sat, 22 Dec 2012 19:33:00 -0000
Message-ID: <CADPb22SNAAbPE2L_fAOkOL3CU6q=4wGie=ogZCNyM2zr9Dw87g@mail.gmail.com>
Subject: Re: [patch] use python-config if available
From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Matthias Klose <doko@ubuntu.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQmGujX3Ta9nIRHAev7ejv3kZ9r6kWu8WbYCyUaQ9oRTi2Hw+miAogkaM/9/CEF6H9w/Z2x/PbWZJZYlPnJyCr5Z/z1I0pieRZtR8ZEnriaDNtBMxPgbsHDxQ6bIZ7+Wu+F150lFxdg07mRh6sLZ1vvkE3zWh33uFUMiIXrZ4jYL0/CcCl0LyUkq7DSOiuPMlm9cGp9JOUDCXEv3YSaEjKCNOtHS8A==
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00784.txt.bz2

On Fri, Dec 21, 2012 at 9:50 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> The patch is fine with me.
>> [The plan wasn't to shift and call the "real" python-config ... at the
>> time there was no real python-config for cross builds.]
>>
>> One typo: should be ${python_config}
>>
>> -        AC_ERROR(failure running python-config --exec-prefix)
>> +        AC_ERROR(failure running ${python-config} --exec-prefix)
>
> Can we make this new behavior optional? The "real" python-config
> is broken for several platforms, and having our own that we can
> control was very convenient.

I certainly don't want to break your use-case.

I need to look at the patch again (but I probably won't get to it
until next week).