From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28169 invoked by alias); 24 Jun 2013 19:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28158 invoked by uid 89); 24 Jun 2013 19:03:42 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ie0-f177.google.com (HELO mail-ie0-f177.google.com) (209.85.223.177) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 19:03:41 +0000 Received: by mail-ie0-f177.google.com with SMTP id aq17so23881035iec.8 for ; Mon, 24 Jun 2013 12:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=secMJ/2RATchttQlrTHJ6nVfBX6DJ8uusl1YyxURFEo=; b=olPOscrarQUrV8FU6OFSdhCgQcBUm7DKXXLRByVkH6FJ88hJnwBsncS5/rmXp+yFKa 72yO+LYEEKTD4lp9Wza868gef5XsR5uXI5F6S7WovCwvtA01XDsaCkBpBaCQKN9Rle6D qfvGdzUqoDCWKvRwtlYO3MCV3TwONLit/Pdm20x1EfrGNRFCat/ECqHiKbjhKDP2OJeE VDiVnmJY4ORD5hU7Gv1smxPmvgbz+U+AWq0rPbobgC6bwkfLXqs7IR2mOE+ePJhgTv58 Nkj1hVjcnHwxN0N6EH9DIz+WkNvlxuhJoCXQ9eaitvA2iO9HGpky3qWHcCbLXUJmxlyV OVww== MIME-Version: 1.0 X-Received: by 10.50.50.2 with SMTP id y2mr4974778ign.25.1372100620228; Mon, 24 Jun 2013 12:03:40 -0700 (PDT) Received: by 10.231.143.6 with HTTP; Mon, 24 Jun 2013 12:03:40 -0700 (PDT) In-Reply-To: <834ncnjqmg.fsf@gnu.org> References: <1365761475-23845-1-git-send-email-yao@codesourcery.com> <83fvyr58c5.fsf@gnu.org> <516DEDAD.8070902@codesourcery.com> <516E0ED2.2080203@codesourcery.com> <83obdd2irl.fsf@gnu.org> <83sj0al6u1.fsf@gnu.org> <834ncnjqmg.fsf@gnu.org> Date: Mon, 24 Jun 2013 19:04:00 -0000 Message-ID: Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration' From: Doug Evans To: Eli Zaretskii Cc: Yao Qi , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmJTM2ocF/CcBUAtxdd9mvQHo2GouVs2n/JimOhCWJQKzYuFbkXtkLF+iYepnYV0G7BQWNlWH/oxtnjrZKS5EvLNw0mP1AZkpjGpi2rBn7F5laeM7+wiU7DsS7kV4GkSN7r/V7KHkVOD4NMhD73WVZnWGEPyYaWh4xOr4aA/ZAPpTsPgBE4mz9+YOUQZyewNbVIBo8mMiCpwUMczUUY55omJkfg+Q== X-SW-Source: 2013-06/txt/msg00670.txt.bz2 On Mon, Jun 24, 2013 at 11:44 AM, Eli Zaretskii wrote: >> Date: Mon, 24 Jun 2013 11:35:31 -0700 >> From: Doug Evans >> Cc: Yao Qi , gdb-patches >> >> > diff -u -p -r1.236 top.c >> > --- gdb/top.c 30 May 2013 17:27:44 -0000 1.236 >> > +++ gdb/top.c 22 Jun 2013 11:30:47 -0000 >> > @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\ >> > --without-babeltrace\n\ >> > ")); >> > #endif >> > + fprintf_filtered (stream, _("\n\ >> > + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\ >> > +")); >> > } >> >> If you want to print something here, then I think you need to take >> into account whether "relocatable" is printed at all. > > I don't think it's a real danger. One must invest a non-trivial > effort to have GDB configured without a single relocatable directory. Ok, How about: + /* We assume "relocatable" will be printed at least once, thus we always + print this text. It's a reasonably safe assumption for now. */ + fprintf_filtered (stream, _("\n\ + (\"Relocatable\" means the directory can be moved with the GDB installation" "tree and GDB will still find it.)\n\" +")); [N.B. I didn't verify 80-column-ness, leaving that to you if you like the wording.] >> How about just a sentence or two in the manual near the description of >> --configuration (or some such). > > I tried that, but found no good place to say that. Just saying > something where --configuration is described will get this lost in the > humongous manual, and users will not necessarily know where to look. "relocatable" doesn't appear that many times in the manual. "(relocatable)" doesn't currently appear at all. If a user can't find it I'm not worried about claims it's the manual's fault. Having this text is not important to me though, so feel free to drop it.