From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24787 invoked by alias); 8 Feb 2014 05:00:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24769 invoked by uid 89); 8 Feb 2014 05:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f180.google.com Received: from mail-vc0-f180.google.com (HELO mail-vc0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 08 Feb 2014 05:00:37 +0000 Received: by mail-vc0-f180.google.com with SMTP id ks9so3372391vcb.11 for ; Fri, 07 Feb 2014 21:00:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=exJ4Md5DSHmBxiZpZyhnOlmXmyfFKneWCIksWOJVTuM=; b=Wf4euDqxUoQoTrV6dkp7B+oP+X49Pz+BmJ6m/M8stf6d69h/bSnxyHt7165YxmHDcg xiExQfB14AJ2eV9jj92V9DUhEQuQE9Ij9/j4AZzVjdzmceabAfpkMdkQxYSWYinT0M3S hmO+z9FQ8pObCF2l0fQ2NkWqd60qVIMUJkEQQIj572a900Q6FLlujYn10Sm7cIgVnK0L K73ajLyundHrTpFAIS1Cn2HKhAsbVJ5Mc+YLY3LbGpMdqaFozg5xgljTMBOSWMKkPbWz rC+ZHOkOqKl4h14qJk51MKEPpdptvZNjEDG8nE65dxANDFZFEj6MH/bUcNcQsX85M4fI ekbA== X-Gm-Message-State: ALoCoQmk8sbSIWJNnwKc2ljQyy/3UsB2Eb861jbYiiIcdsu+oejaTIw9jzip66kPfU1jgIwfPJaLdl37s3Bew7AWSJjnrWP8S0fr/2+BI/uMHujIiaLo7iNMy9nZ615iuY6D2f0VOvSJsluvug8bKyrzBVyqH/meMl1cmXJLe3PPFPr7QoTqAgfOkRe8jWCeGBfswSO71RMtZbRtOjUtdso1YeEU9yfMQA== MIME-Version: 1.0 X-Received: by 10.58.100.100 with SMTP id ex4mr13601522veb.2.1391835635642; Fri, 07 Feb 2014 21:00:35 -0800 (PST) Received: by 10.52.51.234 with HTTP; Fri, 7 Feb 2014 21:00:35 -0800 (PST) In-Reply-To: <201402041033.s14AX8Ai013211@glazunov.sibelius.xs4all.nl> References: <201402041033.s14AX8Ai013211@glazunov.sibelius.xs4all.nl> Date: Sat, 08 Feb 2014 05:00:00 -0000 Message-ID: Subject: Re: [PATCH] Makefile fix From: Doug Evans To: Mark Kettenis Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00238.txt.bz2 On Tue, Feb 4, 2014 at 2:33 AM, Mark Kettenis wrote: > The diff below fixes an issue that has been bothering me for quite a > while. When using OpenBSD make, almost everything in gdb/ gets > rebuilt. The problem is the use of the all-lib phony target, which is > always considered to be out-of-date, and used as a prerequisite of > libgnu.a and the gnulib string.h, which are therefore also considered > to be out-of-date. I have no idea why this problem doesn't show up > with GNU make. But the GNU make manual clearly states that phony > targets should not be prerequisites of real target files: > > > > It seems to me that the phony target can be easily avoided; see the > diff below. But perhaps I'm missing something? > > > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index ed84e35..937478b 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -1263,10 +1263,8 @@ gdb$(EXEEXT): gdb.o $(LIBGDB_OBS) $(ADD_DEPS) $(CDEPS) $(TDEPLIBS) > $(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) $(LOADLIBES) > > # Convenience rule to handle recursion. > -$(LIBGNU) $(GNULIB_H): all-lib > -all-lib: $(GNULIB_BUILDDIR)/Makefile > +$(LIBGNU) $(GNULIB_H): $(GNULIB_BUILDDIR)/Makefile > @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=$(GNULIB_BUILDDIR) subdir_do > -.PHONY: all-lib > > # Convenience rule to handle recursion. > .PHONY: all-data-directory I found the patch where this went in but I couldn't find anything interesting. "all-lib" is there, I'm guessing, just as a convenience for typing, but I'm not sure how often it's used so if it's getting in the way I'm ok with this change. I can't think of any problems with the patch. [And we could still keep all-lib as a convenience rule, but I'm ok with deleting it for now.]