Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Set remote port numbers correctly in remote-stdio-gdbserver.exp
Date: Thu, 29 Aug 2013 19:10:00 -0000	[thread overview]
Message-ID: <CADPb22SFsUzHhcmksUK59_pF4xQ+=DCv1mo38t6wkL4J=A5y6w@mail.gmail.com> (raw)
In-Reply-To: <CAEG7qUwVarou0=D=RxwWY5oXHUuf5kAOONV-5R1Uey8ZtnAPKg@mail.gmail.com>

On Thu, Aug 29, 2013 at 12:03 PM, Sterling Augustine
<saugustine@google.com> wrote:
> On Thu, Aug 29, 2013 at 11:40 AM, Sterling Augustine
> <saugustine@google.com> wrote:
>> The enclosed fairly straightforward patch to the board file
>> remote-stdio-gdbserver.exp fixes the syntax scp and rsh use to select
>> the remote port, which was broken before.
>>
>> Tested with both default and custom remote ports.
>>
>> OK for trunk?
>>
>> Sterling
>>
>> testsuite/ChangeLog
>>
>> 2013-08-29  Sterling Augustine  <saugustine@google.com>
>>
>>         * boards/remote-stdio-gdbserver.exp: Set rcp_prog and
>>         rsh_prog in new conditional.  Move use of REMOTE_PORTNUM into
>>         said conditional.
>
>
> Let's try that again with the patch actually attached.....

LGTM


  reply	other threads:[~2013-08-29 19:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 18:40 Sterling Augustine
2013-08-29 19:03 ` Sterling Augustine
2013-08-29 19:10   ` Doug Evans [this message]
2013-08-29 19:22     ` Sterling Augustine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22SFsUzHhcmksUK59_pF4xQ+=DCv1mo38t6wkL4J=A5y6w@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=saugustine@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox