From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15098 invoked by alias); 11 Oct 2011 03:38:47 -0000 Received: (qmail 15088 invoked by uid 22791); 11 Oct 2011 03:38:45 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 03:38:30 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p9B3cTZN017400 for ; Mon, 10 Oct 2011 20:38:29 -0700 Received: from qabg27 (qabg27.prod.google.com [10.224.20.219]) by hpaq14.eem.corp.google.com with ESMTP id p9B3UWr2008908 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 10 Oct 2011 20:38:28 -0700 Received: by qabg27 with SMTP id g27so14072909qab.3 for ; Mon, 10 Oct 2011 20:38:27 -0700 (PDT) Received: by 10.224.70.203 with SMTP id e11mr8590594qaj.55.1318304307395; Mon, 10 Oct 2011 20:38:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.70.203 with SMTP id e11mr8590587qaj.55.1318304307248; Mon, 10 Oct 2011 20:38:27 -0700 (PDT) Received: by 10.224.80.149 with HTTP; Mon, 10 Oct 2011 20:38:27 -0700 (PDT) In-Reply-To: <201110101922.54265.pedro@codesourcery.com> References: <20111005182705.D744E2461D1@ruffy.mtv.corp.google.com> <201110071209.18376.pedro@codesourcery.com> <201110101922.54265.pedro@codesourcery.com> Date: Tue, 11 Oct 2011 03:38:00 -0000 Message-ID: Subject: Re: [RFA] Only try to load libthread_db when we load libpthread. From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec517aba8f07cb304aefda362 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00295.txt.bz2 --bcaec517aba8f07cb304aefda362 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1068 On Mon, Oct 10, 2011 at 11:22 AM, Pedro Alves wrot= e: > This version goes back to breaking the "file right_executable" core > or attach cases (with static binaries) that the previous patch > fixed. =A0:-) > [...] > (gdb -c core; file exec). That scenario I hadn't thought of. Thanks, at least the code will be there for a documented reason. Note that the non-static case of that sequence was and still is broken. I checked this in. 2011-10-10 Doug Evans * linux-thread-db.c (thread_db_new_objfile): Only try to load libthread_db when we load libpthread or the main symbol file. (thread_db_inferior_created): New function. (_initialize_thread_db): Attach inferior_created observer. * linux-nat.c (linux_child_post_attach): Remove call to check_for_thread_db. (linux_child_post_startup_inferior): Ditto. * objfiles.h (OBJF_MAINLINE): Define. * symfile.c (symbol_file_add_with_addrs_or_offsets): Pass it to allocate_objfile when appropriate. --bcaec517aba8f07cb304aefda362 Content-Type: text/plain; charset=US-ASCII; name="gdb-111010-libthread-db-5.patch.txt" Content-Disposition: attachment; filename="gdb-111010-libthread-db-5.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gtmc93ef0 Content-length: 7345 MjAxMS0xMC0xMCAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog bGludXgtdGhyZWFkLWRiLmMgKHRocmVhZF9kYl9uZXdfb2JqZmlsZSk6IE9u bHkgdHJ5IHRvIGxvYWQKCWxpYnRocmVhZF9kYiB3aGVuIHdlIGxvYWQgbGli cHRocmVhZCBvciB0aGUgbWFpbiBzeW1ib2wgZmlsZS4KCSh0aHJlYWRfZGJf aW5mZXJpb3JfY3JlYXRlZCk6IE5ldyBmdW5jdGlvbi4KCShfaW5pdGlhbGl6 ZV90aHJlYWRfZGIpOiBBdHRhY2ggaW5mZXJpb3JfY3JlYXRlZCBvYnNlcnZl ci4KCSogbGludXgtbmF0LmMgKGxpbnV4X2NoaWxkX3Bvc3RfYXR0YWNoKTog UmVtb3ZlIGNhbGwgdG8KCWNoZWNrX2Zvcl90aHJlYWRfZGIuCgkobGludXhf Y2hpbGRfcG9zdF9zdGFydHVwX2luZmVyaW9yKTogRGl0dG8uCgkqIG9iamZp bGVzLmggKE9CSkZfTUFJTkxJTkUpOiBEZWZpbmUuCgkqIHN5bWZpbGUuYyAo c3ltYm9sX2ZpbGVfYWRkX3dpdGhfYWRkcnNfb3Jfb2Zmc2V0cyk6IFBhc3Mg aXQgdG8KCWFsbG9jYXRlX29iamZpbGUgd2hlbiBhcHByb3ByaWF0ZS4KCklu ZGV4OiBsaW51eC1uYXQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2xpbnV4LW5hdC5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIxNgpkaWZmIC11IC1wIC1yMS4yMTYgbGludXgtbmF0 LmMKLS0tIGxpbnV4LW5hdC5jCTcgT2N0IDIwMTEgMTI6MDY6NDYgLTAwMDAJ MS4yMTYKKysrIGxpbnV4LW5hdC5jCTExIE9jdCAyMDExIDAyOjQ0OjQ2IC0w MDAwCkBAIC01NzEsNyArNTcxLDYgQEAgc3RhdGljIHZvaWQKIGxpbnV4X2No aWxkX3Bvc3RfYXR0YWNoIChpbnQgcGlkKQogewogICBsaW51eF9lbmFibGVf ZXZlbnRfcmVwb3J0aW5nIChwaWRfdG9fcHRpZCAocGlkKSk7Ci0gIGNoZWNr X2Zvcl90aHJlYWRfZGIgKCk7CiAgIGxpbnV4X2VuYWJsZV90cmFjZXN5c2dv b2QgKHBpZF90b19wdGlkIChwaWQpKTsKIH0KIApAQCAtNTc5LDcgKzU3OCw2 IEBAIHN0YXRpYyB2b2lkCiBsaW51eF9jaGlsZF9wb3N0X3N0YXJ0dXBfaW5m ZXJpb3IgKHB0aWRfdCBwdGlkKQogewogICBsaW51eF9lbmFibGVfZXZlbnRf cmVwb3J0aW5nIChwdGlkKTsKLSAgY2hlY2tfZm9yX3RocmVhZF9kYiAoKTsK ICAgbGludXhfZW5hYmxlX3RyYWNlc3lzZ29vZCAocHRpZCk7CiB9CiAKSW5k ZXg6IGxpbnV4LXRocmVhZC1kYi5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvbGludXgtdGhyZWFkLWRiLmMs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOTEKZGlmZiAtdSAtcCAtcjEuOTEg bGludXgtdGhyZWFkLWRiLmMKLS0tIGxpbnV4LXRocmVhZC1kYi5jCTEzIFNl cCAyMDExIDE5OjI3OjAxIC0wMDAwCTEuOTEKKysrIGxpbnV4LXRocmVhZC1k Yi5jCTExIE9jdCAyMDExIDAyOjQ0OjQ2IC0wMDAwCkBAIC0xMDc3LDE2ICsx MDc3LDM3IEBAIGNoZWNrX2Zvcl90aHJlYWRfZGIgKHZvaWQpCiAgICAgcmV0 dXJuOwogfQogCisvKiBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB2aWEgdGhl IG5ld19vYmpmaWxlIG9ic2VydmVyLiAgKi8KKwogc3RhdGljIHZvaWQKIHRo cmVhZF9kYl9uZXdfb2JqZmlsZSAoc3RydWN0IG9iamZpbGUgKm9iamZpbGUp CiB7CiAgIC8qIFRoaXMgb2JzZXJ2ZXIgbXVzdCBhbHdheXMgYmUgY2FsbGVk IHdpdGggaW5mZXJpb3JfcHRpZCBzZXQKICAgICAgY29ycmVjdGx5LiAgKi8K IAotICBpZiAob2JqZmlsZSAhPSBOVUxMKQorICBpZiAob2JqZmlsZSAhPSBO VUxMCisgICAgICAvKiBPbmx5IGNoZWNrIGZvciB0aHJlYWRfZGIgaWYgd2Ug bG9hZGVkIGxpYnB0aHJlYWQsCisJIG9yIGlmIHRoaXMgaXMgdGhlIG1haW4g c3ltYm9sIGZpbGUuCisJIFdlIG5lZWQgdG8gY2hlY2sgT0JKRl9NQUlOTElO RSB0byBoYW5kbGUgdGhlIGNhc2Ugb2YgZGVidWdnaW5nCisJIGEgc3RhdGlj YWxseSBsaW5rZWQgZXhlY3V0YWJsZSBBTkQgdGhlIHN5bWJvbCBmaWxlIGlz IHNwZWNpZmllZCBBRlRFUgorCSB0aGUgY29yZSBmaWxlIGlzIGxvYWRlZCAo ZS5nLiwgZ2RiIC1jIGNvcmUgOyBmaWxlIGZvbykuCisJIEZvciBkeW5hbWlj YWxseSBsaW5rZWQgZXhlY3V0YWJsZXMsIGxpYnB0aHJlYWQgY2FuIGJlIG5l YXIgdGhlIGVuZAorCSBvZiB0aGUgbGlzdCBvZiBzaGFyZWQgbGlicmFyaWVz IHRvIGxvYWQsIGFuZCBpbiBhbiBhcHAgb2Ygc2V2ZXJhbAorCSB0aG91c2Fu ZCBzaGFyZWQgbGlicmFyaWVzLCB0aGlzIGNhbiBvdGhlcndpc2UgYmUgcGFp bmZ1bC4gICovCisgICAgICAmJiAoKG9iamZpbGUtPmZsYWdzICYgT0JKRl9N QUlOTElORSkgIT0gMAorCSAgfHwgbGlicHRocmVhZF9uYW1lX3AgKG9iamZp bGUtPm5hbWUpKSkKICAgICBjaGVja19mb3JfdGhyZWFkX2RiICgpOwogfQog CisvKiBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB2aWEgdGhlIGluZmVyaW9y X2NyZWF0ZWQgb2JzZXJ2ZXIuCisgICBUaGlzIGhhbmRsZXMgdGhlIGNhc2Ug b2YgZGVidWdnaW5nIHN0YXRpY2FsbHkgbGlua2VkIGV4ZWN1dGFibGVzLiAg Ki8KKworc3RhdGljIHZvaWQKK3RocmVhZF9kYl9pbmZlcmlvcl9jcmVhdGVk IChzdHJ1Y3QgdGFyZ2V0X29wcyAqdGFyZ2V0LCBpbnQgZnJvbV90dHkpCit7 CisgIGNoZWNrX2Zvcl90aHJlYWRfZGIgKCk7Cit9CisKIC8qIEF0dGFjaCB0 byBhIG5ldyB0aHJlYWQuICBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB3aGVu IHdlIHJlY2VpdmUgYQogICAgVERfQ1JFQVRFIGV2ZW50IG9yIHdoZW4gd2Ug aXRlcmF0ZSBvdmVyIGFsbCB0aHJlYWRzIGFuZCBmaW5kIG9uZQogICAgdGhh dCB3YXNuJ3QgYWxyZWFkeSBpbiBvdXIgbGlzdC4gIFJldHVybnMgdHJ1ZSBv biBzdWNjZXNzLiAgKi8KQEAgLTE4NDUsNCArMTg2Niw5IEBAIFdoZW4gbm9u LXplcm8sIGxpYnRocmVhZC1kYiBkZWJ1Z2dpbmcgaXMKIAogICAvKiBBZGQg b3Vyc2VsdmVzIHRvIG9iamZpbGUgZXZlbnQgY2hhaW4uICAqLwogICBvYnNl cnZlcl9hdHRhY2hfbmV3X29iamZpbGUgKHRocmVhZF9kYl9uZXdfb2JqZmls ZSk7CisKKyAgLyogQWRkIG91cnNlbHZlcyB0byBpbmZlcmlvcl9jcmVhdGVk IGV2ZW50IGNoYWluLgorICAgICBUaGlzIGlzIG5lZWRlZCB0byBoYW5kbGUg ZGVidWdnaW5nIHN0YXRpY2FsbHkgbGlua2VkIHByb2dyYW1zIHdoZXJlCisg ICAgIHRoZSBuZXdfb2JqZmlsZSBvYnNlcnZlciB3b24ndCBnZXQgY2FsbGVk IGZvciBsaWJwdGhyZWFkLiAgKi8KKyAgb2JzZXJ2ZXJfYXR0YWNoX2luZmVy aW9yX2NyZWF0ZWQgKHRocmVhZF9kYl9pbmZlcmlvcl9jcmVhdGVkKTsKIH0K SW5kZXg6IG9iamZpbGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5oLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjg1CmRpZmYgLXUgLXAgLXIxLjg1IG9iamZpbGVzLmgK LS0tIG9iamZpbGVzLmgJMTQgSnVuIDIwMTEgMTY6NDk6NDEgLTAwMDAJMS44 NQorKysgb2JqZmlsZXMuaAkxMSBPY3QgMjAxMSAwMjo0NDo0NiAtMDAwMApA QCAtMTk2LDcgKzE5Niw4IEBAIHN0cnVjdCBvYmpmaWxlCiAKICAgICBDT1JF X0FERFIgYWRkcl9sb3c7CiAKLSAgICAvKiBTb21lIGZsYWcgYml0cyBmb3Ig dGhpcyBvYmpmaWxlLiAgKi8KKyAgICAvKiBTb21lIGZsYWcgYml0cyBmb3Ig dGhpcyBvYmpmaWxlLgorICAgICAgIFRoZSB2YWx1ZXMgYXJlIGRlZmluZWQg YnkgT0JKRl8qLiAgKi8KIAogICAgIHVuc2lnbmVkIHNob3J0IGZsYWdzOwog CkBAIC00MzQsNiArNDM1LDExIEBAIHN0cnVjdCBvYmpmaWxlCiAKICNkZWZp bmUgT0JKRl9QU1lNVEFCU19SRUFEICgxIDw8IDQpCiAKKy8qIFNldCBpZiB0 aGlzIGlzIHRoZSBtYWluIHN5bWJvbCBmaWxlCisgICAoYXMgb3Bwb3NlZCB0 byBzeW1ib2wgZmlsZSBmb3IgZHluYW1pY2FsbHkgbG9hZGVkIGNvZGUpLiAg Ki8KKworI2RlZmluZSBPQkpGX01BSU5MSU5FICgxIDw8IDUpCisKIC8qIFRo ZSBvYmplY3QgZmlsZSB0aGF0IGNvbnRhaW5zIHRoZSBydW50aW1lIGNvbW1v biBtaW5pbWFsIHN5bWJvbHMKICAgIGZvciBTdW5PUzQuICBOb3RlIHRoYXQg dGhpcyBvYmpmaWxlIGhhcyBubyBhc3NvY2lhdGVkIEJGRC4gICovCiAKSW5k ZXg6IHN5bWZpbGUuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3NyYy9zcmMvZ2RiL3N5bWZpbGUuYyx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4zMTYKZGlmZiAtdSAtcCAtcjEuMzE2IHN5bWZpbGUuYwotLS0g c3ltZmlsZS5jCTI5IFNlcCAyMDExIDAyOjA0OjI1IC0wMDAwCTEuMzE2Cisr KyBzeW1maWxlLmMJMTEgT2N0IDIwMTEgMDI6NDQ6NDYgLTAwMDAKQEAgLTEw ODEsNiArMTA4MSw3IEBAIHN5bWJvbF9maWxlX2FkZF93aXRoX2FkZHJzX29y X29mZnNldHMgKGIKICAgc3RydWN0IGNsZWFudXAgKm15X2NsZWFudXBzOwog ICBjb25zdCBjaGFyICpuYW1lID0gYmZkX2dldF9maWxlbmFtZSAoYWJmZCk7 CiAgIGNvbnN0IGludCBmcm9tX3R0eSA9IGFkZF9mbGFncyAmIFNZTUZJTEVf VkVSQk9TRTsKKyAgY29uc3QgaW50IG1haW5saW5lID0gYWRkX2ZsYWdzICYg U1lNRklMRV9NQUlOTElORTsKICAgY29uc3QgaW50IHNob3VsZF9wcmludCA9 ICgoZnJvbV90dHkgfHwgaW5mb192ZXJib3NlKQogCQkJICAgICYmIChyZWFk bm93X3N5bWJvbF9maWxlcwogCQkJCXx8IChhZGRfZmxhZ3MgJiBTWU1GSUxF X05PX1JFQUQpID09IDApKTsKQEAgLTEwOTcsMTIgKzEwOTgsMTIgQEAgc3lt Ym9sX2ZpbGVfYWRkX3dpdGhfYWRkcnNfb3Jfb2Zmc2V0cyAoYgogICAgICBp bnRlcmFjdGl2ZWx5IHdpcGluZyBvdXQgYW55IGV4aXN0aW5nIHN5bWJvbHMu ICAqLwogCiAgIGlmICgoaGF2ZV9mdWxsX3N5bWJvbHMgKCkgfHwgaGF2ZV9w YXJ0aWFsX3N5bWJvbHMgKCkpCi0gICAgICAmJiAoYWRkX2ZsYWdzICYgU1lN RklMRV9NQUlOTElORSkKKyAgICAgICYmIG1haW5saW5lCiAgICAgICAmJiBm cm9tX3R0eQogICAgICAgJiYgIXF1ZXJ5IChfKCJMb2FkIG5ldyBzeW1ib2wg dGFibGUgZnJvbSBcIiVzXCI/ICIpLCBuYW1lKSkKICAgICBlcnJvciAoXygi Tm90IGNvbmZpcm1lZC4iKSk7CiAKLSAgb2JqZmlsZSA9IGFsbG9jYXRlX29i amZpbGUgKGFiZmQsIGZsYWdzKTsKKyAgb2JqZmlsZSA9IGFsbG9jYXRlX29i amZpbGUgKGFiZmQsIGZsYWdzIHwgKG1haW5saW5lID8gT0JKRl9NQUlOTElO RSA6IDApKTsKICAgZGlzY2FyZF9jbGVhbnVwcyAobXlfY2xlYW51cHMpOwog CiAgIGlmIChwYXJlbnQpCg== --bcaec517aba8f07cb304aefda362--