From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121351-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 59964 invoked by alias); 30 Mar 2015 20:00:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 59946 invoked by uid 89); 30 Mar 2015 20:00:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-ig0-f177.google.com
Received: from mail-ig0-f177.google.com (HELO mail-ig0-f177.google.com) (209.85.213.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 30 Mar 2015 20:00:27 +0000
Received: by igcxg11 with SMTP id xg11so394968igc.0        for <gdb-patches@sourceware.org>; Mon, 30 Mar 2015 13:00:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=IYibvGQ6B05yUHDzmbGRsvQkxwJEEu1eMJyA3U4SJP0=;        b=ZNT/zMrvda9hwHl412eOB3nvXlkVzdmFDLVTC6DhE5KYg0oAjXE0+tkyAydpHGMZUq         RXof0Bw17mvMTv+ugc3ZYLSa3hS0gKmZLBcdAaWUzRQPDmJl/wax2RHdQcLsGajKCJ8A         +euO+H9UTzwyPBfF45WHAK7w9XUuCK3qmBHygye+JcDRaPLSEbeiV1hIbJrt1sPP4yMQ         bfRqQ70EpPuUgkjZQVYiQ4n40TnC+6kN6xUIPk7uBCU/83/QdkRMrENDIMZLKygzO59O         /QJkp86Tz76OxTHIFHtyZwJEC+o2mjy8LcgezhoC05fs6EtKb/20aqy352+EQXf/s5ng         KpSg==
X-Gm-Message-State: ALoCoQlpeIP6nHhk8QXVZVZGwVLPOjlwQA9gbuRDdKJDf6ALneBuRhNBz+WayINpa6aQfbBI8IYc
MIME-Version: 1.0
X-Received: by 10.60.77.38 with SMTP id p6mr24280847oew.75.1427745625210; Mon, 30 Mar 2015 13:00:25 -0700 (PDT)
Received: by 10.182.142.226 with HTTP; Mon, 30 Mar 2015 13:00:25 -0700 (PDT)
In-Reply-To: <87pp7qjmh8.fsf@redhat.com>
References: <87619mkpil.fsf@redhat.com>	<21785.37797.271814.469027@ruffy2.mtv.corp.google.com>	<87pp7qjmh8.fsf@redhat.com>
Date: Mon, 30 Mar 2015 20:00:00 -0000
Message-ID: <CADPb22SDy71D4jcqV_wzwtc7vX-8P9YnDO69jrOQxPKRLn2GsQ@mail.gmail.com>
Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
From: Doug Evans <dje@google.com>
To: Petr Machata <pmachata@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg01015.txt.bz2

On Mon, Mar 30, 2015 at 12:48 PM, Petr Machata <pmachata@redhat.com> wrote:
> Doug Evans <dje@google.com> writes:
>
>>  > +  if { "$label" != "" } {
>>  > +      $label:
>>  > +  }
>>
>> Should this be:
>>
>>       if { "$label" != "" } {
>>           _emit "$label:"
>>       }
>
> No, it's calling the function named "$label:".  To define the label that
> the user supplied.  Would this make it clearer?
>
> --- a/gdb/testsuite/lib/dwarf.exp
> +++ b/gdb/testsuite/lib/dwarf.exp
> @@ -1165,6 +1165,7 @@ namespace eval Dwarf {
>         _section $section
>
>         if { "$label" != "" } {
> +           # Define the user-provided label at this point.
>             $label:
>         }
>
>
> Thanks,
> Petr

That helps enough.
Thanks.