From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22879 invoked by alias); 6 Jun 2013 19:03:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22829 invoked by uid 89); 6 Jun 2013 19:03:19 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 06 Jun 2013 19:03:16 +0000 Received: by mail-vc0-f171.google.com with SMTP id m16so2290824vca.30 for ; Thu, 06 Jun 2013 12:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=w0Z7iiCtvvog7oGmtRvLQkrsUNND6YKueA2U5Z84GWg=; b=Dkc0JjxjHxGMuFuEFoFROaVnA59rQ2mYwU/kuK5ZjAjh/UBI5xMPdFsVBTCfYLItwP HoytJFKNS1nGv7laGgTCCD6HcgW1hGF7Hw6AlpOdA8Sf6sIxOvT0VRbnjZgnvLPIra0W KrC8fw0pmhhqwTRjl4VS2499f5jJ72r4aeE/wDZMX1j2FixfM+NkkH3gtOoUbtfAMgaI hFk9s6O50TA064DUbNszuWY/OXCohoAT9QpamknKYDKF0SVei+kGA8KBUEz7EGXgKd9R kl0wXfSoaMA0hf5sbyJ5eSG1DMjzTnloMIwzYRzKYUOqcpLjQYrklTWx+RZ6sRPwJ2NO eTTQ== MIME-Version: 1.0 X-Received: by 10.52.231.36 with SMTP id td4mr19157776vdc.92.1370545394308; Thu, 06 Jun 2013 12:03:14 -0700 (PDT) Received: by 10.220.189.74 with HTTP; Thu, 6 Jun 2013 12:03:14 -0700 (PDT) In-Reply-To: <51B06201.7010507@redhat.com> References: <20903.57436.871210.593441@ruffy.mtv.corp.google.com> <51A86FF5.9090401@redhat.com> <20905.9501.800725.439795@ruffy.mtv.corp.google.com> <51ACD207.2000402@redhat.com> <51B06201.7010507@redhat.com> Date: Thu, 06 Jun 2013 19:03:00 -0000 Message-ID: Subject: Re: [patch] Improve symbol lookup performance noted in PR 15519 From: Doug Evans To: Pedro Alves Cc: Keith Seitz , Joel Brobecker , psmith@gnu.org, gdb-patches Content-Type: multipart/mixed; boundary=089e011849c660a75704de80f73b X-Gm-Message-State: ALoCoQnpYNDR7qUBeo/lswF/AuD+iVckH2OyfsJg+SUUevlW8fozkeo6ENXbSNYw++wyN0POvC0Jt6BNsTD+LR8ehIk5atVnFJDcRqmjOKWA+u+KTNN+2QVe9m95J39FFPpO/MK9G+z7in6im9l+Vvm5FCF/HNcJEkNPYMcMdg1tQkfgrUdQ9KAyStKJgCxOJpBGnZ6UvjZ/WNUDgUFVz1u537FhoAeGHQ== X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00130.txt.bz2 --089e011849c660a75704de80f73b Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1594 On Thu, Jun 6, 2013 at 3:18 AM, Pedro Alves wrote: >> # Check inheritance of typedefs. >> -foreach klass {"A" "D" "E" "F"} { >> +foreach klass {"A" "D" "E" "F" "A2" "D2"} { >> gdb_test "ptype ${klass}::value_type" "type = int" >> gdb_test "whatis ${klass}::value_type" "type = int" >> gdb_test "p (${klass}::value_type) 0" " = 0" >> @@ -57,6 +58,13 @@ if ![runto 'marker1'] then { >> continue >> } >> >> +# Check inheritance of typedefs again, but this time with an active block. >> +foreach klass {"A" "D" "A2" "D2"} { >> + gdb_test "ptype ${klass}::value_type" "type = int" >> + gdb_test "whatis ${klass}::value_type" "type = int" >> + gdb_test "p (${klass}::value_type) 0" " = 0" >> +} >> + > > Looks like this will create duplicate messages in gdb.sum. > Could you use with_test_prefix to make them unique please? Fixed. >> # Print class types and values. >> Index: testsuite/gdb.cp/derivation2.cc >> =================================================================== >> RCS file: testsuite/gdb.cp/derivation2.cc >> diff -N testsuite/gdb.cp/derivation2.cc >> --- /dev/null 1 Jan 1970 00:00:00 -0000 >> +++ testsuite/gdb.cp/derivation2.cc 5 Jun 2013 22:21:18 -0000 >> @@ -0,0 +1,49 @@ > ... >> + You should have received a copy of the GNU General Public License >> + along with this program. If not, see . >> + */ > > (this placement for */ looks a little odd.) Cut-n-paste from derivation.cc. bash$ grep "^ *[*]/$" testsuite/*/*.* | wc 277 482 7364 I'm not going to worry about it. --089e011849c660a75704de80f73b Content-Type: text/plain; charset=US-ASCII; name="gdb-130606-derivation-test-names-1.patch.txt" Content-Disposition: attachment; filename="gdb-130606-derivation-test-names-1.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hhmbbn5d0 Content-length: 2794 MjAxMy0wNi0wNiAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog Z2RiLmNwL2Rlcml2YXRpb24uZXhwOiBNYWtlIHRlc3RzIGhhdmUgdW5pcXVl IG5hbWVzLgoKSW5kZXg6IGdkYi5jcC9kZXJpdmF0aW9uLmV4cAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3Rl c3RzdWl0ZS9nZGIuY3AvZGVyaXZhdGlvbi5leHAsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMjUKZGlmZiAtdSAtcCAtcjEuMjUgZGVyaXZhdGlvbi5leHAK LS0tIGdkYi5jcC9kZXJpdmF0aW9uLmV4cAk1IEp1biAyMDEzIDIyOjI4OjUx IC0wMDAwCTEuMjUKKysrIGdkYi5jcC9kZXJpdmF0aW9uLmV4cAk2IEp1biAy MDEzIDE4OjU5OjM1IC0wMDAwCkBAIC00MCwxNSArNDAsMTcgQEAgaWYge1tw cmVwYXJlX2Zvcl90ZXN0aW5nICR0ZXN0ZmlsZS5leHAgJAogfQogCiAjIENo ZWNrIGluaGVyaXRhbmNlIG9mIHR5cGVkZWZzLgotZm9yZWFjaCBrbGFzcyB7 IkEiICJEIiAiRSIgIkYiICJBMiIgIkQyIn0gewotICAgIGdkYl90ZXN0ICJw dHlwZSAke2tsYXNzfTo6dmFsdWVfdHlwZSIgInR5cGUgPSBpbnQiCi0gICAg Z2RiX3Rlc3QgIndoYXRpcyAke2tsYXNzfTo6dmFsdWVfdHlwZSIgInR5cGUg PSBpbnQiCi0gICAgZ2RiX3Rlc3QgInAgKCR7a2xhc3N9Ojp2YWx1ZV90eXBl KSAwIiAiID0gMCIKLX0KLWZvcmVhY2gga2xhc3MgeyJaIiAiWloifSB7Ci0g ICAgZ2RiX3Rlc3QgInB0eXBlICR7a2xhc3N9Ojp2YWx1ZV90eXBlIiAidHlw ZSA9IGZsb2F0IgotICAgIGdkYl90ZXN0ICJ3aGF0aXMgJHtrbGFzc306OnZh bHVlX3R5cGUiICJ0eXBlID0gZmxvYXQiCi0gICAgZ2RiX3Rlc3QgInAgKCR7 a2xhc3N9Ojp2YWx1ZV90eXBlKSAwIiAiID0gMCIKK3dpdGhfdGVzdF9wcmVm aXggImJlZm9yZSBydW4iIHsKKyAgICBmb3JlYWNoIGtsYXNzIHsiQSIgIkQi ICJFIiAiRiIgIkEyIiAiRDIifSB7CisJZ2RiX3Rlc3QgInB0eXBlICR7a2xh c3N9Ojp2YWx1ZV90eXBlIiAidHlwZSA9IGludCIKKwlnZGJfdGVzdCAid2hh dGlzICR7a2xhc3N9Ojp2YWx1ZV90eXBlIiAidHlwZSA9IGludCIKKwlnZGJf dGVzdCAicCAoJHtrbGFzc306OnZhbHVlX3R5cGUpIDAiICIgPSAwIgorICAg IH0KKyAgICBmb3JlYWNoIGtsYXNzIHsiWiIgIlpaIn0geworCWdkYl90ZXN0 ICJwdHlwZSAke2tsYXNzfTo6dmFsdWVfdHlwZSIgInR5cGUgPSBmbG9hdCIK KwlnZGJfdGVzdCAid2hhdGlzICR7a2xhc3N9Ojp2YWx1ZV90eXBlIiAidHlw ZSA9IGZsb2F0IgorCWdkYl90ZXN0ICJwICgke2tsYXNzfTo6dmFsdWVfdHlw ZSkgMCIgIiA9IDAiCisgICAgfQogfQogCiAjIFNldCBpdCB1cCBhdCBhIGJy ZWFrcG9pbnQgc28gd2UgY2FuIHBsYXkgd2l0aCB0aGUgdmFyaWFibGUgdmFs dWVzLgpAQCAtNTksMTAgKzYxLDEyIEBAIGlmICFbcnVudG8gJ21hcmtlcjEn XSB0aGVuIHsKIH0KIAogIyBDaGVjayBpbmhlcml0YW5jZSBvZiB0eXBlZGVm cyBhZ2FpbiwgYnV0IHRoaXMgdGltZSB3aXRoIGFuIGFjdGl2ZSBibG9jay4K LWZvcmVhY2gga2xhc3MgeyJBIiAiRCIgIkEyIiAiRDIifSB7Ci0gICAgZ2Ri X3Rlc3QgInB0eXBlICR7a2xhc3N9Ojp2YWx1ZV90eXBlIiAidHlwZSA9IGlu dCIKLSAgICBnZGJfdGVzdCAid2hhdGlzICR7a2xhc3N9Ojp2YWx1ZV90eXBl IiAidHlwZSA9IGludCIKLSAgICBnZGJfdGVzdCAicCAoJHtrbGFzc306OnZh bHVlX3R5cGUpIDAiICIgPSAwIgord2l0aF90ZXN0X3ByZWZpeCAiYXQgbWFy a2VyMSIgeworICAgIGZvcmVhY2gga2xhc3MgeyJBIiAiRCIgIkEyIiAiRDIi fSB7CisJZ2RiX3Rlc3QgInB0eXBlICR7a2xhc3N9Ojp2YWx1ZV90eXBlIiAi dHlwZSA9IGludCIKKwlnZGJfdGVzdCAid2hhdGlzICR7a2xhc3N9Ojp2YWx1 ZV90eXBlIiAidHlwZSA9IGludCIKKwlnZGJfdGVzdCAicCAoJHtrbGFzc306 OnZhbHVlX3R5cGUpIDAiICIgPSAwIgorICAgIH0KIH0KIAogZ2RiX3Rlc3Qg InVwIiAiLiptYWluLioiICJ1cCBmcm9tIG1hcmtlcjEiCg== --089e011849c660a75704de80f73b--