Re: [PATCH, doc RFA] Rename maint/set-debug "dwarf2" commands to "dwarf"

Doug Evans
2015-05-26T23:56:54Z

On Tue, May 12, 2015 at 5:11 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch renames the user-visible uses of "dwarf2" to "dwarf".
> It's triggered by the discussion here:
> https://sourceware.org/ml/gdb-patches/2015-05/msg00286.html
>
> These are just maint/set-debug commands so we are free to change them.
>
> The history here is that way back when dwarf v2 support was added it was
> sufficiently different than dwarf1 (and, at the time, new),
> and (IIUC) radically different enough from dwarf v1 that people wanted
> to distinguish dwarf2 from dwarf1 and presumably support both.
>
> These days there is only "dwarf2", dwarf1 is long gone.
> And by "dwarf2" I mean the basic file format changes that
> distinguished it from dwarf1. In the sources wherever you
> see "dwarf2" the "2" has (generally) nothing to do with the DWARF
> version (2,3,4,5,...), and has only to do with the difference
> between dwarf1 and dwarf2.
> These days "dwarf2" is no longer a useful distinction and is now
> in fact confusing to people not familiar with this history.
>
> Regression tested on amd64-linux.
>
> Future patches can do further renamings, e.g., replace
> dw2_foo/dwarf2_foo with dw_foo/dwarf_foo, but that's
> a big task, and can be deferred.
>
> 2015-05-12 Doug Evans <dje@google.com>
>
> * NEWS: Add entries for command renamings.
> * dwarf2read.c (dwarf_read_debug): Renamed from dwarf2_read_debug.
> All uses updated.
> (dwarf_die_debug): Renamed from dwarf2_die_debug. All uses updated.
> (dwarf_max_cache_age): Renamed from dwarf2_max_cache_age.
> All uses updated.
> (show_dwarf_max_cache_age): Renamed from show_dwarf2_max_cache_age.
> All callers updated. Fix spelling of DWARF in help text.
> (set_dwarf_cmdlist): Renamed from set_dwarf2_cmdlist.
> All uses updated.
> (show_dwarf_cmdlist): Renamed from show_dwarf2_cmdlist.
> All uses updated.
> (set_dwarf_cmd): Renamed from set_dwarf2_cmd. All callers updated.
> (show_dwarf_cmd): Renamed from show_dwarf2_cmd. All callers
> updated.
> (dwarf_always_disassemble): Renamed from dwarf_always_disassemble.
> All uses updated.
> (show_dwarf_always_disassemble): Renamed from
> show_dwarf2_always_disassemble. All callers updated.
> (_initialize_dwarf2_read): Rename "set/show dwarf2" prefix to
> "set/show dwarf". Rename "set/show dwarf2 max-cache-age" to
> "set/show dwarf max-cache-age". Rename
> "set/show dwarf2 always-disassemble" to
> "set/show dwarf always-disassemble". Rename
> "set/show debug dwarf2-read" to "set/show debug dwarf-read". Rename
> "set/show debug dwarf2-die" to "set/show debug dwarf-die".
>
> doc/
> * gdb.texinfo (Debugging Output): Update for DWARF "set debug"
> command renamings.
> (Maintenance Commands): Update for DWARF "set debug" command
> renamings.
>
> testsuite/
> * gdb.dwarf2/dw2-op-call.exp: Update.
> * gdb.dwarf2/dw4-sig-types.exp: Update.
> * gdb.dwarf2/implptr.exp: Update.
> * gdb.mi/mi-cmd-param-changed.exp: Update.

Committed.