From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28217 invoked by alias); 17 Jul 2012 22:10:57 -0000 Received: (qmail 28209 invoked by uid 22791); 17 Jul 2012 22:10:56 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jul 2012 22:10:43 +0000 Received: by vcbfl10 with SMTP id fl10so825696vcb.0 for ; Tue, 17 Jul 2012 15:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=5W8JnFTaDmXNxdbh4WriV7uHF+3l/kp6bscG2qWpHsk=; b=STNIiCOVblSoz1ggbms4lQgs1tea1QDIW6hqaV8XDiRqnXRLL+M8jsJex1DZ9R/aEv qirZoU6kqS4I06h9A9s3x27TtWFC40h2lbl92MZXaEXr5VJwzmGzfhk/IlBAaPMx/wkM hj1e3zikBKdTobaN9o9Taf23GH7m7ht7nAGeFlDgD5CfjaNXxVsDFarOkLc4tyH7OxTf XMXi8bf0skudD3ej3EUiKiPMaODmD8O/tDkFHOsSQtdBN8PppwfzU1mC6szswEowqCPw fLLCGlpDx71FYEA4/gXlHqPZBYsI+76KY8F/cS0qkPONEI7Oi2KZfBbrFeTV/QFm7Xhv JBHg== Received: by 10.52.90.144 with SMTP id bw16mr1745919vdb.129.1342563042931; Tue, 17 Jul 2012 15:10:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.90.144 with SMTP id bw16mr1745911vdb.129.1342563042709; Tue, 17 Jul 2012 15:10:42 -0700 (PDT) Received: by 10.52.157.4 with HTTP; Tue, 17 Jul 2012 15:10:42 -0700 (PDT) In-Reply-To: <20120717214257.GA9394@host2.jankratochvil.net> References: <20120717214257.GA9394@host2.jankratochvil.net> Date: Tue, 17 Jul 2012 22:10:00 -0000 Message-ID: Subject: Re: [RFA, doc RFA] New option set use-deprecated-index-sections From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQmDAM0IjZtXwZ/8NCTT6BmqUMmDW31nDM9n6Mcy6GalGU7jEnimw7OFWqRJptYrxtafOI5dtlkp5oeBeezh5cl59Wib3LPgl4C/h9/wDlQxXqNpkPuDSbZoHw3CTKyXy5nZEjTcw6Ty9xX6e6a5IHMwQzjnGpbFi/V7GSwCYTEVL/UfSfQ26/MA6aK8wHijZ3Pss9ey X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00247.txt.bz2 On Tue, Jul 17, 2012 at 2:42 PM, Jan Kratochvil wrote: > On Tue, 17 Jul 2012 23:23:51 +0200, dje@google.com wrote: >> I was going to wait to apply this until after 7.5, >> but with the new "-iex" option I realize that the new >> "--use-deprecated-index-sections" option could be considered redundant. >> So I'm thinking about deleting that as well, in favor of having just this. > > I would find less GDB options to be good. > > >> +@item set use-deprecated-index-sections >> +@kindex set use-deprecated-index-sections >> +Set this option to control the treatment of deprecated index sections. >> +When @code{on}, index sections are used even if they are deprecated. > >> +When @code{off}, only current versions of index sections are used. >> +The default is @code{off}. > > This is not completely correct: > if (version < 6 && !use_deprecated_index_sections) > if (version > 7) I chose the word "current" to include handling this case (i.e. "current" wasn't intended to convey "latest". Rather, it was intended to convey "not-deprecated" and avoid going into a whole lot of extra verbiage). No disagreement that it could be worded better of course. > So version 6 is not "current" but it is still used even without > -use-deprecated-index-sections. At least gdb doc should be exact IMO. > > It is also questionable if version 6 should be ignored without > -use-deprecated-index-sections. I guess the possible performance regression > (against non-index case) is so rare it was not worth ignoring version 6. > > > Thanks, > Jan