From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1192 invoked by alias); 29 Apr 2012 23:21:34 -0000 Received: (qmail 1174 invoked by uid 22791); 29 Apr 2012 23:21:33 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 29 Apr 2012 23:21:19 +0000 Received: by vcbfy7 with SMTP id fy7so2108133vcb.0 for ; Sun, 29 Apr 2012 16:21:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=fScM+sICmw9zt7rinwav+Zn69KosliMeGTmBj7PIor0=; b=Mrg7VzwLkWzDrflCNaJzfmsDa8WqOXxmiDXAUb1URPFnuqvtmolnbD6y+8EAYorT3t OI47xpdqLeLEIOI7XdyY0O6Y4hNW4PQq3VgalMwpCoETfoWCS5HP7Zr019PdrCKYEOBf /6XmD79qmb1osY1EGG9iikmOFDPlmkikMWR/oVMRXZkCX+zzkprI2sKHc+nIHtKYlg0/ GFvmvGr+i1vGaAzGO4+YApuKxXsTHsR9/880bw5eoYzNFgp7LsFspkh9BDBd8bPJ81lG OzPKdcxxDysmRFceEimL2x4ymkvipMngQsYFex+fJL2Zn+MS7FsBkdce1JMwR5nmbNSS OAaQ== Received: by 10.52.67.106 with SMTP id m10mr10698750vdt.6.1335741678929; Sun, 29 Apr 2012 16:21:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.67.106 with SMTP id m10mr10698736vdt.6.1335741678649; Sun, 29 Apr 2012 16:21:18 -0700 (PDT) Received: by 10.52.165.2 with HTTP; Sun, 29 Apr 2012 16:21:18 -0700 (PDT) In-Reply-To: <20120429085754.GA9548@host2.jankratochvil.net> References: <20120418185738.277DB2461AF@ruffy.mtv.corp.google.com> <20120429085754.GA9548@host2.jankratochvil.net> Date: Mon, 30 Apr 2012 00:06:00 -0000 Message-ID: Subject: Re: Crash regression for gdb.dwarf2/dw2-inheritance.exp [Re: [RFA 3/3] Initial Fission support, the actual Fission stuff] From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org, tromey@redhat.com, ccoutant@google.com, saugustine@google.com Content-Type: multipart/mixed; boundary=20cf307d021444810704bed998e6 X-System-Of-Record: true X-Gm-Message-State: ALoCoQmjUXkNs7yMHx6H/AUB73WMXz0b8CKNVlSYQsROk/UmKuKWoOsVauMa8d1u5hk86CaUI2OeIeBoXSLbf9UetbYM8bsyW+AnFfA+e0vBA0oqrmzMSiyz9f7vRnjQc4lZf57/DBLnyRPCgk+H36mZMzXaL2Noeg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01069.txt.bz2 --20cf307d021444810704bed998e6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 3002 On Sun, Apr 29, 2012 at 1:57 AM, Jan Kratochvil wrote: > On Wed, 18 Apr 2012 20:57:38 +0200, Doug Evans wrote: >> 2012-04-18 =A0Doug Evans =A0 >> >> =A0 =A0 =A0 Initial support for Fission. =A0http://gcc.gnu.org/wiki/Debu= gFission > > =A0Running gdb/testsuite/gdb.dwarf2/dw2-inheritance.exp ... > -PASS: gdb.dwarf2/dw2-inheritance.exp: ptype inherited > +ERROR: couldn't load /unsafegdb/testsuite.unix.-m32/gdb.dwarf2/dw2-inher= itance.x into /unsafegdb/testsuite.unix.-m32/../../gdb/gdb (end of file). > +ERROR: Couldn't send ptype inherited to GDB. > +UNRESOLVED: gdb.dwarf2/dw2-inheritance.exp: ptype inherited > > Program terminated with signal 11, Segmentation fault. > #0 =A00x000000000063037c in dwarf_decode_line_header (offset=3D0, cu=3D0x= 2c4b410) at dwarf2read.c:12320 > 12320 =A0 =A0 abfd =3D section->asection->owner; > (gdb) p section->asection > $2 =3D (asection *) 0x0 > (gdb) bt > #0 =A00x000000000063037c in dwarf_decode_line_header (offset=3D0, cu=3D0x= 2c4b410) at dwarf2read.c:12320 > #1 =A00x000000000061c354 in dwarf2_build_include_psymtabs (cu=3D0x2c4b410= , die=3D0x2c4b5d0, pst=3D0x2c2d810) at dwarf2read.c:3324 > #2 =A00x000000000061e46b in process_psymtab_comp_unit_reader (reader=3D0x= 7fff3fa1ac90, info_ptr=3D0x2c2d777 "\003base", comp_unit_die=3D0x2c4b5d0, h= as_children=3D1, > =A0 =A0data=3D0x0) at dwarf2read.c:4159 > #3 =A00x000000000061dc53 in init_and_read_dies_worker (this_cu=3D0x2c2d7a= 0, use_existing_cu=3D0, keep=3D0, die_reader_func=3D > =A0 =A00x61e036 , data=3D0x0) at dwarf2= read.c:3895 > #4 =A00x000000000061dd12 in init_cu_and_read_dies (this_cu=3D0x2c2d7a0, u= se_existing_cu=3D0, keep=3D0, die_reader_func=3D0x61e036 , > =A0 =A0data=3D0x0) at dwarf2read.c:3936 > #5 =A00x000000000061e4f9 in process_psymtab_comp_unit (this_cu=3D0x2c2d7a= 0) at dwarf2read.c:4178 > #6 =A00x000000000061e726 in dwarf2_build_psymtabs_hard (objfile=3D0x2c386= d0) at dwarf2read.c:4269 > #7 =A00x000000000061bca2 in dwarf2_build_psymtabs (objfile=3D0x2c386d0) a= t dwarf2read.c:3133 > #8 =A00x0000000000508db2 in read_psyms (objfile=3D0x2c386d0) at elfread.c= :1449 > #9 =A00x000000000058f9be in require_partial_symbols (objfile=3D0x2c386d0,= verbose=3D0) at psymtab.c:92 > > It happens on RHEL-6 i386/x86_68/x86_64-m32. =A0Feel free to request more= info. > > > Regards, > Jan Hi. I can't recreate this on my fc16 box (neither i386 nor amd64), but the it's easy enough to see what the issue is. Can you test this patch? Regression tested here. It also fixes a potential segv in dwarf_decode_macros. 2012-04-29 Doug Evans * dwarf2read.c (dwarf_decode_macros): New arg section_name. All callers updated. (init_cu_die_reader): Verify the section is non-empty. (dwarf_decode_line_header): Don't dereference section->asection until we know the section is present. Return NULL, not 0. --20cf307d021444810704bed998e6 Content-Type: text/plain; charset=US-ASCII; name="gdb-120429-fission-supplement-3-1.patch.txt" Content-Disposition: attachment; filename="gdb-120429-fission-supplement-3-1.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h1mq3n050 Content-length: 4856 MjAxMi0wNC0yOSAgRG91ZyBFdmFucyAgPGRqZUBzZWJhLnNlYmFiZWFjaC5v cmc+CgoJKiBkd2FyZjJyZWFkLmMgKGR3YXJmX2RlY29kZV9tYWNyb3MpOiBO ZXcgYXJnIHNlY3Rpb25fbmFtZS4KCUFsbCBjYWxsZXJzIHVwZGF0ZWQuCgko aW5pdF9jdV9kaWVfcmVhZGVyKTogVmVyaWZ5IHRoZSBzZWN0aW9uIGlzIG5v bi1lbXB0eS4KCShkd2FyZl9kZWNvZGVfbGluZV9oZWFkZXIpOiBEb24ndCBk ZXJlZmVyZW5jZSBzZWN0aW9uLT5hc2VjdGlvbgoJdW50aWwgd2Uga25vdyB0 aGUgc2VjdGlvbiBpcyBwcmVzZW50LiAgUmV0dXJuIE5VTEwsIG5vdCAwLgoK SW5kZXg6IGR3YXJmMnJlYWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2R3YXJmMnJlYWQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS42NDQKZGlmZiAtdSAtcCAtcjEuNjQ0IGR3YXJm MnJlYWQuYwotLS0gZHdhcmYycmVhZC5jCTI4IEFwciAyMDEyIDIzOjIyOjEz IC0wMDAwCTEuNjQ0CisrKyBkd2FyZjJyZWFkLmMJMjkgQXByIDIwMTIgMjI6 MTM6MTYgLTAwMDAKQEAgLTEzMTcsNyArMTMxNyw3IEBAIHN0YXRpYyBzdHJ1 Y3QgZGllX2luZm8gKmR3YXJmX2FsbG9jX2RpZSAKIHN0YXRpYyB2b2lkIGR3 YXJmX2RlY29kZV9tYWNyb3MgKHN0cnVjdCBsaW5lX2hlYWRlciAqLCB1bnNp Z25lZCBpbnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj aGFyICosIGJmZCAqLCBzdHJ1Y3QgZHdhcmYyX2N1ICosCiAJCQkJIHN0cnVj dCBkd2FyZjJfc2VjdGlvbl9pbmZvICosCi0JCQkJIGludCk7CisJCQkJIGlu dCwgY29uc3QgY2hhciAqKTsKIAogc3RhdGljIGludCBhdHRyX2Zvcm1faXNf YmxvY2sgKHN0cnVjdCBhdHRyaWJ1dGUgKik7CiAKQEAgLTE2NzEsNyArMTY3 MSw4IEBAIHpsaWJfZGVjb21wcmVzc19zZWN0aW9uIChzdHJ1Y3Qgb2JqZmls ZSAKICNlbmRpZgogfQogCi0vKiBBIGhlbHBlciBmdW5jdGlvbiB0aGF0IGRl Y2lkZXMgd2hldGhlciBhIHNlY3Rpb24gaXMgZW1wdHkuICAqLworLyogQSBo ZWxwZXIgZnVuY3Rpb24gdGhhdCBkZWNpZGVzIHdoZXRoZXIgYSBzZWN0aW9u IGlzIGVtcHR5LAorICAgb3Igbm90IHByZXNlbnQuICAqLwogCiBzdGF0aWMg aW50CiBkd2FyZjJfc2VjdGlvbl9lbXB0eV9wIChzdHJ1Y3QgZHdhcmYyX3Nl Y3Rpb25faW5mbyAqaW5mbykKQEAgLTM1ODgsNyArMzU4OSw3IEBAIGluaXRf Y3VfZGllX3JlYWRlciAoc3RydWN0IGRpZV9yZWFkZXJfc3AKIAkJICAgIHN0 cnVjdCBkd2FyZjJfc2VjdGlvbl9pbmZvICpzZWN0aW9uLAogCQkgICAgc3Ry dWN0IGR3b19maWxlICpkd29fZmlsZSkKIHsKLSAgZ2RiX2Fzc2VydCAoc2Vj dGlvbi0+cmVhZGluKTsKKyAgZ2RiX2Fzc2VydCAoc2VjdGlvbi0+cmVhZGlu ICYmIHNlY3Rpb24tPmJ1ZmZlciAhPSBOVUxMKTsKICAgcmVhZGVyLT5hYmZk ID0gc2VjdGlvbi0+YXNlY3Rpb24tPm93bmVyOwogICByZWFkZXItPmN1ID0g Y3U7CiAgIHJlYWRlci0+ZHdvX2ZpbGUgPSBkd29fZmlsZTsKQEAgLTYzNTQs NyArNjM1NSw4IEBAIHJlYWRfZmlsZV9zY29wZSAoc3RydWN0IGRpZV9pbmZv ICpkaWUsIHMKIAogICAgICAgZHdhcmZfZGVjb2RlX21hY3JvcyAoY3UtPmxp bmVfaGVhZGVyLCBEV19VTlNORCAoYXR0ciksCiAJCQkgICBjb21wX2Rpciwg YWJmZCwgY3UsCi0JCQkgICAmZHdhcmYyX3Blcl9vYmpmaWxlLT5tYWNybywg MSk7CisJCQkgICAmZHdhcmYyX3Blcl9vYmpmaWxlLT5tYWNybywgMSwKKwkJ CSAgICIuZGVidWdfbWFjcm8iKTsKICAgICB9CiAgIGVsc2UKICAgICB7CkBA IC02MzY1LDcgKzYzNjcsOCBAQCByZWFkX2ZpbGVfc2NvcGUgKHN0cnVjdCBk aWVfaW5mbyAqZGllLCBzCiAKIAkgIGR3YXJmX2RlY29kZV9tYWNyb3MgKGN1 LT5saW5lX2hlYWRlciwgbWFjcm9fb2Zmc2V0LAogCQkJICAgICAgIGNvbXBf ZGlyLCBhYmZkLCBjdSwKLQkJCSAgICAgICAmZHdhcmYyX3Blcl9vYmpmaWxl LT5tYWNpbmZvLCAwKTsKKwkJCSAgICAgICAmZHdhcmYyX3Blcl9vYmpmaWxl LT5tYWNpbmZvLCAwLAorCQkJICAgICAgICIuZGVidWdfbWFjaW5mbyIpOwog CX0KICAgICB9CiAKQEAgLTEyMzE3LDcgKzEyMzIwLDYgQEAgZHdhcmZfZGVj b2RlX2xpbmVfaGVhZGVyICh1bnNpZ25lZCBpbnQgbwogICAgIHNlY3Rpb24g PSAmY3UtPmR3b191bml0LT5kd29fZmlsZS0+c2VjdGlvbnMubGluZTsKICAg ZWxzZQogICAgIHNlY3Rpb24gPSAmZHdhcmYyX3Blcl9vYmpmaWxlLT5saW5l OwotICBhYmZkID0gc2VjdGlvbi0+YXNlY3Rpb24tPm93bmVyOwogCiAgIGR3 YXJmMl9yZWFkX3NlY3Rpb24gKGR3YXJmMl9wZXJfb2JqZmlsZS0+b2JqZmls ZSwgc2VjdGlvbik7CiAgIGlmIChzZWN0aW9uLT5idWZmZXIgPT0gTlVMTCkK QEAgLTEyMzI5LDYgKzEyMzMxLDEwIEBAIGR3YXJmX2RlY29kZV9saW5lX2hl YWRlciAodW5zaWduZWQgaW50IG8KICAgICAgIHJldHVybiAwOwogICAgIH0K IAorICAvKiBXZSBjYW4ndCBkbyB0aGlzIHVudGlsIHdlIGtub3cgdGhlIHNl Y3Rpb24gaXMgbm9uLWVtcHR5LgorICAgICBPbmx5IHRoZW4gZG8gd2Uga25v dyB3ZSBoYXZlIHN1Y2ggYSBzZWN0aW9uLiAgKi8KKyAgYWJmZCA9IHNlY3Rp b24tPmFzZWN0aW9uLT5vd25lcjsKKwogICAvKiBNYWtlIHN1cmUgdGhhdCBh dCBsZWFzdCB0aGVyZSdzIHJvb20gZm9yIHRoZSB0b3RhbF9sZW5ndGggZmll bGQuCiAgICAgIFRoYXQgY291bGQgYmUgMTIgYnl0ZXMgbG9uZywgYnV0IHdl J3JlIGp1c3QgZ29pbmcgdG8gZnVkZ2UgdGhhdC4gICovCiAgIGlmIChvZmZz ZXQgKyA0ID49IHNlY3Rpb24tPnNpemUpCkBAIC0xNjg5NCw3ICsxNjkwMCw3 IEBAIGR3YXJmX2RlY29kZV9tYWNyb3MgKHN0cnVjdCBsaW5lX2hlYWRlciAK ICAgICAgICAgICAgICAgICAgICAgIGNoYXIgKmNvbXBfZGlyLCBiZmQgKmFi ZmQsCiAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHdhcmYyX2N1ICpj dSwKIAkJICAgICBzdHJ1Y3QgZHdhcmYyX3NlY3Rpb25faW5mbyAqc2VjdGlv biwKLQkJICAgICBpbnQgc2VjdGlvbl9pc19nbnUpCisJCSAgICAgaW50IHNl Y3Rpb25faXNfZ251LCBjb25zdCBjaGFyICpzZWN0aW9uX25hbWUpCiB7CiAg IHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlID0gZHdhcmYyX3Blcl9vYmpmaWxl LT5vYmpmaWxlOwogICBnZGJfYnl0ZSAqbWFjX3B0ciwgKm1hY19lbmQ7CkBA IC0xNjkwOSw4ICsxNjkxNSw3IEBAIGR3YXJmX2RlY29kZV9tYWNyb3MgKHN0 cnVjdCBsaW5lX2hlYWRlciAKICAgZHdhcmYyX3JlYWRfc2VjdGlvbiAob2Jq ZmlsZSwgc2VjdGlvbik7CiAgIGlmIChzZWN0aW9uLT5idWZmZXIgPT0gTlVM TCkKICAgICB7Ci0gICAgICBjb21wbGFpbnQgKCZzeW1maWxlX2NvbXBsYWlu dHMsIF8oIm1pc3NpbmcgJXMgc2VjdGlvbiIpLAotCQkgc2VjdGlvbi0+YXNl Y3Rpb24tPm5hbWUpOworICAgICAgY29tcGxhaW50ICgmc3ltZmlsZV9jb21w bGFpbnRzLCBfKCJtaXNzaW5nICVzIHNlY3Rpb24iKSwgc2VjdGlvbl9uYW1l KTsKICAgICAgIHJldHVybjsKICAgICB9CiAK --20cf307d021444810704bed998e6--