From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26837 invoked by alias); 1 Aug 2014 02:04:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21467 invoked by uid 89); 1 Aug 2014 02:03:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f171.google.com Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 01 Aug 2014 02:03:25 +0000 Received: by mail-vc0-f171.google.com with SMTP id hq11so5664367vcb.16 for ; Thu, 31 Jul 2014 19:03:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2GavjK9/tOtx/qfpCeIYPKvEHUfs37HYEI4hoE5pz9s=; b=jDX7AS0/Ko7a/TPN+S7NV9CJb2TD9P4tb7HSAjhPfyqpaNe3GovCta5ogLnY+EXcL2 MFlRAk2bk0uafikUgp2Ttz4jN3BUzVDqJf+iEtuhYy3T5UgsycMaSaIdaAN9h8APjmdo yzGIL1UGXKcogdxfPH8tT43FU5/GoI8sihK8Lh5IL2q2OP0kClq/FNbIKphClQi3P8LZ 2CQc7i9PcF/v6CaIMV2z+/sg5FXU3PoiI+Y+bVJf3EFB885w0YvOYK6unNLcjpJcJzR0 +3TAniWrSKQUIXEoGnpt7O9NJRhAFzhYvp7ta7kBpHAv8IfYXz0Kp36SAupo3TcHBaFI 2EgA== X-Gm-Message-State: ALoCoQnKyvI3V7c4KRyRWPH2U9XmN3IOPDxL+1I0kQzcb/X8Hd1c6YKTTWbdbACbXyBSWld2Javv MIME-Version: 1.0 X-Received: by 10.52.28.9 with SMTP id x9mr2282644vdg.48.1406858599653; Thu, 31 Jul 2014 19:03:19 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 31 Jul 2014 19:03:19 -0700 (PDT) In-Reply-To: References: <20140731193050.GA7927@host2.jankratochvil.net> <20140731200529.GG14672@adacore.com> <20140731204242.GH14672@adacore.com> Date: Fri, 01 Aug 2014 02:04:00 -0000 Message-ID: Subject: Re: [PATCH] Delete struct inferior_suspend_state From: Doug Evans To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00000.txt.bz2 On Thu, Jul 31, 2014 at 1:58 PM, Doug Evans wrote: > [...] > It would be interesting to do an audit and see how many outdated > comments gdb has. > [...] I'm happy to go with whatever the community wants (I want to be clear that I'm not trying to advance any particular position on this patch - I do have opinions on how to handle the various choices, but I don't favor any particular choice). But as a data point to the above comment, because I think it's an important issue, this comment in inf-loop.c is odd. I happened across it because I'm trying to implement having the event loop handle waiting for all threads to stop, instead of doing the waiting in a special loop apart from the event loop. inf-loop.c: /* General function to handle events in the inferior. So far it just takes care of detecting errors reported by select() or poll(), otherwise it assumes that all is OK, and goes on reading data from the fd. This however may not always be what we want to do. */ void inferior_event_handler (enum inferior_event_type event_type, gdb_client_data client_data) { ... AFAICT, it doesn't match what the function does at all. inferior_event_handler + fetch_inferior_event is also a bit odd. I see some cleanup potential here, more on that later (I hope, pending finding the time :-)).