Re: [PATCH] Fix Gold/strip discrepancies for PR 11786

Stan Shebs
2013-11-06T22:23:27Z

On 11/6/13 1:24 PM, Jan Kratochvil wrote:
> On Wed, 06 Nov 2013 22:14:27 +0100, Doug Evans wrote:
>> It will basically say tests are in general not required to following
>> the GDB coding standards,
>
> What is the reason for it?
>
> I would find more logical to say tests should follow the same rules as GDB
> code, unless there is a specific reason for it. Such as importing an existing
> external reproducer, machine generated output etc.
>
> If GDB coding standards are not acceptable for testcases then it looks to me
> as an indication the GDB coding standards should be changed.

The point of the testsuite is to check GDB behavior on programs in
general. We would look pretty foolish if someone were to encounter a
GDB bug that only occurred in source that did not follow the GDB
standard, and we were unable to detect it because our regression tests
did not include code written in a variety of styles.

As examples, the GNU style prefers to have braces on lines by
themselves, and to not have side-effecting code in conditionals, even
though there are millions of lines of code written that way. Without a
testsuite including these common usages, it would be easy to introduce
bugs in single-stepping and breakpoint handling that our regression
testing could not catch.

Stan
stan@codesourcery.com