From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20893 invoked by alias); 10 Oct 2013 19:04:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20884 invoked by uid 89); 10 Oct 2013 19:04:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Oct 2013 19:04:19 +0000 Received: by mail-vc0-f174.google.com with SMTP id gd11so1990058vcb.5 for ; Thu, 10 Oct 2013 12:04:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=BwVjBeA/6nWEHmRS7pwdMGfzMureZ/n44zXOO4fo4Kk=; b=EMASoTgA5oQy51gnRoFv4iNxIok45+VikMAD3nbysA7LXXeRdxfLeF3Mp6bGPcaQfe 8bMOXndGZcFq62SqFgu1X8eqb85GTLQ2U7YGJN5Oo8vlP1YjjgT19vyG6QQonLwDgMxo 9RuanuezpgEK2FTTLk9v61FcpFXhA/mVAW2UNRftHKiEUl6KB5mcjiIOrYu0KH3PVnDK eTvkWFC8q5JaohLJ8TGOP7PklgeFwyqBCaz2DH4BqVr6dRPXSvOlZsMHAUnzbES8xdS+ EdlWxqvjVPROP/oFhDiPkpeIXXik3PbNlE8LGXWTGlzocTPO0E4zTLz32z1/GrudO3dk M+Ug== X-Gm-Message-State: ALoCoQmBkmlr3DRuEqbAN7+bzLzggaSakL0M8mOwCpeg6ygbT+I0ZxGMTxzl+DZ6B2tewzHuyaJT9Kd8yCCT8ue6n0eI/nuEVJJzZUKio7vDhgQVIUCLqzBrikmVAQU8pYMb+ZxLaZjXG8iGs9Sem438O0RUsWCrMWDU/BI4mM8I/ISIbc23bQxTBy0sJr4DnIZ/fzBd05AYzXLUZ4WwgG/kek1duYbkHw== MIME-Version: 1.0 X-Received: by 10.52.244.109 with SMTP id xf13mr8529050vdc.81.1381431857287; Thu, 10 Oct 2013 12:04:17 -0700 (PDT) Received: by 10.52.37.138 with HTTP; Thu, 10 Oct 2013 12:04:17 -0700 (PDT) In-Reply-To: <87iox5ame5.fsf@fleche.redhat.com> References: <1375983426-19308-1-git-send-email-tromey@redhat.com> <87pprfft9c.fsf@fleche.redhat.com> <21077.61952.984944.635448@ruffy.mtv.corp.google.com> <87iox5ame5.fsf@fleche.redhat.com> Date: Thu, 10 Oct 2013 19:04:00 -0000 Message-ID: Subject: Re: [PATCH] fix PR symtab/15597 From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00356.txt.bz2 On Wed, Oct 9, 2013 at 7:29 PM, Tom Tromey wrote: > Doug> So code was moved to a different file and edited in one step > Doug> (instead of moving it, and then editing it in a separate pass)? > > In this case I thought it couldn't reasonably be moved verbatim, since, > IIRC, prior to my changes it required ELF bits from BFD, not allowed in > generic code. Assuming I'm interpreting this correctly, I think what's allowed can give way to the teeny window in which a multi-part patch gets checked in. > Doug> [not that I mind per se, but I thought doing things that way > Doug> was more than just "nice to have"] > > In your case the two changes had nothing to do with one another. I > think that is a reasonable standard. If you disagree, I'm sure we can > all agree on some other standard. My case? I've long since dropped from cache what that might be referring to so I had to go looking ... Are you referring to this? https://sourceware.org/ml/gdb-patches/2013-09/msg00884.html I didn't move a function to a new file, the desire to simplify archeology is what this (sub-)thread is about. You could be referring to a different patch of course. :-) No worries. As I say I don't mind. I raise the issue because I was led to believe archeology simplification (for lack of a better phrase, blech) is sufficiently important, so I wanted to clear it up. Perhaps if the amount of code being moved was much larger, or the changes were much greater, you would have split the patch into two as a matter of course?