From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6813 invoked by alias); 15 Oct 2012 18:50:09 -0000 Received: (qmail 6801 invoked by uid 22791); 15 Oct 2012 18:50:08 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Oct 2012 18:50:00 +0000 Received: by mail-ob0-f169.google.com with SMTP id va7so6232595obc.0 for ; Mon, 15 Oct 2012 11:49:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=jRBjGkqr9l5FySlZgTjeQ/8eE5oE/APKmr5froUblUU=; b=Af+LhRp75xcEJXBy94AFzQnptgsBKdHKYJGRNYth0af8d/9MPJO09vARGaj3Otuws9 L5JsVRvMxPzxCg156JsExRUAWnP9X9rxa4Lut2RXV9uP83a2S8wicmiTL4Zfs2lg7UC1 dtNuPtOwbuDo3yrmsPsogmogBa9SCbFnrI2XHpXeTcYvX7gpYdAsV/aog2Fp53bxxsMx CSQjZQq6RFVZgpr8WgzI1Z3Cu+EMq++BMHqaCc2+HFJ0/tBDmUQ8augyX4xbPEt8y2UD t7qL8n2Ryy41o1AkXjPqcWfk6DUkhVdg6y1ImAwARyqDF8qx0Udru1Rl0kyzjsXArS3P QqKQ== MIME-Version: 1.0 Received: by 10.60.22.161 with SMTP id e1mr4226120oef.93.1350326999771; Mon, 15 Oct 2012 11:49:59 -0700 (PDT) Received: by 10.76.96.209 with HTTP; Mon, 15 Oct 2012 11:49:59 -0700 (PDT) In-Reply-To: <20121015183521.GA26690@host2.jankratochvil.net> References: <20121012070149.GA5873@host2.jankratochvil.net> <20604.19144.405313.95372@ruffy2.mtv.corp.google.com> <20121015183521.GA26690@host2.jankratochvil.net> Date: Mon, 15 Oct 2012 18:50:00 -0000 Message-ID: Subject: Re: Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass] From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQn+Rk/4MbHIYvt5/VG2EjHe0CjPdSfY12v+zCQpmNNPq+JueHndCjStPLhCDQ2h8A6KCzUJeB3sWcTNMMx77FNibFRqFsIgVvViyXzke0CpjRPR8UE0jlssRLsNj6m+AWI8UpqzlQl80IXDnLp4gfINDl+crXIEqVSzpLsPw79ZBdEkUlOID0ZJl4IOReDPCgsDvi1BJFICWPozY5IY3ds8Hg67bQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00229.txt.bz2 On Mon, Oct 15, 2012 at 2:35 PM, Jan Kratochvil wrote: > Hi Doug, > > On Mon, 15 Oct 2012 19:41:28 +0200, dje@google.com wrote: >> This patch fixes stap-probe.exp on the Fedora box I tested on. > > Yes, it does. > >> I didn't test jmisc.exp but it is likely the same issue. > > No, it is not. > > I guess you agree, I will check it in. With '{ allow-pending }' the function > gets passed "{ allow-pending }" while with '{allow-pending}' it gets passed > "allow-pending". tcl-8.5.12-3.fc18.x86_64 I gather the issue is that the code is now treating { allow-pending } like " allow-pending ", and the test for "allow-pending" (no spaces) is now failing. Given that gdb_breakpoint is a varargs function, and parameters like allow-pending are part of the varargs parameters, it seems wrong to pass allow-pending as a list itself (which the braces imply), so perhaps we should remove the braces altogether. i.e., s/{ allow-pending }/allow-pending/ > > Thanks, > Jan > > > gdb/testsuite/ > 2012-10-15 Jan Kratochvil > > Fix recent gdb_breakpoint regression. > * gdb.java/jmisc.exp: gdb_breakpoint for $function - remove spaces from > curly bracketed parameter. > * gdb.java/jprint.exp: Likewise. > > diff --git a/gdb/testsuite/gdb.java/jmisc.exp b/gdb/testsuite/gdb.java/jmisc.exp > index 7215861..64ae559 100644 > --- a/gdb/testsuite/gdb.java/jmisc.exp > +++ b/gdb/testsuite/gdb.java/jmisc.exp > @@ -43,8 +43,8 @@ if [set_lang_java] then { > # signature. > runto_main > set function "${testfile}.main(java.lang.String\[\])" > - gdb_breakpoint "$function" { allow-pending } > - gdb_breakpoint "${function}void" { allow-pending } > + gdb_breakpoint "$function" {allow-pending} > + gdb_breakpoint "${function}void" {allow-pending} > gdb_continue_to_breakpoint $function > > gdb_test_multiple "ptype jmisc" "ptype jmisc" { > diff --git a/gdb/testsuite/gdb.java/jprint.exp b/gdb/testsuite/gdb.java/jprint.exp > index b2d5d31..ac5c55c 100644 > --- a/gdb/testsuite/gdb.java/jprint.exp > +++ b/gdb/testsuite/gdb.java/jprint.exp > @@ -43,8 +43,8 @@ if [set_lang_java] then { > # signature. > runto_main > set function "${testfile}.main(java.lang.String\[\])" > - gdb_breakpoint "$function" { allow-pending } > - gdb_breakpoint "${function}void" { allow-pending } > + gdb_breakpoint "$function" {allow-pending} > + gdb_breakpoint "${function}void" {allow-pending} > gdb_continue_to_breakpoint $function > > gdb_test "p jvclass.addprint(4,5,6)" " = 15" "unambiguous static call"