From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19596 invoked by alias); 7 Apr 2012 20:49:55 -0000 Received: (qmail 19586 invoked by uid 22791); 7 Apr 2012 20:49:53 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Apr 2012 20:49:41 +0000 Received: by vcbfk14 with SMTP id fk14so1544529vcb.0 for ; Sat, 07 Apr 2012 13:49:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=Q3xfbaH0l4n9kTXjQOvKLkwcL2ib17iuEYm7kxJOtlg=; b=SWuzZGE7g2N7GWbFWQUwGaZjX24XTf4DoZAGXySwolIaOdObc7kGfpXOoV94NbE2xH PCvibDkAyHLLgzI0OARdZnjsRaSAcdYUxAEVji/2W5J+KbQT4LIKvuQvniRcDeMDynNe fleg6r1bIR1vj6Bv9lf/K3Ozmn4Z+elgSFBMsEXNCHbduYNJotI8lMPwNa2+0I8ly8C+ fvXGrmFet9Ny+lZwB6XqbjXjKHvjPI5iXJn+m+QPmo2+L+Pfxw6iliq5xgiXQj1N0uXs bZbaEuXvv5yfInQNhEB12FeKx5JBOHvl6h9fcow2OssSdAPSPW0VPsqLSstjektD9mV6 HD2g== Received: by 10.52.68.204 with SMTP id y12mr955975vdt.53.1333831780121; Sat, 07 Apr 2012 13:49:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.68.204 with SMTP id y12mr955969vdt.53.1333831779948; Sat, 07 Apr 2012 13:49:39 -0700 (PDT) Received: by 10.220.73.14 with HTTP; Sat, 7 Apr 2012 13:49:39 -0700 (PDT) In-Reply-To: <4F80A628.7050304@eagerm.com> References: <20120407193915.4B21224618E@ruffy.mtv.corp.google.com> <4F80A628.7050304@eagerm.com> Date: Sat, 07 Apr 2012 20:49:00 -0000 Message-ID: Subject: Re: [commit] dwarf2read.c (load_partial_dies): Change condition to assert. From: Doug Evans To: Michael Eager Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnmCaF6TS+mm3RryGVjqQ00l8i59JDjlkDbGpP6GNlyf/cERCs7pkekFNstIZq18mK70gYZeef6zJ4xRXx3EvNDljFaZZyc9CR+lVMFoi14DRysnSPaHsBywpzPgV2vYJg6w6t7gV2vkiyqlvQA+Yq3TkxatQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00117.txt.bz2 On Sat, Apr 7, 2012 at 1:40 PM, Michael Eager wrote: > On 04/07/2012 12:39 PM, Doug Evans wrote: >> >> Hi. >> >> There's no caller where cu->per_cu =3D=3D NULL, >> and I'd rather have the assert. > > > Per_cu data is flushed asynchronously in free_heap_comp_unit() > and free_stack_comp_unit(). =A0Are you sure that this can't happen? Define "asynchronously". My reading of all of the callers says it can't happen (modulo bugs of cours= e). I could have missed something of course (in which case let's get something added to the testsuite to exercise the appropriate code path).