From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23498 invoked by alias); 19 Mar 2013 16:32:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23485 invoked by uid 89); 19 Mar 2013 16:31:53 -0000 X-Spam-Sware-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 19 Mar 2013 16:31:51 +0000 Received: by mail-vc0-f176.google.com with SMTP id ib11so535938vcb.21 for ; Tue, 19 Mar 2013 09:31:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=a3HHeQBR8yI+E7oJZD6rZeHwVKBithi6EvQjrrPQAc8=; b=eqtIFgGdlIbIfUu8Mr4HNT8g1myuTgJ3C0ifQ92wWb53QP1tzwMMIK+gsJPEB0rtsR +ZR701RGxOLEZ0R/lojL0jH7jzVnZxWJ4XBPbyb8eb/gQ9FVgjND2HqsDTkfeKITB/Xs pxGD7SI21JTZIiVob/+M6AEG4EZx7ZeFbJT8+nj1n8+Nam1I5Nw15YHjm2IbA/7BflDU jymN1k4UujWDOGrwljO4fRk3SWEwK2BBpLuDxgOadoJZl/MW5GY4avbXuhYQJ6zxkxOn zrW781ar3E9K7u+V0cDsPIdudYcfC25K6kDNfjrD5/HgZgimwuQ5BkhJ2ZP0Vu1BzKV1 EKng== MIME-Version: 1.0 X-Received: by 10.52.21.175 with SMTP id w15mr2778558vde.100.1363710709336; Tue, 19 Mar 2013 09:31:49 -0700 (PDT) Received: by 10.220.168.143 with HTTP; Tue, 19 Mar 2013 09:31:49 -0700 (PDT) In-Reply-To: <1363407692-18959-4-git-send-email-yao@codesourcery.com> References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-4-git-send-email-yao@codesourcery.com> Date: Tue, 19 Mar 2013 17:12:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Don't use unportable macros From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmVcfZsfQCFXVduGe15IPtVYICYDkGrfesITVdtuJ6dR84C/JdeRUEg2mkDkMiSJ31IHgIyySSreEGK8a0A2RhAFYwcIrK31auHJe2lD4XpYqcZzkHkeAGWOhbdTljNJuvNPNDe3ujiw97sueis0oTjKD+A4kHsqLFFlivUu13aTmg125fhqoYV9VhZw1uMFp7VdgTtzqupPazx/PBnMhVT8gsNug== X-SW-Source: 2013-03/txt/msg00716.txt.bz2 On Fri, Mar 15, 2013 at 9:21 PM, Yao Qi wrote: > gdb: > > 2013-03-16 Yao Qi > > * ctf.c (ctf_start): Don't use unportable macros. > --- > gdb/ctf.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/gdb/ctf.c b/gdb/ctf.c > index a93dfaf..f66e857 100644 > --- a/gdb/ctf.c > +++ b/gdb/ctf.c > @@ -306,8 +306,7 @@ ctf_start (struct trace_file_writer *self, const char *dirname) > int i; > > /* Create DIRNAME. */ > - if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH) > - && errno != EEXIST) > + if (mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR) && errno != EEXIST) > error (_("Unable to open directory '%s' for saving trace data (%s)"), > dirname, safe_strerror (errno)); It feels like one would want to use mode 0755 by default on *nix. Why not store the mode in a local, and have a sequence of #ifdef's like remote-fileio.c? [And if you want, tuck the crud away in a helper function to maintain the S/N ratio of this function.]