From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1551 invoked by alias); 10 Mar 2014 05:34:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1522 invoked by uid 89); 10 Mar 2014 05:34:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ve0-f170.google.com Received: from mail-ve0-f170.google.com (HELO mail-ve0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 10 Mar 2014 05:34:18 +0000 Received: by mail-ve0-f170.google.com with SMTP id pa12so6695834veb.29 for ; Sun, 09 Mar 2014 22:34:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=10xvI4K8QAKZ6gzPL9H0zT3JWBI6Te7JVMa/vcNARts=; b=d+LVFF2edzp8vEHlvGVmi5A2b4fHiq5fwkzUEAK4F/jT6uC0bAFxMhLW6jF247dFaW xgwne+2rYJmdG+ZJ8PsujHIuJp1CcjbRuvrVFfHbRCf1ro2z51d1quc2Es6+cc4IaJIR CGnlNo1VGxuS3XOrLVoJe1dSsv9F/i5H5vYE6InhLzQrqIrF1hC88OGRSKXKLHGr/ZbI +6qH64X79mly30SVRcz5fxoues9xjU4kXppNGzUGZ0Cs+wLoLPHMeaQjSuH9nFVnQy6e Zv98GDwVI0Osl9gMDlEQ0DW7Wd1Z9HlevqcGBQRIH5hQYuKxILN1bqoFhUb64WGueu94 r1cQ== X-Gm-Message-State: ALoCoQnCa/TSYhEw94DKRZrc4tUKf1P0MclD2qaMe7ynbkY1dcjzjUnBJEJg0p2d1BGOmPWZ/1p1VW8XJxQzpMfVAPDKFALccEvGO5tT0Hw+i4C+KAqfJzL9Jzo10EM0LZ7LuS1Wc8xLc84jdy5YwBQbQsgvzHWHJV6tkewN77tdi5TXFnkjQzX0xs4Ye1jSyI5vQE3w/dkI3KItsr84qEFUFO2QJ+9viw== MIME-Version: 1.0 X-Received: by 10.220.99.72 with SMTP id t8mr21132391vcn.10.1394429655862; Sun, 09 Mar 2014 22:34:15 -0700 (PDT) Received: by 10.52.13.101 with HTTP; Sun, 9 Mar 2014 22:34:15 -0700 (PDT) In-Reply-To: <531D2739.3000508@codesourcery.com> References: <531D2739.3000508@codesourcery.com> Date: Mon, 10 Mar 2014 05:34:00 -0000 Message-ID: Subject: Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN] From: Doug Evans To: Yao Qi Cc: Doug Evans , Tom Tromey , Hui Zhu , gdb-patches ml Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00228.txt.bz2 On Sun, Mar 9, 2014 at 7:45 PM, Yao Qi wrote: > On 03/06/2014 01:20 PM, Doug Evans wrote: >> While I realize we don't want to require perl for building gdb (and I >> for one would never advocate it), I wonder if we can do at least a bit >> better. > > perl is required by git, and GDB source is version controlled by git. > I assume that most of the host machine used for gdb development have > git and perl installed. People may get source from release, and > generate patch on top of it (without git/perl installed). It isn't > common, is it? Apologies for not being clear enough. This is not, and never has been, an issue of needing perl installed per se. The issue is whether we should impose on people the requirement of some perl knowledge, however minimal, when one turns on --enable-maintainer-mode. If people decide to, fine by me. But I was not prepared to do that without a discussion. > Anyway, we can check whether perl is installed. If perl is installed, > run make-target-delegates during make and error out if new-generated > target-delegates.c is different from the one in gdb source. Is it good? > If yes, I'll submit a patch for this. There is no need for this AFAICS. Does AM_MAINTAINER_MODE do this for autoconf? Maybe it does and I can't find it. And if it doesn't do so for autoconf, why do it for perl?