From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4778 invoked by alias); 7 Mar 2013 22:57:03 -0000 Received: (qmail 4767 invoked by uid 22791); 7 Mar 2013 22:57:02 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f172.google.com (HELO mail-vc0-f172.google.com) (209.85.220.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 22:56:58 +0000 Received: by mail-vc0-f172.google.com with SMTP id l6so597980vcl.3 for ; Thu, 07 Mar 2013 14:56:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=ocQ7WoBaoRSrKrvZStaJ0CSLg642toC98/OjNzapyL4=; b=YOHF91Qy9JW1Vr5chqQHraHpykDDYxrG+KU2gOy6i8g5/OzR1CrhfZ4JcxgkZZ9KDs DrbO7Aun1BdHPTLGoEjkW2EqmY3P/xcZ2Om18kpD5ieYV4yxIvvSVkmxxd7wNgqtiESQ tw/pT2DdNl37BUJSLRm2XALljRblHn2qVLcr8uIFAW6KRDAitmBzo5K2EbSdsxzvUIK/ XdXFZw/bX9c9Z/h1dU6EWcsYCIe3ZhcVu7DCYou6++w7DPZL4SUDrFB80gGHsAsbs1C9 H+F2UBKoxilKgUzcD/Y4Ck7IAsko2LXIj0q4Mb11cV7r1BV+u4cKLOuZHzAyFsnRDuGa AdGA== MIME-Version: 1.0 X-Received: by 10.58.151.4 with SMTP id um4mr29708veb.12.1362697018051; Thu, 07 Mar 2013 14:56:58 -0800 (PST) Received: by 10.220.9.199 with HTTP; Thu, 7 Mar 2013 14:56:57 -0800 (PST) In-Reply-To: References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-2-git-send-email-markus.t.metzger@intel.com> Date: Thu, 07 Mar 2013 22:57:00 -0000 Message-ID: Subject: Re: [patch v9 01/23] thread, btrace: add generic branch trace support From: Doug Evans To: "Metzger, Markus T" Cc: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQl62Unm6XK4uS5oYrWG8hUetbsIEZq/2PTir6UKynHE7Qg/bSOm99L6TuBVW+fK79pA+BLSNGneOWNVdKA/au+N3Rq5NKq3wi9ehgCvT0u5TEnBTJptPkBA590urr9e/VcAoVtUdvf37zS6UtVaY44E0aw+krLK05WFGTUdpMw0xuswZ1NZtk3nl/crV12j/L9F0BfgRtTat4EVgPIO4C6J8EOg8g== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00318.txt.bz2 On Wed, Mar 6, 2013 at 11:49 PM, Metzger, Markus T wrote: >> -----Original Message----- >> From: Doug Evans [mailto:dje@google.com] >> Sent: Wednesday, March 06, 2013 10:12 PM > > Thanks for your review. > > >> > + /* The function index range [begin; end[ that has been covered last time. >> >> Typo: end] > > That's intended to indicate that begin is included in the range whereas end isn't. > I see that this has not been clear enough. I'll reword it. For that use [begin,end). ref: http://en.wikipedia.org/wiki/Interval_(mathematics) >> > +/* A branch trace block. >> > + >> > + This represents a block of sequential control-flow. Adjacent blocks will be >> > + connected via calls, returns, or jumps. The latter can be direct or >> > + indirect, conditional or unconditional. Branches can further be >> > + asynchronous, e.g. interrupts. */ >> > +struct btrace_block >> > +{ >> > + /* The address of the first instruction in the block. */ >> > + CORE_ADDR begin; >> > + >> > + /* The address of the last instruction in the block. */ >> > + CORE_ADDR end; >> > +}; >> >> Can you elaborate in the docs for "end" what it is? >> E.g., on an ISA with only 4 byte instructions, and the block contains >> two instructions, is end == begin+4 or begin+7 or begin+8? >> I'd guess that it's begin+4, but IWBN if the comment >> removed all doubt. > > I changed both comments to say "the first byte of ...". Thanks.