From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12635 invoked by alias); 12 Sep 2014 18:29:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12615 invoked by uid 89); 12 Sep 2014 18:29:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f180.google.com Received: from mail-vc0-f180.google.com (HELO mail-vc0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 18:29:54 +0000 Received: by mail-vc0-f180.google.com with SMTP id hq11so1076771vcb.25 for ; Fri, 12 Sep 2014 11:29:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2BFXrtfnafyH+6vRI0TMWBdcn0zvHpVEhWGt4Q1amTw=; b=Z+RFd3RZeYQ4n91BfSIAEkpL5KlTJH7LurUQOdoUXuFEq+soFGFtiyfkxNzNYBkdqm 8GoHvb1TJarWJZLdwrn0OeJhw21iTuKGNUEIzJy8xO1MYHRgIDLNPEvSUgPakSUNlhC3 wAKalFLcAY1eHLLLSf5ijNUegusX+XAfWVxvSG7zin1PiX5yNWylFQB5WKUVqU7Q4dsj m/bqdNc4rSEC9iybXg59VibBfmY4RKYtAOs2IPxtAxRAQoNi//cAKhbn2l9xY7PJD4dC ZxRsnV+Dii8C+/pHWZ1xcRfg2Q6S1X/Ek2A4AH86KyaJzonMoxZ6HQufgb11hM3S6nnB feXw== X-Gm-Message-State: ALoCoQmru9Ap6jxa3G3b3Qhbz6gHR+5F/tcUaFu1GDHyeL382rNJvU9Wgn40b8LGTB2Vg37mlEZy MIME-Version: 1.0 X-Received: by 10.52.240.135 with SMTP id wa7mr3713922vdc.82.1410546591762; Fri, 12 Sep 2014 11:29:51 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Fri, 12 Sep 2014 11:29:51 -0700 (PDT) In-Reply-To: <54133939.70801@redhat.com> References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-4-git-send-email-gbenson@redhat.com> <21520.36381.756875.963606@ruffy2.mtv.corp.google.com> <20140911102659.GA17472@blade.nx> <5412DEB5.6020706@redhat.com> <21523.9502.168492.803068@ruffy2.mtv.corp.google.com> <54132B55.9000108@redhat.com> <21523.12189.134570.770432@ruffy2.mtv.corp.google.com> <5413305B.6020402@redhat.com> <21523.13993.986533.615240@ruffy2.mtv.corp.google.com> <54133939.70801@redhat.com> Date: Fri, 12 Sep 2014 18:29:00 -0000 Message-ID: Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid From: Doug Evans To: Pedro Alves Cc: Gary Benson , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00453.txt.bz2 On Fri, Sep 12, 2014 at 11:19 AM, Pedro Alves wrote: > On 09/12/2014 07:08 PM, Doug Evans wrote: > >> And I remembered you saying: >> >> > I just now noticed the elephant in the room -- target_stop is >> > asynchronous, doesn't wait for a stop, while and target_stop_ptid >> > is synchronous. [...] >> >> If the above code is right, I think a clarifying comment >> is required somewhere. It's odd that one can call agent_run_command >> when the inferior may or may not be stopped yet. >> [Or is there a bug here? - if I'm reading the gdbserver version >> correctly it first waits for the inferior to stop] > > It's a bug. > > (Note that the GDB side interfaces with an out-of-tree > agent, not GDBserver's agent. I don't know the status of > that agent.) Heh. Data point that target_stop should be named target_stop_async? 1/2 :-) [I'd like to point out that all I had to do was read the code (glance is more apt) to see the bug (given that your comment about target_stop was still fresh in my mind). Unambiguous/clear function names are worth at least some effort.] btw, out-of-tree agent, and not gdbserver's agent? That's odd. Where would I find this agent?