From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6967 invoked by alias); 24 Feb 2014 21:55:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6957 invoked by uid 89); 24 Feb 2014 21:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f176.google.com Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 24 Feb 2014 21:55:52 +0000 Received: by mail-vc0-f176.google.com with SMTP id la4so6375130vcb.35 for ; Mon, 24 Feb 2014 13:55:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=llluM0cL2oTU0RgoH95CmOYCKkoo637SOjgodfZ8aVU=; b=Ok7PoVDfqBUkxTNd24EPeujYZdnhn64sQvlCw95tzwybAI9ShYArfFFRMMQZmWNKDA oB72Hbd64SDSxn21pbptaOdD51Mehu9RJeOkLSVb2NFkGwU9I4yihCLiHDwrzS0cLw/r rkeuEob+KSYajKhukjro56tQ8wdxyfSanIF0khYDsujrtYAMGJcsWsDMNwng70c9sM3k VNpNu/wJvq/FZOX5vQAkBxLsZ1aLMRrKzX/OkFFkY6FaWi5zT9n0fbtqVcX1B0FgUu/I eulhrT5Z8f0iKB/n5FtETxhlxJ2BbVXgKbmSbo63hwPudfHKlwgpvIMg4Ta65TdO5Uh4 6drw== X-Gm-Message-State: ALoCoQmyY/jjOQOs275k0el1F3o0ODJqT0OkYf/JQb8tmdSSHmgtzeiRTOnv7EiOoxGIoAC9cVgNOdXxRc2WSPkgV4tFy/FJlUQjPvEhKK83YVBcbpkZvMAK80LD7dYmgxM0QesYAejQRCUZsmixIMOU+nwOCD9DQMu1n2PH3MYvvIrl/BQr/0H3OVcOHVUU51tYByf02RsZPY7QqPeF6Rhw3OV7dwiZgw== MIME-Version: 1.0 X-Received: by 10.220.159.4 with SMTP id h4mr14307137vcx.1.1393278949869; Mon, 24 Feb 2014 13:55:49 -0800 (PST) Received: by 10.52.51.234 with HTTP; Mon, 24 Feb 2014 13:55:49 -0800 (PST) In-Reply-To: <20140224214314.GA5700@host2.jankratochvil.net> References: <20140224214314.GA5700@host2.jankratochvil.net> Date: Mon, 24 Feb 2014 21:55:00 -0000 Message-ID: Subject: Re: [patch] gdb_assert -> complaint for weird DWARF From: Doug Evans To: Jan Kratochvil Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00732.txt.bz2 On Mon, Feb 24, 2014 at 1:43 PM, Jan Kratochvil wrote: > Hi, > > PR 16581: > GDB crash on inherit_abstract_dies infinite recursion > https://sourceware.org/bugzilla/show_bug.cgi?id=16581 > > fixed crash from an infinite recursion. But in rare cases the new code can > now gdb_assert() due to weird DWARF file. > > I do not yet fully understand why the DWARF is as it is but just GDB should > never crash due to invalid DWARF anyway. The "invalid" DWARF I see only in > Fedora GCC build, not in FSF GCC build, more info at: > https://bugzilla.redhat.com/show_bug.cgi?id=1069382 > http://people.redhat.com/jkratoch/gcc-debuginfo-4.8.2-7.fc20.x86_64-gnatbind.debug > > > Thanks, > Jan > > gdb/ > 2014-02-24 Jan Kratochvil > > * dwarf2read.c (process_die): Change gdb_assert to complaint. Obviously gdb shouldn't crash on invalid input, but IWBN if gdb could have more robust guarantees internally. [One could argue changing the assert to a complaint is papering over a bug. Plus gdb's complaint system is off by default, out of sight makes for out of mind thus such things tend to not get much attention.] Can you dig into the details of why the assert is tripping? I'm not comfortable with adding more complaints without at least including documentation of details.