From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Type-safe wrapper for enum flags
Date: Sun, 01 Nov 2015 02:07:00 -0000 [thread overview]
Message-ID: <CADPb22RneCr=BW7c2m4277Sk-S9tDfLqe7jEaDrs2SDsJYdCbg@mail.gmail.com> (raw)
In-Reply-To: <1446144341-21267-1-git-send-email-palves@redhat.com>
On Thu, Oct 29, 2015 at 11:45 AM, Pedro Alves <palves@redhat.com> wrote:
> This patch fixes C++ build errors like this:
>
> /home/pedro/gdb/mygit/cxx-convertion/src/gdb/linux-tdep.c:1126:35: error: invalid conversion from ‘int’ to ‘filterflags’ [-fpermissive]
> | COREFILTER_HUGETLB_PRIVATE);
> ^
>...
> ---
> gdb/btrace.h | 10 +-
> gdb/c-exp.y | 5 +-
> gdb/common/enum_flags.h | 211 +++++++++++++++++++++++++++++++++++++++++
> gdb/compile/compile-c-types.c | 2 +-
> gdb/compile/compile-internal.h | 4 +
> gdb/completer.c | 5 +-
> gdb/disasm.c | 4 +-
> gdb/infrun.c | 14 +--
> gdb/linux-tdep.c | 19 ++--
> gdb/record-btrace.c | 22 +++--
> gdb/record.h | 2 +
> gdb/source.c | 7 +-
> gdb/symtab.h | 6 +-
Nit.
Introducing a foo_bar file when every other file in the patch uses
foo-bar is a bit odd.
enum-flags.h?
next prev parent reply other threads:[~2015-11-01 2:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 8:12 Pedro Alves
2015-10-30 9:48 ` Pedro Alves
2015-10-30 17:08 ` Simon Marchi
2015-10-30 17:39 ` Pedro Alves
2015-10-31 20:11 ` Simon Marchi
2015-10-31 20:28 ` Pedro Alves
2015-11-01 2:07 ` Doug Evans [this message]
2015-11-03 11:48 ` Pedro Alves
2015-11-01 4:04 ` Doug Evans
2015-11-03 12:23 ` Pedro Alves
2015-11-01 15:19 ` Patrick Palka
2015-11-03 11:18 ` Pedro Alves
2015-11-09 13:25 ` Patrick Palka
2015-11-17 13:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RneCr=BW7c2m4277Sk-S9tDfLqe7jEaDrs2SDsJYdCbg@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox