From: Doug Evans <dje@google.com>
To: Alexander Smundak <asmundak@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [RFC][PATCH] Allow JIT unwinder provide symbol information
Date: Wed, 12 Feb 2014 07:50:00 -0000 [thread overview]
Message-ID: <CADPb22Rf5jpi_YCF5UE13=CUmUV-FNZHPSpfbmpO3KNQq1sKfQ@mail.gmail.com> (raw)
In-Reply-To: <CADPb22Qithfi41fs1Ax5tz_g-zf8pzPRWKbnBrJZCiSqrO=KuA@mail.gmail.com>
On Tue, Feb 11, 2014 at 2:25 PM, Doug Evans <dje@google.com> wrote:
> On Tue, Jan 14, 2014 at 4:39 PM, Alexander Smundak <asmundak@google.com> wrote:
>> I fixed the patch based on your comments, except for the one
>> about using LWP for thread identification.
>> Waiting for the opinions about the approach used in this RFC patch.
>>
>>> > +/* Returns LWP ID of the current thread or 0. */
>>> > +
>>> > +typedef long (gdb_get_lwp) (void);
Another issue that occurs to me is what if the loaded jit shared
library on some platform (not necessarily linux) wants to use
ptid.tid, even if both ptid.lwp and ptid.tid are available?
Does it make sense to provide routines that access each?
Pedro, the issue is what handle on a thread to export to the
jit-reader-load shared library.
Java for linux wants the lwp, and currently the patch will return
ptid.tid instead of ptid.lwp if lwp == 0 to shield the shared lib
from gdb vs gdbserver thread ptid usage differences, on the assumption
that if lwp == 0 then tid is actually lwp.
On a separate note,
IIRC we still have to decide how to handle version 1 jit-reader-load
shared libs.
next prev parent reply other threads:[~2014-02-12 7:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 18:36 Sasha Smundak
2014-01-13 18:25 ` Alexander Smundak
2014-02-07 21:54 ` Alexander Smundak
2014-01-13 18:46 ` Doug Evans
2014-01-15 0:39 ` Alexander Smundak
2014-02-11 22:26 ` Doug Evans
2014-02-12 7:50 ` Doug Evans [this message]
2014-02-19 3:30 ` Alexander Smundak
2014-02-19 3:50 ` Eli Zaretskii
2014-02-19 5:23 ` Alexander Smundak
2014-04-11 18:47 ` Doug Evans
2014-04-11 18:58 ` Doug Evans
2014-04-21 1:35 ` Alexander Smundak
2014-04-21 7:14 ` Eli Zaretskii
2014-04-21 16:43 ` Alexander Smundak
2014-02-25 1:19 ` Doug Evans
2014-02-25 3:00 ` Alexander Smundak
2014-03-11 1:46 ` Alexander Smundak
2014-02-08 7:08 ` Yao Qi
2014-02-10 2:16 ` Alexander Smundak
2014-02-11 22:00 ` Doug Evans
2014-04-24 13:22 ` Pedro Alves
2014-04-25 23:40 ` Alexander Smundak
2014-04-29 15:22 ` Pedro Alves
2014-05-02 16:58 ` Alexander Smundak
2014-05-19 21:30 ` Alexander Smundak
2014-05-29 1:07 ` Alexander Smundak
2014-06-02 1:15 ` Alexander Smundak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22Rf5jpi_YCF5UE13=CUmUV-FNZHPSpfbmpO3KNQq1sKfQ@mail.gmail.com' \
--to=dje@google.com \
--cc=asmundak@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox