From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3428 invoked by alias); 15 May 2014 17:10:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3410 invoked by uid 89); 15 May 2014 17:10:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f172.google.com Received: from mail-vc0-f172.google.com (HELO mail-vc0-f172.google.com) (209.85.220.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 15 May 2014 17:10:17 +0000 Received: by mail-vc0-f172.google.com with SMTP id hr9so4729046vcb.31 for ; Thu, 15 May 2014 10:10:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=VhVmNSMCEjmb3fDLal+7fs9On5X6GECy9j6brjW1XOI=; b=h4MR58u4OrCPT9Ta6JdkPVlhdFImgI2N3IS7dK1nVSj3s6DyGXiy2iIP+plmdmr4FL 3fljkHYJey7LFuVPzLmU2K7XJAtMgEA5hHs7gv5KyKjLmnJzsRLOUiBZEEj5MqQURTUE XkPmTqhbMo0SnfJiKiLJ9sqPDe/CS/RfssTdBDUDw5hgUSj5n2wLI7AM9nYqbW606cBI Se5GvxBQQFPp7PUL8oRVIlsI+zM7dfQZTCti9DGmRR1IcSRfmK5JPO/P+Ib6MH20x3gB AFK/WpEFV26U2AqVED8GtEGsWaDSjxPAPQR5mCF4yHzA8GJrAz8jTcx1V80dSiJE4CI3 qrfQ== X-Gm-Message-State: ALoCoQk/vx72Qj+RMw8FWr/4jgu6z6bmpFjywrUctca+tpJFO8CuhAkaXprc0XqgVAI6xBivcdVv MIME-Version: 1.0 X-Received: by 10.58.198.107 with SMTP id jb11mr9634135vec.10.1400173815797; Thu, 15 May 2014 10:10:15 -0700 (PDT) Received: by 10.52.68.67 with HTTP; Thu, 15 May 2014 10:10:15 -0700 (PDT) In-Reply-To: <20140515113943.GB13323@blade.nx> References: <20140514110742.GA25550@blade.nx> <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com> <20140515113943.GB13323@blade.nx> Date: Thu, 15 May 2014 17:10:00 -0000 Message-ID: Subject: Re: [PATCH] Prompt user to report bugs From: Doug Evans To: Gary Benson Cc: Paul Koning , gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00248.txt.bz2 On Thu, May 15, 2014 at 4:39 AM, Gary Benson wrote: > Doug Evans wrote: >> On Wed, May 14, 2014 at 2:11 PM, wrote: >> > On May 14, 2014, at 5:05 PM, Doug Evans wrote: >> > > On Wed, May 14, 2014 at 4:07 AM, Gary Benson wr= ote: >> > > > 2014-05-14 Gary Benson >> > > > >> > > > * utils.c (internal_vproblem): Prompt the user to file a re= port. >> > > > >> > > > diff --git a/gdb/utils.c b/gdb/utils.c >> > > > index a8a7cb3..905ce6d 100644 >> > > > --- a/gdb/utils.c >> > > > +++ b/gdb/utils.c >> > > > @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *p= roblem, >> > > > else >> > > > internal_error (__FILE__, __LINE__, _("bad switch")); >> > > > >> > > > + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_= stderr); >> > > > + if (REPORT_BUGS_TO[0]) >> > > > + { >> > > > + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stde= rr); >> > > > + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO); >> > > > + } >> > > > + fputs_unfiltered ("\n\n", gdb_stderr); >> > > > + >> > > > if (problem->should_dump_core =3D=3D internal_problem_ask) >> > > > { >> > > > if (!can_dump_core (reason)) >> > > > >> > > >> > > top.c doesn't wrap "%s." in _(). >> > > I don't know if it matters, it's just odd to see "%s." wrapped. >> > >> > It also seems odd to see =E2=80=9C%s.=E2=80=9D inside _( ) since there= =E2=80=99s nothing >> > to translate there. >> >> That's why it seemed odd to me too. :-) >> [Though what do I know ... maybe someone might want to use something >> other than "." at the end.] > > Japanese has a different sentence terminator: > http://en.wikipedia.org/wiki/Japanese_punctuation#Full_stop > Possibly other languages do to. Heh. I didn't know that. Though I was thinking of Chantho when I wrote that. 1/2 :-) http://tardis.wikia.com/wiki/Chantho Chan tho ? [The Chan would probably go before "For instructions, see", but why ruin a good (bad?) joke. :)] > I'm easy either way, if people want it wrapped I'll wrap it, > if people want it bare I can do that too :) I don't have a strong preference, other than to be consistent. If it'd be a protocol violation to change top.c at the same time, and if no one really cares, then to keep things simple I'd say stick with what top.c does.