From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 698 invoked by alias); 18 Dec 2013 01:20:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 624 invoked by uid 89); 18 Dec 2013 01:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f49.google.com Received: from mail-vb0-f49.google.com (HELO mail-vb0-f49.google.com) (209.85.212.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Dec 2013 01:20:23 +0000 Received: by mail-vb0-f49.google.com with SMTP id x11so4588407vbb.36 for ; Tue, 17 Dec 2013 17:20:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=wj+gyWl5tGXMeQbxfOyfNX+MiecZY9y0+Yyr+jk5wXU=; b=AQcWr7LvIpKL5uqVYknyMO+Vmq+bOccusdS/nRiW6lDBqRgMLk4ixlaEN0h9zdAZIb is/rI7WLVyhXcHHSlOL+mwSM0H0aACYOncMbgXDhADjYhLEXxgY/5afJaPDSCBYRJ/iw CDi3wrXf9G+7MWzpdm8owXc/RCVueKLD6f/zvz991RwDZ0tyWUY6Vrv1RheF7i7Ilc31 4v/kBN957/IdXehJGl7/SSXj1q5a9Q1A/ghi0BxV09zl0N+OhqUsXQgulIr7S7lkEAFG l8+5nB7T52fAdY0/JB/AdHO+oo87n18RS9R9ZkuZ2pgXqqjID5bfE0mSV0ABuMxZehdV vpcQ== X-Gm-Message-State: ALoCoQlGs685veB+Pa14FOgIzTzLbF7SdPgcbj5BUI/VWo7VF5S4jTBLbFGl7RAG3xaLboxA3wRDQm/5+jKveTDNQha6OTpv2iQe5b8Le7gnIXGe7b0YK4NkowPxcENIoi02CMpe8VBGOoOAAcVkkQyhtiNjTAabTUdV014HY0rDSO2Ny4EtlU5+YRIknoqgOR1IaObvUCD4ljekHNQxSoCmDOqi+qvVgQ== MIME-Version: 1.0 X-Received: by 10.58.100.244 with SMTP id fb20mr11706155veb.6.1387329620938; Tue, 17 Dec 2013 17:20:20 -0800 (PST) Received: by 10.52.163.52 with HTTP; Tue, 17 Dec 2013 17:20:20 -0800 (PST) In-Reply-To: <52B0EF1E.7080302@codesourcery.com> References: <52B0EF1E.7080302@codesourcery.com> Date: Wed, 18 Dec 2013 01:20:00 -0000 Message-ID: Subject: Re: [PATCH 2/6] gdbserver: remove function abbrevs from debugging text From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00675.txt.bz2 On Tue, Dec 17, 2013 at 4:41 PM, Yao Qi wrote: > On 12/18/2013 05:43 AM, Doug Evans wrote: >> This patch removes the function abbreviations from the debugging output. > > Function abbreviations are also mentioned in linux-nat debugging output. > IWBN to keep them consistent. Sure. I'll submit a separate patch for that. >> In one example it's wrong (GPS vs get_detach_signal), and I rarely >> keep in cache the translation to function name. > > The function names in debugging output will be out of sync as function > names are changed, unless macro __func__ is used. However, __func__ > is defined in C99 and we are using C90 (?) in GDB. I think it's reasonable to do what we do for gdb_assert, namely just punt on printing the name if the feature isn't present. I see I missed at least one function with an abbreviated function name anyway.