From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18313 invoked by alias); 3 Apr 2012 00:54:16 -0000 Received: (qmail 18300 invoked by uid 22791); 3 Apr 2012 00:54:13 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_XG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Apr 2012 00:54:00 +0000 Received: by vcbfk14 with SMTP id fk14so2581441vcb.0 for ; Mon, 02 Apr 2012 17:53:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=+aSM88ZbSiaybhXBnYzn2/cVLR5o79eXOwnJ8lqWw/g=; b=nqiASOBha8y5DpKUtuXzyrxGhNVPe8I7lOHSUDAbWrNP0x+Ad8gSdyvIELf9ZalroA yhW5xhDehlqKnYnL64zXdiPVOyBVmZY7OKFH1umpIRc1FSjEadt8Na7gh0hwouhLTDOS bJoMHpi340YdDRZPGi8fkiOBPKVqa8D0E1NV/1hDikJ9G0UuqPxE6cdiexe7U7X0Q3KE +0uO6wzvDogzS5ROYxSwj2Pcw9d64c072Gw/fJKAGWzAXuxWLb8NhYSqZxvbx9m0LKh8 +Amr0nvpFb/KFRv0QyBVvg4LZEiKhfcxQNB/CvarmzCVVhcqiGbLCJvB1DBJNQyMaN82 chZg== Received: by 10.220.188.12 with SMTP id cy12mr4694691vcb.69.1333414439366; Mon, 02 Apr 2012 17:53:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.188.12 with SMTP id cy12mr4694675vcb.69.1333414439205; Mon, 02 Apr 2012 17:53:59 -0700 (PDT) Received: by 10.220.73.14 with HTTP; Mon, 2 Apr 2012 17:53:59 -0700 (PDT) In-Reply-To: <4F76CF8B.9060303@yandex.ru> References: <4ED92C05.9080803@yandex.ru> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> <4F32C009.2050103@yandex.ru> <87pqdma1mo.fsf@fleche.redhat.com> <4F412637.2010405@yandex.ru> <4F660CF6.9070008@yandex.ru> <8339953anu.fsf@gnu.org> <4F66DBD0.4000903@yandex.ru> <83vcm01obe.fsf@gnu.org> <4F6CADEF.4080700@yandex.ru> <83vclmynmz.fsf@gnu.org> <4F761708.8080105@yandex.ru> <83r4w9zua0.fsf@gnu.org> <45311333142751@web61.yandex.ru> <83obrdz579.fsf@gnu.org> <87971333177060@web108.yandex.ru> <4F76CF8B.9060303@yandex.ru> Date: Tue, 03 Apr 2012 00:54:00 -0000 Message-ID: Subject: Re: set print object on should affect MI varobjs (PR mi/13393) From: Doug Evans To: xgsa Cc: Eli Zaretskii , Tom Tromey , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQkOulCksoCQl7ZpU9JT1V0IvI7MmvgOaUXUBRdpqMj/dS0F/YwvMHWwL3JiHva1YzfFrwdJkDnTnIbg2W6gJO6JfQy2XM3VSauNdkfT/NQDvzsUDGq7/vWA/ZySLkGe17UASaItE34H69XyGOHaceABVkLKPg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00026.txt.bz2 On Sat, Mar 31, 2012 at 2:34 AM, xgsa wrote: > Hi, > > Here is the previous patch with the Tom's and Eli's review comments fixed. Hi. ChangeLog nit: To improve the S/N ratio of the ChangeLog entry, instead of: (adjust_value_for_child_access): Extended with a new parameter which specify whether the given value should be casted to enclosing type. (c_number_of_children): Updated for extended adjust_value_for_child_access. (c_describe_child): Updated for extended adjust_value_for_child_access. (cplus_number_of_children): Updated for extended adjust_value_for_child_access. (cplus_describe_child): Updated for extended adjust_value_for_child_access. write this: (adjust_value_for_child_access): Extended with a new parameter which specify whether the given value should be casted to enclosing type. All callers updated. and that's it. I.e., don't write entries for each caller, just say "All callers updated." [I know, a bit of a hassle this time, but next time you'll have less to type. :-)]