Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces"

Simon Marchi
2014-09-25T14:44:40Z

On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote:
> On Wednesday, September 24 2014, Doug Evans wrote:
>
>> IOW, how about move the call to prune_program_spaces to whatever
>> caller wants it.
>
> As a note, after I commented on the patch, I noticed that the "prune"
> argument may be unecessary indeed (and the "prunning" logic"), because
> we are not prunning anything anymore.
>
> Anyway, I just wanted to say that I agree with removing this part of the
> code, and moving it to more suitable parts.

Fine with me. Here is the updated patch, much simpler now.

gdb/Changelog:

* progspace.c (print_program_space): Don't prune program spaces
before printing them.
---
gdb/progspace.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/gdb/progspace.c b/gdb/progspace.c
index a74b6ab..b111a50 100644
--- a/gdb/progspace.c
+++ b/gdb/progspace.c
@@ -281,10 +281,6 @@ print_program_space (struct ui_out *uiout, int requested)
int count = 0;
struct cleanup *old_chain;

- /* Might as well prune away unneeded ones, so the user doesn't even
- seem them. */
- prune_program_spaces ();
-
/* Compute number of pspaces we will print. */
ALL_PSPACES (pspace)
{
--
2.1.0