From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27705 invoked by alias); 25 Sep 2014 19:13:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27693 invoked by uid 89); 25 Sep 2014 19:13:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f173.google.com Received: from mail-vc0-f173.google.com (HELO mail-vc0-f173.google.com) (209.85.220.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 25 Sep 2014 19:13:33 +0000 Received: by mail-vc0-f173.google.com with SMTP id le20so8414494vcb.18 for ; Thu, 25 Sep 2014 12:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=74EOmNPJveaf1YOaT5P9MT5wZZMYpmC3SHrXHq+8ZVk=; b=mtOPL3M9zisNM82A4kgw4GyP7pJLUjT2Y2wzjuWDBOSwEFwK+I7fvdioO2voKfp8l2 aDH3731/d8/d7BB8Aiucan/9DpySknrFLUNgERjEChgWnlySgPqGV1Hq+hLSd2x/tyUd WRg4RVKT4tnH5dJ+TuEsOUhsKM7QsLJ0hMGEU/7O1PMI5mYB4wCs8PaiCv+VsS2n+/fk UL9vQNHoRWLgqFmG1rMkTnCdSicrFg5RYQ7Jaf1WInarKVxt8USxUBJFETtdV8/qCN72 c+QvfVeLVvOiRewAwaLMX4vsNRpR6p51I32iNWGUwoto3YZHB2JO/hlHzlOgh/mo+Bet IlNw== X-Gm-Message-State: ALoCoQl0if8vXVJIT7MhU+BOUw1v+SW14it3psCMzrLfolas/3wvOeQhOy1/6c704Ef/pBqB+Cdk MIME-Version: 1.0 X-Received: by 10.220.92.198 with SMTP id s6mr1714360vcm.38.1411672411336; Thu, 25 Sep 2014 12:13:31 -0700 (PDT) Received: by 10.52.181.65 with HTTP; Thu, 25 Sep 2014 12:13:31 -0700 (PDT) In-Reply-To: <54242A52.8060200@ericsson.com> References: <1411582288-20967-1-git-send-email-simon.marchi@ericsson.com> <87sijgig81.fsf@redhat.com> <54242A52.8060200@ericsson.com> Date: Thu, 25 Sep 2014 19:13:00 -0000 Message-ID: Subject: Re: [PATCH] Don't prune program spaces when doing "maintenance info program-spaces" From: Doug Evans To: Simon Marchi Cc: Sergio Durigan Junior , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00744.txt.bz2 On Thu, Sep 25, 2014 at 8:44 AM, Simon Marchi wrote: > On 2014-09-24 10:30 PM, Sergio Durigan Junior wrote: >> On Wednesday, September 24 2014, Doug Evans wrote: >> >>> IOW, how about move the call to prune_program_spaces to whatever >>> caller wants it. >> >> As a note, after I commented on the patch, I noticed that the "prune" >> argument may be unecessary indeed (and the "prunning" logic"), because >> we are not prunning anything anymore. >> >> Anyway, I just wanted to say that I agree with removing this part of the >> code, and moving it to more suitable parts. > > Fine with me. Here is the updated patch, much simpler now. > > gdb/Changelog: > > * progspace.c (print_program_space): Don't prune program spaces > before printing them. LGTM In the commit log I would add a note that this was removed so that the print routine didn't have (unwanted) side-effects. Thanks.