From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7712 invoked by alias); 16 Mar 2014 02:34:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7682 invoked by uid 89); 16 Mar 2014 02:34:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ve0-f181.google.com Received: from mail-ve0-f181.google.com (HELO mail-ve0-f181.google.com) (209.85.128.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 16 Mar 2014 02:34:11 +0000 Received: by mail-ve0-f181.google.com with SMTP id oy12so4420934veb.12 for ; Sat, 15 Mar 2014 19:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=b/GMq6+e5mzdQTPikvMyYI/yona8IXkme/HUZuatZ5Y=; b=boHK9XaTFBWf+1sb2aei1uEHVu+T0nvp5D7B9myI+NQOuVC9DqYDYsJ63GDjtDdMnX 0YQtj98SEMf2FUZ0XpjGTYiIWm0KE3yyJW6xTzqgFNt84KHmx5SqOia4G5VJnW+vC/uK 0WBvphLfUJ2gaYpuE96wOpOnpMR8ftn86UDzxd27qU7cI9OiwGWy4yMFf98H6uxg0gZU pTW6kObxPyU2NEVVmybQjXJgECzJEBpU7W9EZSCNNRmtd8lsJ7+QlGyQ47cO+N7U9HSG 6Zl0+8IDCZtQePwJh+s9zRHWdnfU99Or/TxK1uAoSrKYHnDBVtnYij7E+YvzskjVv7Q7 0F0w== X-Gm-Message-State: ALoCoQnIQZTk7h0GYg0RGmA+gssRYVMO8vxT3e4UBJY88JakFIOzKG7dEpdp6JemI+DNS798+bp0vSl27x0TjPuWK+wpowXzhdRhaBnrUYLoKshSY6QEtMcM3ubw10QHzG+Ltk3TjyV0ATbfbQzUyJdYlaoiQPibmkZf8vR38lITEVBktuDT0jmmMWKOXZpkyJv1Ko/0qeZh0jfwwqXiUvcsUUPFZ5wVSA== MIME-Version: 1.0 X-Received: by 10.58.207.74 with SMTP id lu10mr13267416vec.15.1394937249003; Sat, 15 Mar 2014 19:34:09 -0700 (PDT) Received: by 10.52.13.101 with HTTP; Sat, 15 Mar 2014 19:34:08 -0700 (PDT) In-Reply-To: <83siqjb50u.fsf@gnu.org> References: <7365721.BnaR1nHazz@lt-gergap> <83siqjb50u.fsf@gnu.org> Date: Sun, 16 Mar 2014 02:34:00 -0000 Message-ID: Subject: Re: New feature "source-id" From: Doug Evans To: Eli Zaretskii Cc: Gerhard Gappmeier , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00346.txt.bz2 On Sat, Mar 15, 2014 at 1:06 PM, Eli Zaretskii wrote: >> Date: Sat, 15 Mar 2014 10:32:12 -0700 >> From: Doug Evans >> Cc: gdb-patches >> >> But IMO the fetching of source must go through the Extension Language API. >> See gdb/extension*.[ch]. >> I.e., don't do the popen in gdb. Just call out to the extension >> language via the API (e.g, Python), passing it the necessary >> parameters. > > That would mean the feature will be unavailable in a GDB compiled > without Python and Guile. Actually, that could be an orthogonal question: the Extension Language API also provides an interface to gdb's own scripting language (e.g., to support auto-loading .gdb scripts). I'm not sure I would go that route though. I have no problem with requiring Python or Guile in order to support this. Note that one concern I have is that it may be that some sites will want to have some of gdb's state updated when source files are automagically fetched. E.g., maybe one would want to update the source search path. Maybe not, but at any rate I don't want this feature to preclude doing things like that, and one can't do that if the feature works by running an external program via popen. btw, Gerhard, this would require a copyright assignment. Do you have one? [If/when (and at this point I'd say it's still a big "if") there is general consensus on adding the feature you'll need to complete an assignment before the patch can be added to the FSF sources. Let me know if you need the necessary paperwork. There's no rush on that, but it's something to keep in mind.